public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lutomirski <andy@luto.us>
To: ilw@linux.intel.com, linux-wireless@vger.kernel.org,
	reinette chatre <reinette.chatre@intel.com>
Subject: [PATCH] iwlcore: Allow runtime configuration of no_sleep_autoadjust
Date: Sun, 8 Nov 2009 14:30:41 -0500	[thread overview]
Message-ID: <cb0375e10911081130k5d8f8347y999cf66a98e6898a@mail.gmail.com> (raw)

Runtime adjustment of no_sleep_autoadjust seems fine, both looking at
the code and in practice.  This makes it easier to test.

Signed-off-by: Andy Lutomirski <luto@mit.edu>
---
I've been running this patch (and twiddling the setting) for a couple
months now, and it seems to work fine.  I think it's a bit late for
2.6.32, even though it's pretty much impossible for this to cause any
regressions, but it would be nice to see it go in for 2.6.33 until
no_sleep_autoadjust goes away.

diff --git a/drivers/net/wireless/iwlwifi/iwl-power.c
b/drivers/net/wireless/iwlwifi/iwl-power.c
index 60be976..4eba1ab 100644
--- a/drivers/net/wireless/iwlwifi/iwl-power.c
+++ b/drivers/net/wireless/iwlwifi/iwl-power.c
@@ -54,7 +54,7 @@
  * adjusting ...
  */
 bool no_sleep_autoadjust = true;
-module_param(no_sleep_autoadjust, bool, S_IRUGO);
+module_param(no_sleep_autoadjust, bool, S_IRUGO | S_IWUSR);
 MODULE_PARM_DESC(no_sleep_autoadjust,
 		 "don't automatically adjust sleep level "
 		 "according to maximum network latency");

             reply	other threads:[~2009-11-08 19:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-08 19:30 Andrew Lutomirski [this message]
2009-11-09 17:19 ` [PATCH] iwlcore: Allow runtime configuration of no_sleep_autoadjust reinette chatre
2009-11-09 18:07   ` Andrew Lutomirski
2009-11-09 22:21     ` reinette chatre
2009-11-09 22:47       ` Andrew Lutomirski
2009-11-09 23:01         ` reinette chatre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb0375e10911081130k5d8f8347y999cf66a98e6898a@mail.gmail.com \
    --to=andy@luto.us \
    --cc=ilw@linux.intel.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=reinette.chatre@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox