[RFC] iw: add support for retry limit

Linux wireless drivers development
 help / color / mirror / Atom feed

* [RFC] iw: add support for retry limit
@ 2014-01-09 13:22 Ujjal Roy
  2014-01-24 15:00 ` Johannes Berg
  0 siblings, 1 reply; 4+ messages in thread
From: Ujjal Roy @ 2014-01-09 13:22 UTC (permalink / raw)
  To: Johannes Berg; +Cc: WiFi Mailing List

Show the retry limit in phy details and also configure the
retry limit.

Signed-off-by: Ujjal Roy <royujjal@gmail.com>
---
 info.c | 16 ++++++++++++++++
 phy.c  | 39 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 55 insertions(+)

diff --git a/info.c b/info.c
index a696503..08b3292 100644
--- a/info.c
+++ b/info.c
@@ -246,6 +246,22 @@ next:
 			printf("\tRTS threshold: %d\n", rts);
 	}
 
+	if (tb_msg[NL80211_ATTR_WIPHY_RETRY_SHORT] ||
+	    tb_msg[NL80211_ATTR_WIPHY_RETRY_LONG]) {
+		unsigned char retry_s = 0, retry_l = 0;
+
+		if (tb_msg[NL80211_ATTR_WIPHY_RETRY_SHORT])
+			retry_s = nla_get_u8(tb_msg[NL80211_ATTR_WIPHY_RETRY_SHORT]);
+		if (tb_msg[NL80211_ATTR_WIPHY_RETRY_LONG])
+			retry_l = nla_get_u8(tb_msg[NL80211_ATTR_WIPHY_RETRY_LONG]);
+		if (retry_s == retry_l) {
+			printf("\tRetry short long limit: %d\n", retry_s);
+		} else {
+			printf("\tRetry short limit: %d\n", retry_s);
+			printf("\tRetry long limit: %d\n", retry_l);
+		}
+	}
+
 	if (tb_msg[NL80211_ATTR_WIPHY_COVERAGE_CLASS]) {
 		unsigned char coverage;
 
diff --git a/phy.c b/phy.c
index 68f40f6..da05103 100644
--- a/phy.c
+++ b/phy.c
@@ -232,6 +232,45 @@ COMMAND(set, rts, "<rts threshold|off>",
 	NL80211_CMD_SET_WIPHY, 0, CIB_PHY, handle_rts,
 	"Set rts threshold.");
 
+static int handle_retry(struct nl80211_state *state,
+		      struct nl_cb *cb, struct nl_msg *msg,
+		      int argc, char **argv,
+		      enum id_input id)
+{
+	unsigned int retry_short = 0, retry_long = 0;
+	char *end;
+
+	if (!argc || argc > 2)
+		return 1;
+
+	if (!*argv[0])
+		return 1;
+	retry_short = strtoul(argv[0], &end, 10);
+	if (*end != '\0')
+		return 1;
+	if (!retry_short || retry_short > 255)
+		return -EINVAL;
+	NLA_PUT_U8(msg, NL80211_ATTR_WIPHY_RETRY_SHORT, retry_short);
+
+	if (argc == 2) {
+		if (!*argv[1])
+			return 1;
+		retry_long = strtoul(argv[1], &end, 10);
+		if (*end != '\0')
+			return 1;
+		if (!retry_long || retry_long > 255)
+			return -EINVAL;
+		NLA_PUT_U8(msg, NL80211_ATTR_WIPHY_RETRY_LONG, retry_long);
+	}
+
+	return 0;
+ nla_put_failure:
+	return -ENOBUFS;
+}
+COMMAND(set, retry, "<short limit> [<long limit>]",
+	NL80211_CMD_SET_WIPHY, 0, CIB_PHY, handle_retry,
+	"Set retry limit.");
+
 static int handle_netns(struct nl80211_state *state,
 			struct nl_cb *cb,
 			struct nl_msg *msg,
-- 
1.8.1.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [RFC] iw: add support for retry limit
  2014-01-09 13:22 [RFC] iw: add support for retry limit Ujjal Roy
@ 2014-01-24 15:00 ` Johannes Berg
  2014-01-30 11:13   ` [PATCHv2] iw: add support to set/get " Ujjal Roy
  2014-01-30 11:20   ` Ujjal Roy
  0 siblings, 2 replies; 4+ messages in thread
From: Johannes Berg @ 2014-01-24 15:00 UTC (permalink / raw)
  To: Ujjal Roy; +Cc: WiFi Mailing List

On Thu, 2014-01-09 at 18:52 +0530, Ujjal Roy wrote:

Sorry for the late reply.

> @@ -232,6 +232,45 @@ COMMAND(set, rts, "<rts threshold|off>",
>  	NL80211_CMD_SET_WIPHY, 0, CIB_PHY, handle_rts,
>  	"Set rts threshold.");
>  
> +static int handle_retry(struct nl80211_state *state,
> +		      struct nl_cb *cb, struct nl_msg *msg,
> +		      int argc, char **argv,
> +		      enum id_input id)

indentation is a bit off

> +COMMAND(set, retry, "<short limit> [<long limit>]",
> +	NL80211_CMD_SET_WIPHY, 0, CIB_PHY, handle_retry,
> +	"Set retry limit.");

This seems odd to me, why would you want to allow setting the short
limit while not changing the long one, but not the other way around?

johannes


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCHv2] iw: add support to set/get retry limit
  2014-01-24 15:00 ` Johannes Berg
@ 2014-01-30 11:13   ` Ujjal Roy
  2014-01-30 11:20   ` Ujjal Roy
  1 sibling, 0 replies; 4+ messages in thread
From: Ujjal Roy @ 2014-01-30 11:13 UTC (permalink / raw)
  To: linux-wireless

Johannes Berg <johannes@...> writes:

> > +COMMAND(set, retry, "<short limit> [<long limit>]",
> > +	NL80211_CMD_SET_WIPHY, 0, CIB_PHY, handle_retry,
> > +	"Set retry limit.");
> 
> This seems odd to me, why would you want to allow setting the short
> limit while not changing the long one, but not the other way around?

Sorry for late response and thanks for the suggestion. The modified
patch is below after 3 dashes.

---
Show the retry limit in phy details and also configure the
retry limit.

Signed-off-by: Ujjal Roy <royujjal@gmail.com>
---
 info.c | 16 ++++++++++++++++
 phy.c  | 64 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 80 insertions(+)

diff --git a/info.c b/info.c
index a696503..001b317 100644
--- a/info.c
+++ b/info.c
@@ -246,6 +246,22 @@ next:
 			printf("\tRTS threshold: %d\n", rts);
 	}
 
+	if (tb_msg[NL80211_ATTR_WIPHY_RETRY_SHORT] ||
+	    tb_msg[NL80211_ATTR_WIPHY_RETRY_LONG]) {
+		unsigned char retry_short = 0, retry_long = 0;
+
+		if (tb_msg[NL80211_ATTR_WIPHY_RETRY_SHORT])
+			retry_short = 
nla_get_u8(tb_msg[NL80211_ATTR_WIPHY_RETRY_SHORT]);
+		if (tb_msg[NL80211_ATTR_WIPHY_RETRY_LONG])
+			retry_long = 
nla_get_u8(tb_msg[NL80211_ATTR_WIPHY_RETRY_LONG]);
+		if (retry_short == retry_long) {
+			printf("\tRetry short long limit: %d\n", 
retry_short);
+		} else {
+			printf("\tRetry short limit: %d\n", retry_short);
+			printf("\tRetry long limit: %d\n", retry_long);
+		}
+	}
+
 	if (tb_msg[NL80211_ATTR_WIPHY_COVERAGE_CLASS]) {
 		unsigned char coverage;
 
diff --git a/phy.c b/phy.c
index 68f40f6..517d203 100644
--- a/phy.c
+++ b/phy.c
@@ -232,6 +232,70 @@ COMMAND(set, rts, "<rts threshold|off>",
 	NL80211_CMD_SET_WIPHY, 0, CIB_PHY, handle_rts,
 	"Set rts threshold.");
 
+static int handle_retry(struct nl80211_state *state,
+			struct nl_cb *cb, struct nl_msg *msg,
+			int argc, char **argv, enum id_input id)
+{
+	unsigned int retry_short = 0, retry_long = 0;
+	bool have_retry_s = false, have_retry_l = false;
+	int i;
+	enum {
+		S_NONE,
+		S_SHORT,
+		S_LONG,
+	} parser_state = S_NONE;
+
+	if (!argc || (argc != 2 && argc != 4))
+		return 1;
+
+	for (i = 0; i < argc; i++) {
+		char *end;
+		unsigned int tmpul;
+
+		if (strcmp(argv[i], "short") == 0) {
+			if (have_retry_s)
+				return 1;
+			parser_state = S_SHORT;
+			have_retry_s = true;
+		} else if (strcmp(argv[i], "long") == 0) {
+			if (have_retry_l)
+				return 1;
+			parser_state = S_LONG;
+			have_retry_l = true;
+		} else {
+			tmpul = strtoul(argv[i], &end, 10);
+			if (*end != '\0')
+				return 1;
+			if (!tmpul || tmpul > 255)
+				return -EINVAL;
+			switch (parser_state) {
+			case S_SHORT:
+				retry_short = tmpul;
+				break;
+			case S_LONG:
+				retry_long = tmpul;
+				break;
+			default:
+				return 1;
+			}
+		}
+	}
+
+	if (!have_retry_s && !have_retry_l)
+		return 1;
+	if (have_retry_s)
+		NLA_PUT_U8(msg, NL80211_ATTR_WIPHY_RETRY_SHORT, 
retry_short);
+	if (have_retry_l)
+		NLA_PUT_U8(msg, NL80211_ATTR_WIPHY_RETRY_LONG, retry_long);
+
+	return 0;
+ nla_put_failure:
+	return -ENOBUFS;
+}
+COMMAND(set, retry, "[short <limit>] [long <limit>]",
+	NL80211_CMD_SET_WIPHY, 0, CIB_PHY, handle_retry,
+	"Set retry limit.");
+
 static int handle_netns(struct nl80211_state *state,
 			struct nl_cb *cb,
 			struct nl_msg *msg,
-- 
1.8.1.4



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCHv2] iw: add support to set/get retry limit
  2014-01-24 15:00 ` Johannes Berg
  2014-01-30 11:13   ` [PATCHv2] iw: add support to set/get " Ujjal Roy
@ 2014-01-30 11:20   ` Ujjal Roy
  1 sibling, 0 replies; 4+ messages in thread
From: Ujjal Roy @ 2014-01-30 11:20 UTC (permalink / raw)
  To: linux-wireless

Johannes Berg <johannes@...> writes:

> > +COMMAND(set, retry, "<short limit> [<long limit>]",
> > +	NL80211_CMD_SET_WIPHY, 0, CIB_PHY, handle_retry,
> > +	"Set retry limit.");
> 
> This seems odd to me, why would you want to allow setting the short
> limit while not changing the long one, but not the other way around?

Sorry for late response and thanks for the suggestion. The modified
patch is below after 3 dashes.

---
Show the retry limit in phy details and also configure the
retry limit.

Signed-off-by: Ujjal Roy <royujjal@gmail.com>
---
 info.c | 16 ++++++++++++++++
 phy.c  | 64 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 80 insertions(+)

diff --git a/info.c b/info.c
index a696503..001b317 100644
--- a/info.c
+++ b/info.c
@@ -246,6 +246,22 @@ next:
 			printf("\tRTS threshold: %d\n", rts);
 	}
 
+	if (tb_msg[NL80211_ATTR_WIPHY_RETRY_SHORT] ||
+	    tb_msg[NL80211_ATTR_WIPHY_RETRY_LONG]) {
+		unsigned char retry_short = 0, retry_long = 0;
+
+		if (tb_msg[NL80211_ATTR_WIPHY_RETRY_SHORT])
+			retry_short = 
nla_get_u8(tb_msg[NL80211_ATTR_WIPHY_RETRY_SHORT]);
+		if (tb_msg[NL80211_ATTR_WIPHY_RETRY_LONG])
+			retry_long = 
nla_get_u8(tb_msg[NL80211_ATTR_WIPHY_RETRY_LONG]);
+		if (retry_short == retry_long) {
+			printf("\tRetry short long limit: %d\n", 
retry_short);
+		} else {
+			printf("\tRetry short limit: %d\n", retry_short);
+			printf("\tRetry long limit: %d\n", retry_long);
+		}
+	}
+
 	if (tb_msg[NL80211_ATTR_WIPHY_COVERAGE_CLASS]) {
 		unsigned char coverage;
 
diff --git a/phy.c b/phy.c
index 68f40f6..517d203 100644
--- a/phy.c
+++ b/phy.c
@@ -232,6 +232,70 @@ COMMAND(set, rts, "<rts threshold|off>",
 	NL80211_CMD_SET_WIPHY, 0, CIB_PHY, handle_rts,
 	"Set rts threshold.");
 
+static int handle_retry(struct nl80211_state *state,
+			struct nl_cb *cb, struct nl_msg *msg,
+			int argc, char **argv, enum id_input id)
+{
+	unsigned int retry_short = 0, retry_long = 0;
+	bool have_retry_s = false, have_retry_l = false;
+	int i;
+	enum {
+		S_NONE,
+		S_SHORT,
+		S_LONG,
+	} parser_state = S_NONE;
+
+	if (!argc || (argc != 2 && argc != 4))
+		return 1;
+
+	for (i = 0; i < argc; i++) {
+		char *end;
+		unsigned int tmpul;
+
+		if (strcmp(argv[i], "short") == 0) {
+			if (have_retry_s)
+				return 1;
+			parser_state = S_SHORT;
+			have_retry_s = true;
+		} else if (strcmp(argv[i], "long") == 0) {
+			if (have_retry_l)
+				return 1;
+			parser_state = S_LONG;
+			have_retry_l = true;
+		} else {
+			tmpul = strtoul(argv[i], &end, 10);
+			if (*end != '\0')
+				return 1;
+			if (!tmpul || tmpul > 255)
+				return -EINVAL;
+			switch (parser_state) {
+			case S_SHORT:
+				retry_short = tmpul;
+				break;
+			case S_LONG:
+				retry_long = tmpul;
+				break;
+			default:
+				return 1;
+			}
+		}
+	}
+
+	if (!have_retry_s && !have_retry_l)
+		return 1;
+	if (have_retry_s)
+		NLA_PUT_U8(msg, NL80211_ATTR_WIPHY_RETRY_SHORT, 
retry_short);
+	if (have_retry_l)
+		NLA_PUT_U8(msg, NL80211_ATTR_WIPHY_RETRY_LONG, retry_long);
+
+	return 0;
+ nla_put_failure:
+	return -ENOBUFS;
+}
+COMMAND(set, retry, "[short <limit>] [long <limit>]",
+	NL80211_CMD_SET_WIPHY, 0, CIB_PHY, handle_retry,
+	"Set retry limit.");
+
 static int handle_netns(struct nl80211_state *state,
 			struct nl_cb *cb,
 			struct nl_msg *msg,
-- 
1.8.1.4



^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-01-30 11:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-09 13:22 [RFC] iw: add support for retry limit Ujjal Roy
2014-01-24 15:00 ` Johannes Berg
2014-01-30 11:13   ` [PATCHv2] iw: add support to set/get " Ujjal Roy
2014-01-30 11:20   ` Ujjal Roy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox