[PATCH bluetooth-next] mac802154: fix transmission power datatype

[PATCH bluetooth-next] mac802154: fix transmission power datatype

[Varka Bhadram]

Available 802.15.4 devices support multiple power levels,
which includes positive and negative values.This patch fix
set_txpower() operation arugument type to signed from int

Signed-off-by: Varka Bhadram <varkab@cdac.in>
---
 include/net/mac802154.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/net/mac802154.h b/include/net/mac802154.h
index fb4e8a3d..1213419 100644
--- a/include/net/mac802154.h
+++ b/include/net/mac802154.h
@@ -213,7 +213,7 @@ struct ieee802154_ops {
 	int		(*set_hw_addr_filt)(struct ieee802154_hw *hw,
 					    struct ieee802154_hw_addr_filt *filt,
 					    unsigned long changed);
-	int		(*set_txpower)(struct ieee802154_hw *hw, int db);
+	int		(*set_txpower)(struct ieee802154_hw *hw, s8 dbm);
 	int		(*set_lbt)(struct ieee802154_hw *hw, bool on);
 	int		(*set_cca_mode)(struct ieee802154_hw *hw,
 					const struct wpan_phy_cca *cca);
-- 
1.7.9.5

Re: [PATCH bluetooth-next] mac802154: fix transmission power datatype

[Marcel Holtmann]

Hi Varka,

> Available 802.15.4 devices support multiple power levels,
> which includes positive and negative values.This patch fix
> set_txpower() operation arugument type to signed from int
> 
> Signed-off-by: Varka Bhadram <varkab@cdac.in>
> ---
> include/net/mac802154.h |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/net/mac802154.h b/include/net/mac802154.h
> index fb4e8a3d..1213419 100644
> --- a/include/net/mac802154.h
> +++ b/include/net/mac802154.h
> @@ -213,7 +213,7 @@ struct ieee802154_ops {
> 	int		(*set_hw_addr_filt)(struct ieee802154_hw *hw,
> 					    struct ieee802154_hw_addr_filt *filt,
> 					    unsigned long changed);
> -	int		(*set_txpower)(struct ieee802154_hw *hw, int db);
> +	int		(*set_txpower)(struct ieee802154_hw *hw, s8 dbm);

the commit message is pretty much non-sense. int is as signed as s8.

Regards

Marcel

Re: [PATCH bluetooth-next] mac802154: fix transmission power datatype

[Varka Bhadram]

On 04/09/2015 12:58 PM, Marcel Holtmann wrote:
> Hi Varka,
>
>> Available 802.15.4 devices support multiple power levels,
>> which includes positive and negative values.This patch fix
>> set_txpower() operation arugument type to signed from int
>>
>> Signed-off-by: Varka Bhadram <varkab@cdac.in>
>> ---
>> include/net/mac802154.h |    2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/net/mac802154.h b/include/net/mac802154.h
>> index fb4e8a3d..1213419 100644
>> --- a/include/net/mac802154.h
>> +++ b/include/net/mac802154.h
>> @@ -213,7 +213,7 @@ struct ieee802154_ops {
>> 	int		(*set_hw_addr_filt)(struct ieee802154_hw *hw,
>> 					    struct ieee802154_hw_addr_filt *filt,
>> 					    unsigned long changed);
>> -	int		(*set_txpower)(struct ieee802154_hw *hw, int db);
>> +	int		(*set_txpower)(struct ieee802154_hw *hw, s8 dbm);
> the commit message is pretty much non-sense. int is as signed as s8.

The netlink attribute for the power level is s8. At mac level the values
stored in s8 only [1].

[1]: http://git.kernel.org/cgit/linux/kernel/git/bluetooth/bluetooth-next.git/tree/net/mac802154/driver-ops.h#n61

> Regards
>
> Marcel
>

-- 
Varka Bhadram


-------------------------------------------------------------------------------------------------------------------------------
[ C-DAC is on Social-Media too. Kindly follow us at:
Facebook: https://www.facebook.com/CDACINDIA & Twitter: @cdacindia ]

This e-mail is for the sole use of the intended recipient(s) and may
contain confidential and privileged information. If you are not the
intended recipient, please contact the sender by reply e-mail and destroy
all copies and the original message. Any unauthorized review, use,
disclosure, dissemination, forwarding, printing or copying of this email
is strictly prohibited and appropriate legal action will be taken.
-------------------------------------------------------------------------------------------------------------------------------

Re: [PATCH bluetooth-next] mac802154: fix transmission power datatype

[Marcel Holtmann]

Hi Varka,

>>> Available 802.15.4 devices support multiple power levels,
>>> which includes positive and negative values.This patch fix
>>> set_txpower() operation arugument type to signed from int
>>> 
>>> Signed-off-by: Varka Bhadram <varkab@cdac.in>
>>> ---
>>> include/net/mac802154.h |    2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>> 
>>> diff --git a/include/net/mac802154.h b/include/net/mac802154.h
>>> index fb4e8a3d..1213419 100644
>>> --- a/include/net/mac802154.h
>>> +++ b/include/net/mac802154.h
>>> @@ -213,7 +213,7 @@ struct ieee802154_ops {
>>> 	int		(*set_hw_addr_filt)(struct ieee802154_hw *hw,
>>> 					    struct ieee802154_hw_addr_filt *filt,
>>> 					    unsigned long changed);
>>> -	int		(*set_txpower)(struct ieee802154_hw *hw, int db);
>>> +	int		(*set_txpower)(struct ieee802154_hw *hw, s8 dbm);
>> the commit message is pretty much non-sense. int is as signed as s8.
> 
> The netlink attribute for the power level is s8. At mac level the values
> stored in s8 only [1].

sure, but the commit message is still non-sense.

Regards

Marcel

Re: [PATCH bluetooth-next] mac802154: fix transmission power datatype

[Varka Bhadram]

On 04/09/2015 01:16 PM, Marcel Holtmann wrote:
> Hi Varka,
>
>>>> Available 802.15.4 devices support multiple power levels,
>>>> which includes positive and negative values.This patch fix
>>>> set_txpower() operation arugument type to signed from int
>>>>
>>>> Signed-off-by: Varka Bhadram <varkab@cdac.in>
>>>> ---
>>>> include/net/mac802154.h |    2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/include/net/mac802154.h b/include/net/mac802154.h
>>>> index fb4e8a3d..1213419 100644
>>>> --- a/include/net/mac802154.h
>>>> +++ b/include/net/mac802154.h
>>>> @@ -213,7 +213,7 @@ struct ieee802154_ops {
>>>> 	int		(*set_hw_addr_filt)(struct ieee802154_hw *hw,
>>>> 					    struct ieee802154_hw_addr_filt *filt,
>>>> 					    unsigned long changed);
>>>> -	int		(*set_txpower)(struct ieee802154_hw *hw, int db);
>>>> +	int		(*set_txpower)(struct ieee802154_hw *hw, s8 dbm);
>>> the commit message is pretty much non-sense. int is as signed as s8.
>> The netlink attribute for the power level is s8. At mac level the values
>> stored in s8 only [1].
> sure, but the commit message is still non-sense.

Ok. I will change the commit and also i need to add the change to at86rf230 driver.

--
Thanks
Varka Bhadram