Linux IEEE 802.15.4 and 6LoWPAN development
 help / color / mirror / Atom feed
From: Varka Bhadram <varkabhadram@gmail.com>
To: Alexander Aring <alex.aring@gmail.com>, linux-wpan@vger.kernel.org
Cc: kernel@pengutronix.de, "Guido Günther" <agx@sigxcpu.org>
Subject: Re: [PATCHv2 wpan-tools] interface: use hexadecimal for print extended addr
Date: Thu, 07 May 2015 18:01:45 +0530	[thread overview]
Message-ID: <554B5B31.4060503@gmail.com> (raw)
In-Reply-To: <1431001593-30128-1-git-send-email-alex.aring@gmail.com>

On 05/07/2015 05:56 PM, Alexander Aring wrote:
> This patch prints the extended addr in hexadecimal value. This is what
> the "0x...." prefix suggested.
>
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> Cc: Guido Günther <agx@sigxcpu.org>
> ---
> changes since v2:
>  - s/inteface/interface/
>  - can't remove the v we are already at v2

Nice. Reviewed-by: Varka Bhadram <varkabhadram@gmail.com>

>  src/interface.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/interface.c b/src/interface.c
> index 5e0ef89..e501763 100644
> --- a/src/interface.c
> +++ b/src/interface.c
> @@ -203,7 +203,7 @@ static int print_iface_handler(struct nl_msg *msg, void *arg)
>  		printf("%s\twpan_dev 0x%llx\n", indent,
>  		       (unsigned long long)nla_get_u64(tb_msg[NL802154_ATTR_WPAN_DEV]));
>  	if (tb_msg[NL802154_ATTR_EXTENDED_ADDR])
> -		printf("%s\textended_addr 0x%016" PRIu64 "\n", indent,
> +		printf("%s\textended_addr 0x%016" PRIx64 "\n", indent,
>  		       le64toh(nla_get_u64(tb_msg[NL802154_ATTR_EXTENDED_ADDR])));
>  	if (tb_msg[NL802154_ATTR_SHORT_ADDR])
>  		printf("%s\tshort_addr 0x%04x\n", indent,


-- 
Varka Bhadram


  reply	other threads:[~2015-05-07 12:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-07 12:26 [PATCHv2 wpan-tools] interface: use hexadecimal for print extended addr Alexander Aring
2015-05-07 12:31 ` Varka Bhadram [this message]
2015-05-07 14:24 ` Guido Günther
2015-05-08  7:00   ` Alexander Aring
2015-05-08  7:08     ` Guido Günther
2015-05-08  8:08 ` Martin Townsend

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=554B5B31.4060503@gmail.com \
    --to=varkabhadram@gmail.com \
    --cc=agx@sigxcpu.org \
    --cc=alex.aring@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-wpan@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox