* [PATCHv2 wpan-tools] interface: use hexadecimal for print extended addr
@ 2015-05-07 12:26 Alexander Aring
2015-05-07 12:31 ` Varka Bhadram
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Alexander Aring @ 2015-05-07 12:26 UTC (permalink / raw)
To: linux-wpan; +Cc: kernel, Alexander Aring, Guido Günther
This patch prints the extended addr in hexadecimal value. This is what
the "0x...." prefix suggested.
Signed-off-by: Alexander Aring <alex.aring@gmail.com>
Cc: Guido Günther <agx@sigxcpu.org>
---
changes since v2:
- s/inteface/interface/
- can't remove the v we are already at v2
src/interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/interface.c b/src/interface.c
index 5e0ef89..e501763 100644
--- a/src/interface.c
+++ b/src/interface.c
@@ -203,7 +203,7 @@ static int print_iface_handler(struct nl_msg *msg, void *arg)
printf("%s\twpan_dev 0x%llx\n", indent,
(unsigned long long)nla_get_u64(tb_msg[NL802154_ATTR_WPAN_DEV]));
if (tb_msg[NL802154_ATTR_EXTENDED_ADDR])
- printf("%s\textended_addr 0x%016" PRIu64 "\n", indent,
+ printf("%s\textended_addr 0x%016" PRIx64 "\n", indent,
le64toh(nla_get_u64(tb_msg[NL802154_ATTR_EXTENDED_ADDR])));
if (tb_msg[NL802154_ATTR_SHORT_ADDR])
printf("%s\tshort_addr 0x%04x\n", indent,
--
2.3.7
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCHv2 wpan-tools] interface: use hexadecimal for print extended addr
2015-05-07 12:26 [PATCHv2 wpan-tools] interface: use hexadecimal for print extended addr Alexander Aring
@ 2015-05-07 12:31 ` Varka Bhadram
2015-05-07 14:24 ` Guido Günther
2015-05-08 8:08 ` Martin Townsend
2 siblings, 0 replies; 6+ messages in thread
From: Varka Bhadram @ 2015-05-07 12:31 UTC (permalink / raw)
To: Alexander Aring, linux-wpan; +Cc: kernel, Guido Günther
On 05/07/2015 05:56 PM, Alexander Aring wrote:
> This patch prints the extended addr in hexadecimal value. This is what
> the "0x...." prefix suggested.
>
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> Cc: Guido Günther <agx@sigxcpu.org>
> ---
> changes since v2:
> - s/inteface/interface/
> - can't remove the v we are already at v2
Nice. Reviewed-by: Varka Bhadram <varkabhadram@gmail.com>
> src/interface.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/interface.c b/src/interface.c
> index 5e0ef89..e501763 100644
> --- a/src/interface.c
> +++ b/src/interface.c
> @@ -203,7 +203,7 @@ static int print_iface_handler(struct nl_msg *msg, void *arg)
> printf("%s\twpan_dev 0x%llx\n", indent,
> (unsigned long long)nla_get_u64(tb_msg[NL802154_ATTR_WPAN_DEV]));
> if (tb_msg[NL802154_ATTR_EXTENDED_ADDR])
> - printf("%s\textended_addr 0x%016" PRIu64 "\n", indent,
> + printf("%s\textended_addr 0x%016" PRIx64 "\n", indent,
> le64toh(nla_get_u64(tb_msg[NL802154_ATTR_EXTENDED_ADDR])));
> if (tb_msg[NL802154_ATTR_SHORT_ADDR])
> printf("%s\tshort_addr 0x%04x\n", indent,
--
Varka Bhadram
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCHv2 wpan-tools] interface: use hexadecimal for print extended addr
2015-05-07 12:26 [PATCHv2 wpan-tools] interface: use hexadecimal for print extended addr Alexander Aring
2015-05-07 12:31 ` Varka Bhadram
@ 2015-05-07 14:24 ` Guido Günther
2015-05-08 7:00 ` Alexander Aring
2015-05-08 8:08 ` Martin Townsend
2 siblings, 1 reply; 6+ messages in thread
From: Guido Günther @ 2015-05-07 14:24 UTC (permalink / raw)
To: Alexander Aring; +Cc: linux-wpan, kernel
On Thu, May 07, 2015 at 02:26:33PM +0200, Alexander Aring wrote:
> This patch prints the extended addr in hexadecimal value. This is what
> the "0x...." prefix suggested.
>
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> Cc: Guido Günther <agx@sigxcpu.org>
> ---
> changes since v2:
> - s/inteface/interface/
> - can't remove the v we are already at v2
>
> src/interface.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/interface.c b/src/interface.c
> index 5e0ef89..e501763 100644
> --- a/src/interface.c
> +++ b/src/interface.c
> @@ -203,7 +203,7 @@ static int print_iface_handler(struct nl_msg *msg, void *arg)
> printf("%s\twpan_dev 0x%llx\n", indent,
> (unsigned long long)nla_get_u64(tb_msg[NL802154_ATTR_WPAN_DEV]));
> if (tb_msg[NL802154_ATTR_EXTENDED_ADDR])
> - printf("%s\textended_addr 0x%016" PRIu64 "\n", indent,
> + printf("%s\textended_addr 0x%016" PRIx64 "\n", indent,
ACK.
-- Guido
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCHv2 wpan-tools] interface: use hexadecimal for print extended addr
2015-05-07 14:24 ` Guido Günther
@ 2015-05-08 7:00 ` Alexander Aring
2015-05-08 7:08 ` Guido Günther
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Aring @ 2015-05-08 7:00 UTC (permalink / raw)
To: Guido Günther; +Cc: linux-wpan, kernel
On Thu, May 07, 2015 at 04:24:03PM +0200, Guido Günther wrote:
> On Thu, May 07, 2015 at 02:26:33PM +0200, Alexander Aring wrote:
> > This patch prints the extended addr in hexadecimal value. This is what
> > the "0x...." prefix suggested.
> >
> > Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> > Cc: Guido Günther <agx@sigxcpu.org>
> > ---
> > changes since v2:
> > - s/inteface/interface/
> > - can't remove the v we are already at v2
> >
> > src/interface.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/interface.c b/src/interface.c
> > index 5e0ef89..e501763 100644
> > --- a/src/interface.c
> > +++ b/src/interface.c
> > @@ -203,7 +203,7 @@ static int print_iface_handler(struct nl_msg *msg, void *arg)
> > printf("%s\twpan_dev 0x%llx\n", indent,
> > (unsigned long long)nla_get_u64(tb_msg[NL802154_ATTR_WPAN_DEV]));
> > if (tb_msg[NL802154_ATTR_EXTENDED_ADDR])
> > - printf("%s\textended_addr 0x%016" PRIu64 "\n", indent,
> > + printf("%s\textended_addr 0x%016" PRIx64 "\n", indent,
>
> ACK.
Please answer with:
Acked-by: name of the great person which acked <mail of great person>
then I can take it into the git log.
- Alex
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCHv2 wpan-tools] interface: use hexadecimal for print extended addr
2015-05-08 7:00 ` Alexander Aring
@ 2015-05-08 7:08 ` Guido Günther
0 siblings, 0 replies; 6+ messages in thread
From: Guido Günther @ 2015-05-08 7:08 UTC (permalink / raw)
To: Alexander Aring; +Cc: linux-wpan, kernel
On Fri, May 08, 2015 at 09:00:06AM +0200, Alexander Aring wrote:
> On Thu, May 07, 2015 at 04:24:03PM +0200, Guido Günther wrote:
> > On Thu, May 07, 2015 at 02:26:33PM +0200, Alexander Aring wrote:
> > > This patch prints the extended addr in hexadecimal value. This is what
> > > the "0x...." prefix suggested.
> > >
> > > Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> > > Cc: Guido Günther <agx@sigxcpu.org>
> > > ---
> > > changes since v2:
> > > - s/inteface/interface/
> > > - can't remove the v we are already at v2
> > >
> > > src/interface.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/src/interface.c b/src/interface.c
> > > index 5e0ef89..e501763 100644
> > > --- a/src/interface.c
> > > +++ b/src/interface.c
> > > @@ -203,7 +203,7 @@ static int print_iface_handler(struct nl_msg *msg, void *arg)
> > > printf("%s\twpan_dev 0x%llx\n", indent,
> > > (unsigned long long)nla_get_u64(tb_msg[NL802154_ATTR_WPAN_DEV]));
> > > if (tb_msg[NL802154_ATTR_EXTENDED_ADDR])
> > > - printf("%s\textended_addr 0x%016" PRIu64 "\n", indent,
> > > + printf("%s\textended_addr 0x%016" PRIx64 "\n", indent,
> >
> > ACK.
>
> Please answer with:
>
> Acked-by: name of the great person which acked <mail of great person>
>
> then I can take it into the git log.
Although I'm certainly not a great person by any means:
Acked-by: Guido Günther <agx@sigxcpu.org>
Cheers,
-- Guido
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCHv2 wpan-tools] interface: use hexadecimal for print extended addr
2015-05-07 12:26 [PATCHv2 wpan-tools] interface: use hexadecimal for print extended addr Alexander Aring
2015-05-07 12:31 ` Varka Bhadram
2015-05-07 14:24 ` Guido Günther
@ 2015-05-08 8:08 ` Martin Townsend
2 siblings, 0 replies; 6+ messages in thread
From: Martin Townsend @ 2015-05-08 8:08 UTC (permalink / raw)
To: Alexander Aring, linux-wpan; +Cc: kernel, Guido Günther
Tested-by: Martin Townsend <martin.townsend@xsilon.com>
iwpan dev
phy#2
Interface wpan2
ifindex 12
wpan_dev 0x200000002
extended_addr 0x00039a000002012c
short_addr 0xffff
pan_id 0xffff
type node
max_frame_retries 4
min_be 4
max_be 9
max_csma_backoffs 8
lbt 0
phy#1
Interface wpan1
ifindex 9
wpan_dev 0x100000002
extended_addr 0x00039a000001012c
short_addr 0x012c
pan_id 0x0700
type node
max_frame_retries 4
min_be 4
max_be 9
max_csma_backoffs 8
lbt 0
phy#0
Interface wpan0
ifindex 6
wpan_dev 0x2
extended_addr 0x00039a000000012c
short_addr 0x012c
pan_id 0x0777
type node
max_frame_retries 4
min_be 4
max_be 9
max_csma_backoffs 8
lbt 0
On 07/05/15 13:26, Alexander Aring wrote:
> This patch prints the extended addr in hexadecimal value. This is what
> the "0x...." prefix suggested.
>
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> Cc: Guido Günther <agx@sigxcpu.org>
> ---
> changes since v2:
> - s/inteface/interface/
> - can't remove the v we are already at v2
>
> src/interface.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/interface.c b/src/interface.c
> index 5e0ef89..e501763 100644
> --- a/src/interface.c
> +++ b/src/interface.c
> @@ -203,7 +203,7 @@ static int print_iface_handler(struct nl_msg *msg, void *arg)
> printf("%s\twpan_dev 0x%llx\n", indent,
> (unsigned long long)nla_get_u64(tb_msg[NL802154_ATTR_WPAN_DEV]));
> if (tb_msg[NL802154_ATTR_EXTENDED_ADDR])
> - printf("%s\textended_addr 0x%016" PRIu64 "\n", indent,
> + printf("%s\textended_addr 0x%016" PRIx64 "\n", indent,
> le64toh(nla_get_u64(tb_msg[NL802154_ATTR_EXTENDED_ADDR])));
> if (tb_msg[NL802154_ATTR_SHORT_ADDR])
> printf("%s\tshort_addr 0x%04x\n", indent,
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-05-08 8:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-07 12:26 [PATCHv2 wpan-tools] interface: use hexadecimal for print extended addr Alexander Aring
2015-05-07 12:31 ` Varka Bhadram
2015-05-07 14:24 ` Guido Günther
2015-05-08 7:00 ` Alexander Aring
2015-05-08 7:08 ` Guido Günther
2015-05-08 8:08 ` Martin Townsend
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox