From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs: fix use-after-free when aborting corrupt attr inactivation
Date: Wed, 11 Mar 2020 16:14:44 +1100 [thread overview]
Message-ID: <20200311051444.GS10776@dread.disaster.area> (raw)
In-Reply-To: <158388762432.939081.11036027889087941270.stgit@magnolia>
On Tue, Mar 10, 2020 at 05:47:04PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Log the corrupt buffer before we release the buffer.
>
> Fixes: a5155b870d687 ("xfs: always log corruption errors")
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> fs/xfs/xfs_attr_inactive.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> diff --git a/fs/xfs/xfs_attr_inactive.c b/fs/xfs/xfs_attr_inactive.c
> index bbfa6ba84dcd..fe8f60b59ec4 100644
> --- a/fs/xfs/xfs_attr_inactive.c
> +++ b/fs/xfs/xfs_attr_inactive.c
> @@ -145,8 +145,8 @@ xfs_attr3_node_inactive(
> * Since this code is recursive (gasp!) we must protect ourselves.
> */
> if (level > XFS_DA_NODE_MAXDEPTH) {
> - xfs_trans_brelse(*trans, bp); /* no locks for later trans */
> xfs_buf_corruption_error(bp);
> + xfs_trans_brelse(*trans, bp); /* no locks for later trans */
Yup, that needs fixing.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2020-03-11 5:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 0:46 [PATCH 0/2] xfs: random fixes Darrick J. Wong
2020-03-11 0:47 ` [PATCH 1/2] xfs: fix use-after-free when aborting corrupt attr inactivation Darrick J. Wong
2020-03-11 5:14 ` Dave Chinner [this message]
2020-03-11 6:35 ` Christoph Hellwig
2020-03-11 0:47 ` [PATCH 2/2] xfs: fix xfs_rmap_has_other_keys usage of ECANCELED Darrick J. Wong
2020-03-11 5:22 ` Dave Chinner
2020-03-11 6:40 ` Christoph Hellwig
2020-03-11 15:47 ` Darrick J. Wong
2020-03-11 15:52 ` Christoph Hellwig
2020-03-11 16:02 ` Darrick J. Wong
2020-03-11 16:03 ` [PATCH v2 " Darrick J. Wong
2020-03-11 16:07 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311051444.GS10776@dread.disaster.area \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox