[PATCH] xfs: drop EXPERIMENTAL tag for large extent counts

[PATCH] xfs: drop EXPERIMENTAL tag for large extent counts

[Darrick J. Wong]

From: Darrick J. Wong <djwong@kernel.org>

This feature has been baking in upstream for ~10mo with no bug reports.
It seems to work fine here, let's get rid of the scary warnings?

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 fs/xfs/xfs_super.c |    4 ----
 1 file changed, 4 deletions(-)

diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index 4d2e87462ac4..dc13ff4ea25e 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -1683,10 +1683,6 @@ xfs_fs_fill_super(
 		goto out_filestream_unmount;
 	}
 
-	if (xfs_has_large_extent_counts(mp))
-		xfs_warn(mp,
-	"EXPERIMENTAL Large extent counts feature in use. Use at your own risk!");
-
 	error = xfs_mountfs(mp);
 	if (error)
 		goto out_filestream_unmount;

Re: [PATCH] xfs: drop EXPERIMENTAL tag for large extent counts

[Dave Chinner]

On Thu, Apr 20, 2023 at 08:10:00AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> This feature has been baking in upstream for ~10mo with no bug reports.
> It seems to work fine here, let's get rid of the scary warnings?

Are you proposing this for the 6.4 cycle (next weeks merge window)
or for the cycle after this?  I don't see an issue with removing the
experimental tag, but I do think it's a bit late for this cycle....

> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
>  fs/xfs/xfs_super.c |    4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 4d2e87462ac4..dc13ff4ea25e 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -1683,10 +1683,6 @@ xfs_fs_fill_super(
>  		goto out_filestream_unmount;
>  	}
>  
> -	if (xfs_has_large_extent_counts(mp))
> -		xfs_warn(mp,
> -	"EXPERIMENTAL Large extent counts feature in use. Use at your own risk!");
> -

Reviewed-by: Dave Chinner <dchinner@redhat.com>

-- 
Dave Chinner
david@fromorbit.com

Re: [PATCH] xfs: drop EXPERIMENTAL tag for large extent counts

[Darrick J. Wong]

On Fri, Apr 21, 2023 at 09:24:26AM +1000, Dave Chinner wrote:
> On Thu, Apr 20, 2023 at 08:10:00AM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> > 
> > This feature has been baking in upstream for ~10mo with no bug reports.
> > It seems to work fine here, let's get rid of the scary warnings?
> 
> Are you proposing this for the 6.4 cycle (next weeks merge window)
> or for the cycle after this?  I don't see an issue with removing the
> experimental tag, but I do think it's a bit late for this cycle....

Doh, I totally forgot to reply to this.  I /was/ actually targetting
6.4, but I don't have any particular problem if this slips to 6.5.

--D

> > Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> > ---
> >  fs/xfs/xfs_super.c |    4 ----
> >  1 file changed, 4 deletions(-)
> > 
> > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> > index 4d2e87462ac4..dc13ff4ea25e 100644
> > --- a/fs/xfs/xfs_super.c
> > +++ b/fs/xfs/xfs_super.c
> > @@ -1683,10 +1683,6 @@ xfs_fs_fill_super(
> >  		goto out_filestream_unmount;
> >  	}
> >  
> > -	if (xfs_has_large_extent_counts(mp))
> > -		xfs_warn(mp,
> > -	"EXPERIMENTAL Large extent counts feature in use. Use at your own risk!");
> > -
> 
> Reviewed-by: Dave Chinner <dchinner@redhat.com>
> 
> -- 
> Dave Chinner
> david@fromorbit.com