* [PATCH v2] xfs: fix select in config XFS_ONLINE_SCRUB_STATS
@ 2023-08-25 12:05 Lukas Bulwahn
2023-08-25 15:15 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: Lukas Bulwahn @ 2023-08-25 12:05 UTC (permalink / raw)
To: Chandan Babu R, Darrick J . Wong, Dave Chinner, linux-xfs
Cc: kernel-janitors, linux-kernel, Lukas Bulwahn
Commit d7a74cad8f45 ("xfs: track usage statistics of online fsck")
introduces config XFS_ONLINE_SCRUB_STATS, which selects the non-existing
config FS_DEBUG. It is probably intended to select the existing config
XFS_DEBUG.
Fix the select in config XFS_ONLINE_SCRUB_STATS.
Fixes: d7a74cad8f45 ("xfs: track usage statistics of online fsck")
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
Darrick, please pick this quick 'typo' fix.
v2: removed a stupid last-minute insert on my Signed-off-by line.
fs/xfs/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig
index c9d653168ad0..ed0bc8cbc703 100644
--- a/fs/xfs/Kconfig
+++ b/fs/xfs/Kconfig
@@ -147,7 +147,7 @@ config XFS_ONLINE_SCRUB_STATS
bool "XFS online metadata check usage data collection"
default y
depends on XFS_ONLINE_SCRUB
- select FS_DEBUG
+ select XFS_DEBUG
help
If you say Y here, the kernel will gather usage data about
the online metadata check subsystem. This includes the number
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] xfs: fix select in config XFS_ONLINE_SCRUB_STATS
2023-08-25 12:05 [PATCH v2] xfs: fix select in config XFS_ONLINE_SCRUB_STATS Lukas Bulwahn
@ 2023-08-25 15:15 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2023-08-25 15:15 UTC (permalink / raw)
To: Lukas Bulwahn
Cc: Chandan Babu R, Dave Chinner, linux-xfs, kernel-janitors,
linux-kernel
On Fri, Aug 25, 2023 at 02:05:13PM +0200, Lukas Bulwahn wrote:
> Commit d7a74cad8f45 ("xfs: track usage statistics of online fsck")
> introduces config XFS_ONLINE_SCRUB_STATS, which selects the non-existing
> config FS_DEBUG. It is probably intended to select the existing config
> XFS_DEBUG.
>
> Fix the select in config XFS_ONLINE_SCRUB_STATS.
>
> Fixes: d7a74cad8f45 ("xfs: track usage statistics of online fsck")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Oops.
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
> ---
> Darrick, please pick this quick 'typo' fix.
^^^^ isn't the maintainer anymore. ;)
--D
> v2: removed a stupid last-minute insert on my Signed-off-by line.
>
> fs/xfs/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig
> index c9d653168ad0..ed0bc8cbc703 100644
> --- a/fs/xfs/Kconfig
> +++ b/fs/xfs/Kconfig
> @@ -147,7 +147,7 @@ config XFS_ONLINE_SCRUB_STATS
> bool "XFS online metadata check usage data collection"
> default y
> depends on XFS_ONLINE_SCRUB
> - select FS_DEBUG
> + select XFS_DEBUG
> help
> If you say Y here, the kernel will gather usage data about
> the online metadata check subsystem. This includes the number
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-25 15:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-25 12:05 [PATCH v2] xfs: fix select in config XFS_ONLINE_SCRUB_STATS Lukas Bulwahn
2023-08-25 15:15 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox