* [PATCH] xfs: remove unnecessary check
@ 2024-07-12 14:07 Dan Carpenter
2024-07-12 15:18 ` Darrick J. Wong
2024-07-12 17:34 ` Chaitanya Kulkarni
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2024-07-12 14:07 UTC (permalink / raw)
To: Chandan Babu R; +Cc: Darrick J. Wong, linux-xfs, linux-kernel, kernel-janitors
We checked that "pip" is non-NULL at the start of the if else statement
so there is no need to check again here. Delete the check.
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
fs/xfs/libxfs/xfs_inode_util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/libxfs/xfs_inode_util.c b/fs/xfs/libxfs/xfs_inode_util.c
index 032333289113..cc38e1c3c3e1 100644
--- a/fs/xfs/libxfs/xfs_inode_util.c
+++ b/fs/xfs/libxfs/xfs_inode_util.c
@@ -308,7 +308,7 @@ xfs_inode_init(
!vfsgid_in_group_p(i_gid_into_vfsgid(args->idmap, inode)))
inode->i_mode &= ~S_ISGID;
- ip->i_projid = pip ? xfs_get_initial_prid(pip) : 0;
+ ip->i_projid = xfs_get_initial_prid(pip);
}
ip->i_disk_size = 0;
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs: remove unnecessary check
2024-07-12 14:07 [PATCH] xfs: remove unnecessary check Dan Carpenter
@ 2024-07-12 15:18 ` Darrick J. Wong
2024-07-12 17:34 ` Chaitanya Kulkarni
1 sibling, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2024-07-12 15:18 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Chandan Babu R, linux-xfs, linux-kernel, kernel-janitors
On Fri, Jul 12, 2024 at 09:07:36AM -0500, Dan Carpenter wrote:
> We checked that "pip" is non-NULL at the start of the if else statement
> so there is no need to check again here. Delete the check.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Yep.
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> fs/xfs/libxfs/xfs_inode_util.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/libxfs/xfs_inode_util.c b/fs/xfs/libxfs/xfs_inode_util.c
> index 032333289113..cc38e1c3c3e1 100644
> --- a/fs/xfs/libxfs/xfs_inode_util.c
> +++ b/fs/xfs/libxfs/xfs_inode_util.c
> @@ -308,7 +308,7 @@ xfs_inode_init(
> !vfsgid_in_group_p(i_gid_into_vfsgid(args->idmap, inode)))
> inode->i_mode &= ~S_ISGID;
>
> - ip->i_projid = pip ? xfs_get_initial_prid(pip) : 0;
> + ip->i_projid = xfs_get_initial_prid(pip);
> }
>
> ip->i_disk_size = 0;
> --
> 2.43.0
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs: remove unnecessary check
2024-07-12 14:07 [PATCH] xfs: remove unnecessary check Dan Carpenter
2024-07-12 15:18 ` Darrick J. Wong
@ 2024-07-12 17:34 ` Chaitanya Kulkarni
1 sibling, 0 replies; 3+ messages in thread
From: Chaitanya Kulkarni @ 2024-07-12 17:34 UTC (permalink / raw)
To: Dan Carpenter, Chandan Babu R
Cc: Darrick J. Wong, linux-xfs@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
On 7/12/2024 7:07 AM, Dan Carpenter wrote:
> We checked that "pip" is non-NULL at the start of the if else statement
> so there is no need to check again here. Delete the check.
>
> Signed-off-by: Dan Carpenter<dan.carpenter@linaro.org>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-12 17:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-12 14:07 [PATCH] xfs: remove unnecessary check Dan Carpenter
2024-07-12 15:18 ` Darrick J. Wong
2024-07-12 17:34 ` Chaitanya Kulkarni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox