public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: cem@kernel.org
To: linux-xfs@vger.kernel.org
Cc: djwong@kernel.org
Subject: [PATCH] libfrog: Unconditionally build fsprops.c
Date: Mon, 19 Aug 2024 15:22:05 +0200	[thread overview]
Message-ID: <20240819132222.219434-1-cem@kernel.org> (raw)

From: Carlos Maiolino <cem@kernel.org>

The new xfs_io fs properties subcommand, requires fsprops to be build,
while libfrog conditionally build it according to the existence of
libattr.

This causes builds to fail if the libattr headers are not available,
without a clear output.

Now that xfs_io unconditionally requires libfrog/fsprops.c to be built,
remove the condition from libfrog's Makefile.

Fixes: d194cb818305 ("xfs_io: edit filesystem properties")
Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
---
 libfrog/Makefile | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/libfrog/Makefile b/libfrog/Makefile
index acddc894e..53de7c174 100644
--- a/libfrog/Makefile
+++ b/libfrog/Makefile
@@ -21,6 +21,7 @@ crc32.c \
 file_exchange.c \
 fsgeom.c \
 fsproperties.c \
+fsprops.c \
 getparents.c \
 histogram.c \
 list_sort.c \
@@ -49,6 +50,7 @@ div64.h \
 file_exchange.h \
 fsgeom.h \
 fsproperties.h \
+fsprops.h \
 getparents.h \
 histogram.h \
 logging.h \
@@ -61,12 +63,6 @@ scrub.h \
 workqueue.h
 
 LSRCFILES += gen_crc32table.c
-
-ifeq ($(HAVE_LIBATTR),yes)
-CFILES+=fsprops.c
-HFILES+=fsprops.h
-endif
-
 LDIRT = gen_crc32table crc32table.h
 
 default: ltdepend $(LTLIBRARY)
-- 
2.46.0


             reply	other threads:[~2024-08-19 13:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-19 13:22 cem [this message]
2024-08-19 14:09 ` [PATCH] libfrog: Unconditionally build fsprops.c Christoph Hellwig
2024-08-19 15:12   ` Darrick J. Wong
2024-08-19 15:23     ` Christoph Hellwig
2024-08-19 15:57       ` Carlos Maiolino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240819132222.219434-1-cem@kernel.org \
    --to=cem@kernel.org \
    --cc=djwong@kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox