From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: cem@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] libfrog: Unconditionally build fsprops.c
Date: Mon, 19 Aug 2024 08:12:16 -0700 [thread overview]
Message-ID: <20240819151216.GP865349@frogsfrogsfrogs> (raw)
In-Reply-To: <ZsNSHLekoGCThzaj@infradead.org>
On Mon, Aug 19, 2024 at 07:09:32AM -0700, Christoph Hellwig wrote:
> On Mon, Aug 19, 2024 at 03:22:05PM +0200, cem@kernel.org wrote:
> > From: Carlos Maiolino <cem@kernel.org>
> >
> > The new xfs_io fs properties subcommand, requires fsprops to be build,
> > while libfrog conditionally build it according to the existence of
> > libattr.
> >
> > This causes builds to fail if the libattr headers are not available,
> > without a clear output.
> >
> > Now that xfs_io unconditionally requires libfrog/fsprops.c to be built,
> > remove the condition from libfrog's Makefile.
>
> That means we'll also need to make libattr mandatory in configure,
> right?
How about we just opencode ATTR_ENTRY in libfrog and then we can get rid
of the libattr dependency for it and xfs_scrub? IIRC that's the only
piece of libattr that those pieces actually need.
--D
next prev parent reply other threads:[~2024-08-19 15:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 13:22 [PATCH] libfrog: Unconditionally build fsprops.c cem
2024-08-19 14:09 ` Christoph Hellwig
2024-08-19 15:12 ` Darrick J. Wong [this message]
2024-08-19 15:23 ` Christoph Hellwig
2024-08-19 15:57 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240819151216.GP865349@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=cem@kernel.org \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox