public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: cem@kernel.org
Cc: linux-xfs@vger.kernel.org, djwong@kernel.org
Subject: Re: [PATCH] libfrog: Unconditionally build fsprops.c
Date: Mon, 19 Aug 2024 07:09:32 -0700	[thread overview]
Message-ID: <ZsNSHLekoGCThzaj@infradead.org> (raw)
In-Reply-To: <20240819132222.219434-1-cem@kernel.org>

On Mon, Aug 19, 2024 at 03:22:05PM +0200, cem@kernel.org wrote:
> From: Carlos Maiolino <cem@kernel.org>
> 
> The new xfs_io fs properties subcommand, requires fsprops to be build,
> while libfrog conditionally build it according to the existence of
> libattr.
> 
> This causes builds to fail if the libattr headers are not available,
> without a clear output.
> 
> Now that xfs_io unconditionally requires libfrog/fsprops.c to be built,
> remove the condition from libfrog's Makefile.

That means we'll also need to make libattr mandatory in configure,
right?


  reply	other threads:[~2024-08-19 14:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-19 13:22 [PATCH] libfrog: Unconditionally build fsprops.c cem
2024-08-19 14:09 ` Christoph Hellwig [this message]
2024-08-19 15:12   ` Darrick J. Wong
2024-08-19 15:23     ` Christoph Hellwig
2024-08-19 15:57       ` Carlos Maiolino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZsNSHLekoGCThzaj@infradead.org \
    --to=hch@infradead.org \
    --cc=cem@kernel.org \
    --cc=djwong@kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox