Re: [PATCH 1/6] xfs: remove xfs_errortag_get

["Darrick J. Wong" <djwong@kernel.org>]

On Mon, Sep 15, 2025 at 06:30:37AM -0700, Christoph Hellwig wrote:
> xfs_errortag_get is only called by xfs_errortag_attr_show, which does not
> need to validate the error tag, because it can only be called on valid
> error tags that had a sysfs attribute registered.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Makes sense,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  fs/xfs/xfs_error.c | 16 ++--------------
>  fs/xfs/xfs_error.h |  1 -
>  2 files changed, 2 insertions(+), 15 deletions(-)
> 
> diff --git a/fs/xfs/xfs_error.c b/fs/xfs/xfs_error.c
> index dbd87e137694..45a43e47ce92 100644
> --- a/fs/xfs/xfs_error.c
> +++ b/fs/xfs/xfs_error.c
> @@ -118,10 +118,9 @@ xfs_errortag_attr_show(
>  	char			*buf)
>  {
>  	struct xfs_mount	*mp = to_mp(kobject);
> -	struct xfs_errortag_attr *xfs_attr = to_attr(attr);
> +	unsigned int		error_tag = to_attr(attr)->tag;
>  
> -	return snprintf(buf, PAGE_SIZE, "%u\n",
> -			xfs_errortag_get(mp, xfs_attr->tag));
> +	return snprintf(buf, PAGE_SIZE, "%u\n", mp->m_errortag[error_tag]);
>  }
>  
>  static const struct sysfs_ops xfs_errortag_sysfs_ops = {
> @@ -326,17 +325,6 @@ xfs_errortag_test(
>  	return true;
>  }
>  
> -int
> -xfs_errortag_get(
> -	struct xfs_mount	*mp,
> -	unsigned int		error_tag)
> -{
> -	if (!xfs_errortag_valid(error_tag))
> -		return -EINVAL;
> -
> -	return mp->m_errortag[error_tag];
> -}
> -
>  int
>  xfs_errortag_set(
>  	struct xfs_mount	*mp,
> diff --git a/fs/xfs/xfs_error.h b/fs/xfs/xfs_error.h
> index 0b9c5ba8a598..3aeb03001acf 100644
> --- a/fs/xfs/xfs_error.h
> +++ b/fs/xfs/xfs_error.h
> @@ -58,7 +58,6 @@ bool xfs_errortag_enabled(struct xfs_mount *mp, unsigned int tag);
>  		mdelay((mp)->m_errortag[(tag)]); \
>  	} while (0)
>  
> -extern int xfs_errortag_get(struct xfs_mount *mp, unsigned int error_tag);
>  extern int xfs_errortag_set(struct xfs_mount *mp, unsigned int error_tag,
>  		unsigned int tag_value);
>  extern int xfs_errortag_add(struct xfs_mount *mp, unsigned int error_tag);
> -- 
> 2.47.2
> 
>