Re: [PATCH 4/6] xfs: remove pointless externs in xfs_error.h

["Darrick J. Wong" <djwong@kernel.org>]

On Mon, Sep 15, 2025 at 06:30:40AM -0700, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  fs/xfs/xfs_error.h | 33 ++++++++++++++-------------------
>  1 file changed, 14 insertions(+), 19 deletions(-)
> 
> diff --git a/fs/xfs/xfs_error.h b/fs/xfs/xfs_error.h
> index 8429c1ee86e7..fe6a71bbe9cd 100644
> --- a/fs/xfs/xfs_error.h
> +++ b/fs/xfs/xfs_error.h
> @@ -8,22 +8,17 @@
>  
>  struct xfs_mount;
>  
> -extern void xfs_error_report(const char *tag, int level, struct xfs_mount *mp,
> -			const char *filename, int linenum,
> -			xfs_failaddr_t failaddr);
> -extern void xfs_corruption_error(const char *tag, int level,
> -			struct xfs_mount *mp, const void *buf, size_t bufsize,
> -			const char *filename, int linenum,
> -			xfs_failaddr_t failaddr);
> +void xfs_error_report(const char *tag, int level, struct xfs_mount *mp,
> +		const char *filename, int linenum, xfs_failaddr_t failaddr);
> +void xfs_corruption_error(const char *tag, int level, struct xfs_mount *mp,
> +		const void *buf, size_t bufsize, const char *filename,
> +		int linenum, xfs_failaddr_t failaddr);
>  void xfs_buf_corruption_error(struct xfs_buf *bp, xfs_failaddr_t fa);
> -extern void xfs_buf_verifier_error(struct xfs_buf *bp, int error,
> -			const char *name, const void *buf, size_t bufsz,
> -			xfs_failaddr_t failaddr);
> -extern void xfs_verifier_error(struct xfs_buf *bp, int error,
> -			xfs_failaddr_t failaddr);
> -extern void xfs_inode_verifier_error(struct xfs_inode *ip, int error,
> -			const char *name, const void *buf, size_t bufsz,
> -			xfs_failaddr_t failaddr);
> +void xfs_buf_verifier_error(struct xfs_buf *bp, int error, const char *name,
> +		const void *buf, size_t bufsz, xfs_failaddr_t failaddr);
> +void xfs_verifier_error(struct xfs_buf *bp, int error, xfs_failaddr_t failaddr);
> +void xfs_inode_verifier_error(struct xfs_inode *ip, int error, const char *name,
> +		const void *buf, size_t bufsz, xfs_failaddr_t failaddr);
>  
>  #define	XFS_ERROR_REPORT(e, lvl, mp)	\
>  	xfs_error_report(e, lvl, mp, __FILE__, __LINE__, __return_address)
> @@ -39,8 +34,8 @@ extern void xfs_inode_verifier_error(struct xfs_inode *ip, int error,
>  #define XFS_CORRUPTION_DUMP_LEN		(128)
>  
>  #ifdef DEBUG
> -extern int xfs_errortag_init(struct xfs_mount *mp);
> -extern void xfs_errortag_del(struct xfs_mount *mp);
> +int xfs_errortag_init(struct xfs_mount *mp);
> +void xfs_errortag_del(struct xfs_mount *mp);
>  bool xfs_errortag_test(struct xfs_mount *mp, const char *file, int line,
>  		unsigned int error_tag);
>  #define XFS_TEST_ERROR(mp, tag)		\
> @@ -58,8 +53,8 @@ bool xfs_errortag_enabled(struct xfs_mount *mp, unsigned int tag);
>  		mdelay((mp)->m_errortag[(tag)]); \
>  	} while (0)
>  
> -extern int xfs_errortag_add(struct xfs_mount *mp, unsigned int error_tag);
> -extern int xfs_errortag_clearall(struct xfs_mount *mp);
> +int xfs_errortag_add(struct xfs_mount *mp, unsigned int error_tag);
> +int xfs_errortag_clearall(struct xfs_mount *mp);
>  #else
>  #define xfs_errortag_init(mp)			(0)
>  #define xfs_errortag_del(mp)
> -- 
> 2.47.2
> 
>