* struct xfs_zone_scratch is undefined in 7.0-rc1
@ 2026-02-25 7:39 Wang Yugui
2026-02-25 9:01 ` Damien Le Moal
0 siblings, 1 reply; 4+ messages in thread
From: Wang Yugui @ 2026-02-25 7:39 UTC (permalink / raw)
To: linux-xfs
Hi,
struct xfs_zone_scratch is undefined in 7.0-rc1.
# grep xfs_zone_scratch -nr *
fs/xfs/xfs_zone_gc.c:99: struct xfs_zone_scratch *scratch;
#
Could we change 'struct xfs_zone_scratch *' to 'void *',
or just delete this var?
Best Regards
Wang Yugui (wangyugui@e16-tech.com)
2026/02/25
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: struct xfs_zone_scratch is undefined in 7.0-rc1
2026-02-25 7:39 struct xfs_zone_scratch is undefined in 7.0-rc1 Wang Yugui
@ 2026-02-25 9:01 ` Damien Le Moal
2026-02-25 14:08 ` Christoph Hellwig
0 siblings, 1 reply; 4+ messages in thread
From: Damien Le Moal @ 2026-02-25 9:01 UTC (permalink / raw)
To: Wang Yugui, linux-xfs
On 2/25/26 16:39, Wang Yugui wrote:
> Hi,
>
> struct xfs_zone_scratch is undefined in 7.0-rc1.
>
> # grep xfs_zone_scratch -nr *
> fs/xfs/xfs_zone_gc.c:99: struct xfs_zone_scratch *scratch;
> #
>
> Could we change 'struct xfs_zone_scratch *' to 'void *',
> or just delete this var?
This should do it:
diff --git a/fs/xfs/xfs_zone_gc.c b/fs/xfs/xfs_zone_gc.c
index 48c6cf584447..d78e29cdcc45 100644
--- a/fs/xfs/xfs_zone_gc.c
+++ b/fs/xfs/xfs_zone_gc.c
@@ -96,7 +96,6 @@ struct xfs_gc_bio {
*/
xfs_fsblock_t old_startblock;
xfs_daddr_t new_daddr;
- struct xfs_zone_scratch *scratch;
/* Are we writing to a sequential write required zone? */
bool is_seq;
@@ -779,7 +778,6 @@ xfs_zone_gc_split_write(
ihold(VFS_I(chunk->ip));
split_chunk->ip = chunk->ip;
split_chunk->is_seq = chunk->is_seq;
- split_chunk->scratch = chunk->scratch;
split_chunk->offset = chunk->offset;
split_chunk->len = split_len;
split_chunk->old_startblock = chunk->old_startblock;
--
Damien Le Moal
Western Digital Research
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: struct xfs_zone_scratch is undefined in 7.0-rc1
2026-02-25 9:01 ` Damien Le Moal
@ 2026-02-25 14:08 ` Christoph Hellwig
2026-02-25 23:29 ` Damien Le Moal
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2026-02-25 14:08 UTC (permalink / raw)
To: Damien Le Moal; +Cc: Wang Yugui, linux-xfs
On Wed, Feb 25, 2026 at 06:01:59PM +0900, Damien Le Moal wrote:
> On 2/25/26 16:39, Wang Yugui wrote:
> > Hi,
> >
> > struct xfs_zone_scratch is undefined in 7.0-rc1.
> >
> > # grep xfs_zone_scratch -nr *
> > fs/xfs/xfs_zone_gc.c:99: struct xfs_zone_scratch *scratch;
> > #
> >
> > Could we change 'struct xfs_zone_scratch *' to 'void *',
> > or just delete this var?
>
> This should do it:
Can you send a formal patch?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: struct xfs_zone_scratch is undefined in 7.0-rc1
2026-02-25 14:08 ` Christoph Hellwig
@ 2026-02-25 23:29 ` Damien Le Moal
0 siblings, 0 replies; 4+ messages in thread
From: Damien Le Moal @ 2026-02-25 23:29 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Wang Yugui, linux-xfs
On 2/25/26 23:08, Christoph Hellwig wrote:
> On Wed, Feb 25, 2026 at 06:01:59PM +0900, Damien Le Moal wrote:
>> On 2/25/26 16:39, Wang Yugui wrote:
>>> Hi,
>>>
>>> struct xfs_zone_scratch is undefined in 7.0-rc1.
>>>
>>> # grep xfs_zone_scratch -nr *
>>> fs/xfs/xfs_zone_gc.c:99: struct xfs_zone_scratch *scratch;
>>> #
>>>
>>> Could we change 'struct xfs_zone_scratch *' to 'void *',
>>> or just delete this var?
>>
>> This should do it:
>
> Can you send a formal patch?
Done.
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-02-25 23:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-25 7:39 struct xfs_zone_scratch is undefined in 7.0-rc1 Wang Yugui
2026-02-25 9:01 ` Damien Le Moal
2026-02-25 14:08 ` Christoph Hellwig
2026-02-25 23:29 ` Damien Le Moal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox