[PATCH] powerpc/p1010rdb:remove interrupts of ethernet-phy in device tree

[PATCH] powerpc/p1010rdb:remove interrupts of ethernet-phy in device tree

[Zhao Qiang]

Since P1010RDB-PA and P1010RDB-PB boards use different external PHY
interrupt signals.
And actually the PHY interrupt is not used effectively with
corresponding interrupt handler.
So we can remove the interrupts node without side-effect to comply
with both P1010RDB-PA and P1010RDB-PB.

Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
Signed-off-by: Zhao Qiang <B45475@freescale.com>
---
 arch/powerpc/boot/dts/p1010rdb.dtsi | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/powerpc/boot/dts/p1010rdb.dtsi b/arch/powerpc/boot/dts/p1010rdb.dtsi
index 7fc3402..2433ae4 100644
--- a/arch/powerpc/boot/dts/p1010rdb.dtsi
+++ b/arch/powerpc/boot/dts/p1010rdb.dtsi
@@ -199,17 +199,14 @@
 
 	mdio@24000 {
 		phy0: ethernet-phy@0 {
-			interrupts = <3 1 0 0>;
 			reg = <0x1>;
 		};
 
 		phy1: ethernet-phy@1 {
-			interrupts = <2 1 0 0>;
 			reg = <0x0>;
 		};
 
 		phy2: ethernet-phy@2 {
-			interrupts = <2 1 0 0>;
 			reg = <0x2>;
 		};
 
-- 
1.8.0

Re: [PATCH] powerpc/p1010rdb:remove interrupts of ethernet-phy in device tree

[Kumar Gala]

On Sep 10, 2013, at 10:49 PM, Zhao Qiang wrote:

> Since P1010RDB-PA and P1010RDB-PB boards use different external PHY
> interrupt signals.
> And actually the PHY interrupt is not used effectively with
> corresponding interrupt handler.
> So we can remove the interrupts node without side-effect to comply
> with both P1010RDB-PA and P1010RDB-PB.
>=20
> Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
> Signed-off-by: Zhao Qiang <B45475@freescale.com>
> ---
> arch/powerpc/boot/dts/p1010rdb.dtsi | 3 ---
> 1 file changed, 3 deletions(-)
>=20

NAK.  The device tree should represent the HW not what drivers decide to =
do with it.

If different board revs have different interrupt signals than create =
dts's to handle the 2 board revs.

- k

RE: [PATCH] powerpc/p1010rdb:remove interrupts of ethernet-phy in device tree

[Liu Shengzhou-B36685]

> -----Original Message-----
> From: Kumar Gala [mailto:galak@kernel.crashing.org]
> Sent: Wednesday, September 11, 2013 11:13 PM
> To: Zhao Qiang-B45475
> Cc: linuxppc-dev@lists.ozlabs.org; Liu Shengzhou-B36685
> Subject: Re: [PATCH] powerpc/p1010rdb:remove interrupts of ethernet-phy i=
n
> device tree
>=20
>=20
> On Sep 10, 2013, at 10:49 PM, Zhao Qiang wrote:
>=20
> > Since P1010RDB-PA and P1010RDB-PB boards use different external PHY
> > interrupt signals.
> > And actually the PHY interrupt is not used effectively with
> > corresponding interrupt handler.
> > So we can remove the interrupts node without side-effect to comply
> > with both P1010RDB-PA and P1010RDB-PB.
> >
> > Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
> > Signed-off-by: Zhao Qiang <B45475@freescale.com>
> > ---
> > arch/powerpc/boot/dts/p1010rdb.dtsi | 3 ---
> > 1 file changed, 3 deletions(-)
> >
>=20
> NAK.  The device tree should represent the HW not what drivers decide to =
do with
> it.
>=20
> If different board revs have different interrupt signals than create dts'=
s to
> handle the 2 board revs.
>=20
> - k
>=20
You mean we need to create p1010rdb-pa.dtsi and p1010rdb-pb.dtsi replacing =
current p1010rdb.dtsi just because of the unused phy interrupt?
and phy interrupt is not present in those dts of P3/P4/P5 platforms.
Actually currently many hardware are not present in dts, such as a lot of i=
2c devices, temperature monitor, etc.

-Shengzhou

Re: [PATCH] powerpc/p1010rdb:remove interrupts of ethernet-phy in device tree

[Kumar Gala]

On Sep 12, 2013, at 1:54 AM, Liu Shengzhou-B36685 wrote:

>=20
>=20
>> -----Original Message-----
>> From: Kumar Gala [mailto:galak@kernel.crashing.org]
>> Sent: Wednesday, September 11, 2013 11:13 PM
>> To: Zhao Qiang-B45475
>> Cc: linuxppc-dev@lists.ozlabs.org; Liu Shengzhou-B36685
>> Subject: Re: [PATCH] powerpc/p1010rdb:remove interrupts of =
ethernet-phy in
>> device tree
>>=20
>>=20
>> On Sep 10, 2013, at 10:49 PM, Zhao Qiang wrote:
>>=20
>>> Since P1010RDB-PA and P1010RDB-PB boards use different external PHY
>>> interrupt signals.
>>> And actually the PHY interrupt is not used effectively with
>>> corresponding interrupt handler.
>>> So we can remove the interrupts node without side-effect to comply
>>> with both P1010RDB-PA and P1010RDB-PB.
>>>=20
>>> Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
>>> Signed-off-by: Zhao Qiang <B45475@freescale.com>
>>> ---
>>> arch/powerpc/boot/dts/p1010rdb.dtsi | 3 ---
>>> 1 file changed, 3 deletions(-)
>>>=20
>>=20
>> NAK.  The device tree should represent the HW not what drivers decide =
to do with
>> it.
>>=20
>> If different board revs have different interrupt signals than create =
dts's to
>> handle the 2 board revs.
>>=20
>> - k
>>=20
> You mean we need to create p1010rdb-pa.dtsi and p1010rdb-pb.dtsi =
replacing current p1010rdb.dtsi just because of the unused phy =
interrupt?
> and phy interrupt is not present in those dts of P3/P4/P5 platforms.
> Actually currently many hardware are not present in dts, such as a lot =
of i2c devices, temperature monitor, etc.
>=20
> -Shengzhou
>=20

I'm saying of the board revs are different w/regards to how the PHY =
interrupt is wired, than create two .dts one for each of the board revs.

If the p3/p4/p5 platforms are missing the phy interrupt in the .dts than =
its an error.

Other devices like i2c, temp mon, etc should be added.  There is a =
difference between something not existing because people haven't gotten =
around to it / there isn't a binding vs a using the lack of information =
as a configuration mechanism.

- k

RE: [PATCH] powerpc/p1010rdb:remove interrupts of ethernet-phy in device tree

[Zhao Qiang-B45475]

Do you have any solutions?

-----Original Message-----
From: Kumar Gala [mailto:galak@kernel.crashing.org]=20
Sent: Friday, September 13, 2013 12:42 AM
To: Liu Shengzhou-B36685
Cc: Zhao Qiang-B45475; linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/p1010rdb:remove interrupts of ethernet-phy in =
device tree


On Sep 12, 2013, at 1:54 AM, Liu Shengzhou-B36685 wrote:

>=20
>=20
>> -----Original Message-----
>> From: Kumar Gala [mailto:galak@kernel.crashing.org]
>> Sent: Wednesday, September 11, 2013 11:13 PM
>> To: Zhao Qiang-B45475
>> Cc: linuxppc-dev@lists.ozlabs.org; Liu Shengzhou-B36685
>> Subject: Re: [PATCH] powerpc/p1010rdb:remove interrupts of=20
>> ethernet-phy in device tree
>>=20
>>=20
>> On Sep 10, 2013, at 10:49 PM, Zhao Qiang wrote:
>>=20
>>> Since P1010RDB-PA and P1010RDB-PB boards use different external PHY=20
>>> interrupt signals.
>>> And actually the PHY interrupt is not used effectively with=20
>>> corresponding interrupt handler.
>>> So we can remove the interrupts node without side-effect to comply=20
>>> with both P1010RDB-PA and P1010RDB-PB.
>>>=20
>>> Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
>>> Signed-off-by: Zhao Qiang <B45475@freescale.com>
>>> ---
>>> arch/powerpc/boot/dts/p1010rdb.dtsi | 3 ---
>>> 1 file changed, 3 deletions(-)
>>>=20
>>=20
>> NAK.  The device tree should represent the HW not what drivers decide=20
>> to do with it.
>>=20
>> If different board revs have different interrupt signals than create=20
>> dts's to handle the 2 board revs.
>>=20
>> - k
>>=20
> You mean we need to create p1010rdb-pa.dtsi and p1010rdb-pb.dtsi replacin=
g current p1010rdb.dtsi just because of the unused phy interrupt?
> and phy interrupt is not present in those dts of P3/P4/P5 platforms.
> Actually currently many hardware are not present in dts, such as a lot of=
 i2c devices, temperature monitor, etc.
>=20
> -Shengzhou
>=20

I'm saying of the board revs are different w/regards to how the PHY interru=
pt is wired, than create two .dts one for each of the board revs.

If the p3/p4/p5 platforms are missing the phy interrupt in the .dts than it=
s an error.

Other devices like i2c, temp mon, etc should be added.  There is a differen=
ce between something not existing because people haven't gotten around to i=
t / there isn't a binding vs a using the lack of information as a configura=
tion mechanism.

- k

RE: [PATCH] powerpc/p1010rdb:remove interrupts of ethernet-phy in device tree

[Zhao Qiang-B45475]

On Sep 13, 2013, at 12:42 AM, Kumar Gala wrote:

> -----Original Message-----
> From: Kumar Gala [mailto:galak@kernel.crashing.org]
> Sent: Friday, September 13, 2013 12:42 AM
> To: Liu Shengzhou-B36685
> Cc: Zhao Qiang-B45475; linuxppc-dev@lists.ozlabs.org
> Subject: Re: [PATCH] powerpc/p1010rdb:remove interrupts of ethernet-phy
> in device tree
>=20
>=20
> On Sep 12, 2013, at 1:54 AM, Liu Shengzhou-B36685 wrote:
>=20
> >
> >
> >> -----Original Message-----
> >> From: Kumar Gala [mailto:galak@kernel.crashing.org]
> >> Sent: Wednesday, September 11, 2013 11:13 PM
> >> To: Zhao Qiang-B45475
> >> Cc: linuxppc-dev@lists.ozlabs.org; Liu Shengzhou-B36685
> >> Subject: Re: [PATCH] powerpc/p1010rdb:remove interrupts of
> >> ethernet-phy in device tree
> >>
> >>
> >> On Sep 10, 2013, at 10:49 PM, Zhao Qiang wrote:
> >>
> >>
> >> NAK.  The device tree should represent the HW not what drivers decide
> >> to do with it.
> >>
> >> If different board revs have different interrupt signals than create
> >> dts's to handle the 2 board revs.
> >>
> >> - k
> >>
> > You mean we need to create p1010rdb-pa.dtsi and p1010rdb-pb.dtsi
> replacing current p1010rdb.dtsi just because of the unused phy interrupt?
> > and phy interrupt is not present in those dts of P3/P4/P5 platforms.
> > Actually currently many hardware are not present in dts, such as a lot
> of i2c devices, temperature monitor, etc.
> >
> > -Shengzhou
> >
>=20
> I'm saying of the board revs are different w/regards to how the PHY
> interrupt is wired, than create two .dts one for each of the board revs.
>=20
> If the p3/p4/p5 platforms are missing the phy interrupt in the .dts than
> its an error.
>=20
> Other devices like i2c, temp mon, etc should be added.  There is a
> difference between something not existing because people haven't gotten
> around to it / there isn't a binding vs a using the lack of information
> as a configuration mechanism.
>=20
> - k
>=20
>=20

Kumar, please advice your solution, thanks.

-zhaoqiang

Re: [PATCH] powerpc/p1010rdb:remove interrupts of ethernet-phy in device tree

[Scott Wood]

On Fri, 2013-09-13 at 03:17 +0000, Zhao Qiang-B45475 wrote:
> On Sep 13, 2013, at 12:42 AM, Kumar Gala wrote:
> 
> > -----Original Message-----
> > From: Kumar Gala [mailto:galak@kernel.crashing.org]
> > Sent: Friday, September 13, 2013 12:42 AM
> > To: Liu Shengzhou-B36685
> > Cc: Zhao Qiang-B45475; linuxppc-dev@lists.ozlabs.org
> > Subject: Re: [PATCH] powerpc/p1010rdb:remove interrupts of ethernet-phy
> > in device tree
> > 
> > 
> > On Sep 12, 2013, at 1:54 AM, Liu Shengzhou-B36685 wrote:
> > 
> > >
> > >
> > >> -----Original Message-----
> > >> From: Kumar Gala [mailto:galak@kernel.crashing.org]
> > >> Sent: Wednesday, September 11, 2013 11:13 PM
> > >> To: Zhao Qiang-B45475
> > >> Cc: linuxppc-dev@lists.ozlabs.org; Liu Shengzhou-B36685
> > >> Subject: Re: [PATCH] powerpc/p1010rdb:remove interrupts of
> > >> ethernet-phy in device tree
> > >>
> > >>
> > >> On Sep 10, 2013, at 10:49 PM, Zhao Qiang wrote:
> > >>
> > >>
> > >> NAK.  The device tree should represent the HW not what drivers decide
> > >> to do with it.
> > >>
> > >> If different board revs have different interrupt signals than create
> > >> dts's to handle the 2 board revs.
> > >>
> > >> - k
> > >>
> > > You mean we need to create p1010rdb-pa.dtsi and p1010rdb-pb.dtsi
> > replacing current p1010rdb.dtsi just because of the unused phy interrupt?
> > > and phy interrupt is not present in those dts of P3/P4/P5 platforms.
> > > Actually currently many hardware are not present in dts, such as a lot
> > of i2c devices, temperature monitor, etc.
> > >
> > > -Shengzhou
> > >
> > 
> > I'm saying of the board revs are different w/regards to how the PHY
> > interrupt is wired, than create two .dts one for each of the board revs.
> > 
> > If the p3/p4/p5 platforms are missing the phy interrupt in the .dts than
> > its an error.
> > 
> > Other devices like i2c, temp mon, etc should be added.  There is a
> > difference between something not existing because people haven't gotten
> > around to it / there isn't a binding vs a using the lack of information
> > as a configuration mechanism.
> > 
> > - k
> > 
> > 
> 
> Kumar, please advice your solution, thanks.

He already did -- have separate dts files.  This doesn't need to result
in massive duplication, because everything but the phy interrupt (and
any other differences there may be between revisions) can go into a
common dtsi file.

-Scott