[PATCH] devicetree/bindings/powerpc/fsl: Add binding for board

[PATCH] devicetree/bindings/powerpc/fsl: Add binding for board

[Priyanka Jain]

Signed-off-by: Priyanka Jain <Priyanka.Jain@freescale.com>
---
 .../devicetree/bindings/powerpc/fsl/board.txt      |   17 ++++++++++++++++-
 1 files changed, 16 insertions(+), 1 deletions(-)

diff --git a/Documentation/devicetree/bindings/powerpc/fsl/board.txt b/Documentation/devicetree/bindings/powerpc/fsl/board.txt
index f35f295..7800729 100644
--- a/Documentation/devicetree/bindings/powerpc/fsl/board.txt
+++ b/Documentation/devicetree/bindings/powerpc/fsl/board.txt
@@ -1,8 +1,23 @@
 Freescale Reference Board Bindings
 
-This document describes device tree bindings for various devices that
+This document describes device tree bindings for board and  various devices that
 exist on some Freescale reference boards.
 
+* Board node
+Required properties:
+
+ - model : Should be "fsl,<board>"
+ - compatible : Should be "fsl,<board>"
+	example: "fsl,T1040RDB", "fsl,T1042RDB", "fsl,T1042RDB_PI"
+		 "fsl,T1040QDS", "fsl,T1042QDS"
+
+Example:
+
+/ {
+	model = "fsl,T1040RDB";
+	compatible = "fsl,T1040RDB";
+};
+
 * Board Control and Status (BCSR)
 
 Required properties:
-- 
1.7.4.1

Re: [PATCH] devicetree/bindings/powerpc/fsl: Add binding for board

[Scott Wood]

On Mon, 2014-07-07 at 14:06 +0530, Priyanka Jain wrote:
> Signed-off-by: Priyanka Jain <Priyanka.Jain@freescale.com>
> ---
>  .../devicetree/bindings/powerpc/fsl/board.txt      |   17 ++++++++++++++++-
>  1 files changed, 16 insertions(+), 1 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/powerpc/fsl/board.txt b/Documentation/devicetree/bindings/powerpc/fsl/board.txt
> index f35f295..7800729 100644
> --- a/Documentation/devicetree/bindings/powerpc/fsl/board.txt
> +++ b/Documentation/devicetree/bindings/powerpc/fsl/board.txt
> @@ -1,8 +1,23 @@
>  Freescale Reference Board Bindings
>  
> -This document describes device tree bindings for various devices that
> +This document describes device tree bindings for board and  various devices that
>  exist on some Freescale reference boards.
>  
> +* Board node
> +Required properties:
> +
> + - model : Should be "fsl,<board>"
> + - compatible : Should be "fsl,<board>"
> +	example: "fsl,T1040RDB", "fsl,T1042RDB", "fsl,T1042RDB_PI"
> +		 "fsl,T1040QDS", "fsl,T1042QDS"
> +
> +Example:
> +
> +/ {
> +	model = "fsl,T1040RDB";
> +	compatible = "fsl,T1040RDB";
> +};

We really don't need to do this for every board just to satisfy
checkpatch.

-Scott

RE: [PATCH] devicetree/bindings/powerpc/fsl: Add binding for board

[Priyanka Jain]

DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV29vZCBTY290dC1CMDc0
MjENCj4gU2VudDogVHVlc2RheSwgSnVseSAwOCwgMjAxNCAzOjAwIEFNDQo+IFRvOiBKYWluIFBy
aXlhbmthLUIzMjE2Nw0KPiBDYzogZGV2aWNldHJlZUB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4cHBj
LWRldkBsaXN0cy5vemxhYnMub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0hdIGRldmljZXRyZWUv
YmluZGluZ3MvcG93ZXJwYy9mc2w6IEFkZCBiaW5kaW5nIGZvcg0KPiBib2FyZA0KPiANCj4gT24g
TW9uLCAyMDE0LTA3LTA3IGF0IDE0OjA2ICswNTMwLCBQcml5YW5rYSBKYWluIHdyb3RlOg0KPiA+
IFNpZ25lZC1vZmYtYnk6IFByaXlhbmthIEphaW4gPFByaXlhbmthLkphaW5AZnJlZXNjYWxlLmNv
bT4NCj4gPiAtLS0NCj4gPiAgLi4uL2RldmljZXRyZWUvYmluZGluZ3MvcG93ZXJwYy9mc2wvYm9h
cmQudHh0ICAgICAgfCAgIDE3DQo+ICsrKysrKysrKysrKysrKystDQo+ID4gIDEgZmlsZXMgY2hh
bmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkNCj4gPg0KPiA+IGRpZmYgLS1n
aXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcG93ZXJwYy9mc2wvYm9hcmQu
dHh0DQo+ID4gYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcG93ZXJwYy9mc2wv
Ym9hcmQudHh0DQo+ID4gaW5kZXggZjM1ZjI5NS4uNzgwMDcyOSAxMDA2NDQNCj4gPiAtLS0gYS9E
b2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcG93ZXJwYy9mc2wvYm9hcmQudHh0DQo+
ID4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3Bvd2VycGMvZnNsL2Jv
YXJkLnR4dA0KPiA+IEBAIC0xLDggKzEsMjMgQEANCj4gPiAgRnJlZXNjYWxlIFJlZmVyZW5jZSBC
b2FyZCBCaW5kaW5ncw0KPiA+DQo+ID4gLVRoaXMgZG9jdW1lbnQgZGVzY3JpYmVzIGRldmljZSB0
cmVlIGJpbmRpbmdzIGZvciB2YXJpb3VzIGRldmljZXMgdGhhdA0KPiA+ICtUaGlzIGRvY3VtZW50
IGRlc2NyaWJlcyBkZXZpY2UgdHJlZSBiaW5kaW5ncyBmb3IgYm9hcmQgYW5kICB2YXJpb3VzDQo+
ID4gK2RldmljZXMgdGhhdA0KPiA+ICBleGlzdCBvbiBzb21lIEZyZWVzY2FsZSByZWZlcmVuY2Ug
Ym9hcmRzLg0KPiA+DQo+ID4gKyogQm9hcmQgbm9kZQ0KPiA+ICtSZXF1aXJlZCBwcm9wZXJ0aWVz
Og0KPiA+ICsNCj4gPiArIC0gbW9kZWwgOiBTaG91bGQgYmUgImZzbCw8Ym9hcmQ+Ig0KPiA+ICsg
LSBjb21wYXRpYmxlIDogU2hvdWxkIGJlICJmc2wsPGJvYXJkPiINCj4gPiArCWV4YW1wbGU6ICJm
c2wsVDEwNDBSREIiLCAiZnNsLFQxMDQyUkRCIiwgImZzbCxUMTA0MlJEQl9QSSINCj4gPiArCQkg
ImZzbCxUMTA0MFFEUyIsICJmc2wsVDEwNDJRRFMiDQo+ID4gKw0KPiA+ICtFeGFtcGxlOg0KPiA+
ICsNCj4gPiArLyB7DQo+ID4gKwltb2RlbCA9ICJmc2wsVDEwNDBSREIiOw0KPiA+ICsJY29tcGF0
aWJsZSA9ICJmc2wsVDEwNDBSREIiOw0KPiA+ICt9Ow0KPiANCj4gV2UgcmVhbGx5IGRvbid0IG5l
ZWQgdG8gZG8gdGhpcyBmb3IgZXZlcnkgYm9hcmQganVzdCB0byBzYXRpc2Z5DQo+IGNoZWNrcGF0
Y2guDQo+IA0KPiAtU2NvdHQNCj4gDQpbSmFpbiBQcml5YW5rYS1CMzIxNjddIElzIGl0IE9LIHRv
IHN1Ym1pdCBhIHBhdGNoIHdpdGggYm9hcmQgY2hlY2twYXRjaCB3YXJuaW5nIGZvciB0aGlzIGNh
c2UgPw0K

Re: [PATCH] devicetree/bindings/powerpc/fsl: Add binding for board

[Scott Wood]

On Mon, 2014-07-07 at 22:56 -0500, Jain Priyanka-B32167 wrote:
> 
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Tuesday, July 08, 2014 3:00 AM
> > To: Jain Priyanka-B32167
> > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > Subject: Re: [PATCH] devicetree/bindings/powerpc/fsl: Add binding for
> > board
> > 
> > On Mon, 2014-07-07 at 14:06 +0530, Priyanka Jain wrote:
> > > Signed-off-by: Priyanka Jain <Priyanka.Jain@freescale.com>
> > > ---
> > >  .../devicetree/bindings/powerpc/fsl/board.txt      |   17
> > ++++++++++++++++-
> > >  1 files changed, 16 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/powerpc/fsl/board.txt
> > > b/Documentation/devicetree/bindings/powerpc/fsl/board.txt
> > > index f35f295..7800729 100644
> > > --- a/Documentation/devicetree/bindings/powerpc/fsl/board.txt
> > > +++ b/Documentation/devicetree/bindings/powerpc/fsl/board.txt
> > > @@ -1,8 +1,23 @@
> > >  Freescale Reference Board Bindings
> > >
> > > -This document describes device tree bindings for various devices that
> > > +This document describes device tree bindings for board and  various
> > > +devices that
> > >  exist on some Freescale reference boards.
> > >
> > > +* Board node
> > > +Required properties:
> > > +
> > > + - model : Should be "fsl,<board>"
> > > + - compatible : Should be "fsl,<board>"
> > > +	example: "fsl,T1040RDB", "fsl,T1042RDB", "fsl,T1042RDB_PI"
> > > +		 "fsl,T1040QDS", "fsl,T1042QDS"
> > > +
> > > +Example:
> > > +
> > > +/ {
> > > +	model = "fsl,T1040RDB";
> > > +	compatible = "fsl,T1040RDB";
> > > +};
> > 
> > We really don't need to do this for every board just to satisfy
> > checkpatch.
> > 
> > -Scott
> > 
> [Jain Priyanka-B32167] Is it OK to submit a patch with board checkpatch warning for this case ?

If you mean "is it OK to submit a board patch that has checkpatch
warnings of this sort, where the compatible follows a well established
pattern", then yes.

-Scott