From: Haren Myneni <haren@linux.ibm.com>
To: mpe@ellerman.id.au
Cc: mikey@neuling.org, herbert@gondor.apana.org.au,
npiggin@gmail.com, hch@infradead.org, oohall@gmail.com,
sukadev@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org,
ajd@linux.ibm.com
Subject: [PATCH v8 12/14] powerpc/vas: Return credits after handling fault
Date: Wed, 18 Mar 2020 23:19:15 -0700 [thread overview]
Message-ID: <1584598755.9256.15264.camel@hbabu-laptop> (raw)
In-Reply-To: <1584598120.9256.15237.camel@hbabu-laptop>
NX expects OS to return credit for send window after processing each
fault. Also credit has to be returned even for fault window.
Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Signed-off-by: Haren Myneni <haren@linux.ibm.com>
---
arch/powerpc/platforms/powernv/vas-fault.c | 9 +++++++++
arch/powerpc/platforms/powernv/vas-window.c | 17 +++++++++++++++++
arch/powerpc/platforms/powernv/vas.h | 1 +
3 files changed, 27 insertions(+)
diff --git a/arch/powerpc/platforms/powernv/vas-fault.c b/arch/powerpc/platforms/powernv/vas-fault.c
index 40e1de4..292f7ba 100644
--- a/arch/powerpc/platforms/powernv/vas-fault.c
+++ b/arch/powerpc/platforms/powernv/vas-fault.c
@@ -238,6 +238,10 @@ irqreturn_t vas_fault_thread_fn(int irq, void *data)
memcpy(crb, fifo, CRB_SIZE);
entry->stamp.nx.pswid = cpu_to_be32(FIFO_INVALID_ENTRY);
entry->ccw |= cpu_to_be32(CCW0_INVALID);
+ /*
+ * Return credit for the fault window.
+ */
+ vas_return_credit(vinst->fault_win, 0);
mutex_unlock(&vinst->mutex);
pr_devel("VAS[%d] fault_fifo %p, fifo %p, fault_crbs %d\n",
@@ -267,6 +271,11 @@ irqreturn_t vas_fault_thread_fn(int irq, void *data)
}
update_csb(window, crb);
+ /*
+ * Return credit for send window after processing
+ * fault CRB.
+ */
+ vas_return_credit(window, 1);
} while (true);
}
diff --git a/arch/powerpc/platforms/powernv/vas-window.c b/arch/powerpc/platforms/powernv/vas-window.c
index 6658ccc..20a2a8b 100644
--- a/arch/powerpc/platforms/powernv/vas-window.c
+++ b/arch/powerpc/platforms/powernv/vas-window.c
@@ -1318,6 +1318,23 @@ int vas_win_close(struct vas_window *window)
}
EXPORT_SYMBOL_GPL(vas_win_close);
+/*
+ * Return credit for the given window.
+ */
+void vas_return_credit(struct vas_window *window, bool tx)
+{
+ uint64_t val;
+
+ val = 0ULL;
+ if (tx) { /* send window */
+ val = SET_FIELD(VAS_TX_WCRED, val, 1);
+ write_hvwc_reg(window, VREG(TX_WCRED_ADDER), val);
+ } else {
+ val = SET_FIELD(VAS_LRX_WCRED, val, 1);
+ write_hvwc_reg(window, VREG(LRX_WCRED_ADDER), val);
+ }
+}
+
struct vas_window *vas_pswid_to_window(struct vas_instance *vinst,
uint32_t pswid)
{
diff --git a/arch/powerpc/platforms/powernv/vas.h b/arch/powerpc/platforms/powernv/vas.h
index bc728d7..8c39a7d 100644
--- a/arch/powerpc/platforms/powernv/vas.h
+++ b/arch/powerpc/platforms/powernv/vas.h
@@ -428,6 +428,7 @@ struct vas_winctx {
extern void vas_window_free_dbgdir(struct vas_window *win);
extern int vas_setup_fault_window(struct vas_instance *vinst);
extern irqreturn_t vas_fault_thread_fn(int irq, void *data);
+extern void vas_return_credit(struct vas_window *window, bool tx);
extern struct vas_window *vas_pswid_to_window(struct vas_instance *vinst,
uint32_t pswid);
--
1.8.3.1
next prev parent reply other threads:[~2020-03-19 6:35 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 6:08 [PATCH v8 00/14] powerpc/vas: Page fault handling for user space NX requests Haren Myneni
2020-03-19 6:12 ` [PATCH v8 01/14] powerpc/xive: Define xive_native_alloc_irq_on_chip() Haren Myneni
2020-03-23 0:20 ` Nicholas Piggin
2020-03-23 8:32 ` Cédric Le Goater
2020-03-24 13:48 ` Cédric Le Goater
2020-03-19 6:13 ` [PATCH v8 02/14] powerpc/xive: Define xive_native_alloc_get_irq_info() Haren Myneni
2020-03-23 8:52 ` Cédric Le Goater
2020-03-24 13:51 ` Cédric Le Goater
2020-03-19 6:13 ` [PATCH v8 03/14] powerpc/vas: Define nx_fault_stamp in coprocessor_request_block Haren Myneni
2020-03-23 0:30 ` Nicholas Piggin
2020-03-23 0:57 ` Haren Myneni
2020-03-23 1:30 ` Nicholas Piggin
2020-03-23 11:32 ` Michael Ellerman
2020-03-23 18:13 ` Haren Myneni
2020-03-25 10:44 ` Michael Ellerman
2020-03-19 6:14 ` [PATCH v8 04/14] powerpc/vas: Alloc and setup IRQ and trigger port address Haren Myneni
2020-03-23 1:06 ` Nicholas Piggin
2020-03-23 9:06 ` Cédric Le Goater
2020-03-23 9:27 ` Cédric Le Goater
2020-03-23 19:02 ` Haren Myneni
2020-03-24 12:20 ` Cédric Le Goater
2020-03-24 2:26 ` Oliver O'Halloran
2020-03-24 13:27 ` Cédric Le Goater
2020-03-24 14:48 ` Cédric Le Goater
2020-03-24 21:06 ` Haren Myneni
2020-03-19 6:15 ` [PATCH v8 05/14] powerpc/vas: Setup fault window per VAS instance Haren Myneni
2020-03-19 6:15 ` [PATCH v8 06/14] powerpc/vas: Setup thread IRQ handler " Haren Myneni
2020-03-23 2:23 ` Nicholas Piggin
2020-03-25 2:58 ` Haren Myneni
2020-03-19 6:16 ` [PATCH v8 07/14] powerpc/vas: Register NX with fault window ID and IRQ port value Haren Myneni
2020-03-19 6:16 ` [PATCH v8 08/14] powerpc/vas: Take reference to PID and mm for user space windows Haren Myneni
2020-03-23 2:34 ` Nicholas Piggin
2020-03-19 6:17 ` [PATCH v8 09/14] powerpc/vas: Update CSB and notify process for fault CRBs Haren Myneni
2020-03-23 2:37 ` Nicholas Piggin
2020-03-19 6:18 ` [PATCH v8 10/14] powerpc/vas: Print CRB and FIFO values Haren Myneni
2020-03-19 6:18 ` [PATCH v8 11/14] powerpc/vas: Do not use default credits for receive window Haren Myneni
2020-03-23 2:40 ` Nicholas Piggin
2020-03-25 3:04 ` Haren Myneni
2020-03-19 6:19 ` Haren Myneni [this message]
2020-03-23 2:44 ` [PATCH v8 12/14] powerpc/vas: Return credits after handling fault Nicholas Piggin
2020-03-25 3:35 ` Haren Myneni
2020-03-19 6:19 ` [PATCH v8 13/14] powerpc/vas: Display process stuck message Haren Myneni
2020-03-19 6:20 ` [PATCH v8 14/14] powerpc/vas: Free send window in VAS instance after credits returned Haren Myneni
2020-03-23 8:59 ` [PATCH v8 00/14] powerpc/vas: Page fault handling for user space NX requests Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1584598755.9256.15264.camel@hbabu-laptop \
--to=haren@linux.ibm.com \
--cc=ajd@linux.ibm.com \
--cc=hch@infradead.org \
--cc=herbert@gondor.apana.org.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=oohall@gmail.com \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox