From: Haren Myneni <haren@linux.ibm.com>
To: "Cédric Le Goater" <clg@kaod.org>
Cc: mikey@neuling.org, herbert@gondor.apana.org.au,
Frederic Barrat <frederic.barrat@fr.ibm.com>,
npiggin@gmail.com, hch@infradead.org, oohall@gmail.com,
sukadev@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org,
ajd@linux.ibm.com
Subject: Re: [PATCH v8 04/14] powerpc/vas: Alloc and setup IRQ and trigger port address
Date: Mon, 23 Mar 2020 12:02:15 -0700 [thread overview]
Message-ID: <1584990135.9256.15381.camel@hbabu-laptop> (raw)
In-Reply-To: <bd846a9c-0e21-1d97-0b03-e01c35ff01ae@kaod.org>
On Mon, 2020-03-23 at 10:27 +0100, Cédric Le Goater wrote:
> On 3/23/20 10:06 AM, Cédric Le Goater wrote:
> > On 3/19/20 7:14 AM, Haren Myneni wrote:
> >>
> >> Alloc IRQ and get trigger port address for each VAS instance. Kernel
> >> register this IRQ per VAS instance and sets this port for each send
> >> window. NX interrupts the kernel when it sees page fault.
> >
> > I don't understand why this is not done by the OPAL driver for each VAS
> > of the system. Is the VAS unit very different from OpenCAPI regarding
> > the fault ?
>
> I checked the previous patchsets and I see that v3 was more like I expected
> it: one interrupt for faults allocated by the skiboot driver and exposed
> in the DT.
>
> What made you change your mind ?
>
> This version is hijacking the lowlevel routines of the XIVE irqchip which
> is not the best approach. OCXL is doing that because it needs to allocate
> interrupts for the user space processes using the AFU and we should rework
> that part.
>
> However, the translation fault interrupt is allocated by skiboot.
Sorry my mistake. I should have CC you earlier.
Each VAS instance will generate fault interrupt which is per chip. There
won't be other job completion interrupts.
Correct, V3 used allocating interrupts per chip in skiboot and exposed
in DT. Since XIVE code has similar feature, exploited this approach so
that we do not need skiboot changes.
Thanks
Haren
>
> Sorry for the noise, I would like to understand more how this works. I also
> have passthrough in mind.
>
> C.
>
next prev parent reply other threads:[~2020-03-23 19:06 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 6:08 [PATCH v8 00/14] powerpc/vas: Page fault handling for user space NX requests Haren Myneni
2020-03-19 6:12 ` [PATCH v8 01/14] powerpc/xive: Define xive_native_alloc_irq_on_chip() Haren Myneni
2020-03-23 0:20 ` Nicholas Piggin
2020-03-23 8:32 ` Cédric Le Goater
2020-03-24 13:48 ` Cédric Le Goater
2020-03-19 6:13 ` [PATCH v8 02/14] powerpc/xive: Define xive_native_alloc_get_irq_info() Haren Myneni
2020-03-23 8:52 ` Cédric Le Goater
2020-03-24 13:51 ` Cédric Le Goater
2020-03-19 6:13 ` [PATCH v8 03/14] powerpc/vas: Define nx_fault_stamp in coprocessor_request_block Haren Myneni
2020-03-23 0:30 ` Nicholas Piggin
2020-03-23 0:57 ` Haren Myneni
2020-03-23 1:30 ` Nicholas Piggin
2020-03-23 11:32 ` Michael Ellerman
2020-03-23 18:13 ` Haren Myneni
2020-03-25 10:44 ` Michael Ellerman
2020-03-19 6:14 ` [PATCH v8 04/14] powerpc/vas: Alloc and setup IRQ and trigger port address Haren Myneni
2020-03-23 1:06 ` Nicholas Piggin
2020-03-23 9:06 ` Cédric Le Goater
2020-03-23 9:27 ` Cédric Le Goater
2020-03-23 19:02 ` Haren Myneni [this message]
2020-03-24 12:20 ` Cédric Le Goater
2020-03-24 2:26 ` Oliver O'Halloran
2020-03-24 13:27 ` Cédric Le Goater
2020-03-24 14:48 ` Cédric Le Goater
2020-03-24 21:06 ` Haren Myneni
2020-03-19 6:15 ` [PATCH v8 05/14] powerpc/vas: Setup fault window per VAS instance Haren Myneni
2020-03-19 6:15 ` [PATCH v8 06/14] powerpc/vas: Setup thread IRQ handler " Haren Myneni
2020-03-23 2:23 ` Nicholas Piggin
2020-03-25 2:58 ` Haren Myneni
2020-03-19 6:16 ` [PATCH v8 07/14] powerpc/vas: Register NX with fault window ID and IRQ port value Haren Myneni
2020-03-19 6:16 ` [PATCH v8 08/14] powerpc/vas: Take reference to PID and mm for user space windows Haren Myneni
2020-03-23 2:34 ` Nicholas Piggin
2020-03-19 6:17 ` [PATCH v8 09/14] powerpc/vas: Update CSB and notify process for fault CRBs Haren Myneni
2020-03-23 2:37 ` Nicholas Piggin
2020-03-19 6:18 ` [PATCH v8 10/14] powerpc/vas: Print CRB and FIFO values Haren Myneni
2020-03-19 6:18 ` [PATCH v8 11/14] powerpc/vas: Do not use default credits for receive window Haren Myneni
2020-03-23 2:40 ` Nicholas Piggin
2020-03-25 3:04 ` Haren Myneni
2020-03-19 6:19 ` [PATCH v8 12/14] powerpc/vas: Return credits after handling fault Haren Myneni
2020-03-23 2:44 ` Nicholas Piggin
2020-03-25 3:35 ` Haren Myneni
2020-03-19 6:19 ` [PATCH v8 13/14] powerpc/vas: Display process stuck message Haren Myneni
2020-03-19 6:20 ` [PATCH v8 14/14] powerpc/vas: Free send window in VAS instance after credits returned Haren Myneni
2020-03-23 8:59 ` [PATCH v8 00/14] powerpc/vas: Page fault handling for user space NX requests Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1584990135.9256.15381.camel@hbabu-laptop \
--to=haren@linux.ibm.com \
--cc=ajd@linux.ibm.com \
--cc=clg@kaod.org \
--cc=frederic.barrat@fr.ibm.com \
--cc=hch@infradead.org \
--cc=herbert@gondor.apana.org.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=npiggin@gmail.com \
--cc=oohall@gmail.com \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox