LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Haren Myneni <haren@linux.ibm.com>
To: mpe@ellerman.id.au
Cc: mikey@neuling.org, herbert@gondor.apana.org.au,
	npiggin@gmail.com, hch@infradead.org, oohall@gmail.com,
	sukadev@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org,
	ajd@linux.ibm.com
Subject: [PATCH v8 13/14] powerpc/vas: Display process stuck message
Date: Wed, 18 Mar 2020 23:19:42 -0700	[thread overview]
Message-ID: <1584598782.9256.15265.camel@hbabu-laptop> (raw)
In-Reply-To: <1584598120.9256.15237.camel@hbabu-laptop>


Process can not close send window until all requests are processed.
Means wait until window state is not busy and send credits are
returned. Display debug messages in case taking longer to close the
window.

Signed-off-by: Haren Myneni <haren@linux.ibm.com>
---
 arch/powerpc/platforms/powernv/vas-window.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/arch/powerpc/platforms/powernv/vas-window.c b/arch/powerpc/platforms/powernv/vas-window.c
index 20a2a8b..d5754a8 100644
--- a/arch/powerpc/platforms/powernv/vas-window.c
+++ b/arch/powerpc/platforms/powernv/vas-window.c
@@ -1182,6 +1182,7 @@ static void poll_window_credits(struct vas_window *window)
 {
 	u64 val;
 	int creds, mode;
+	int count = 0;
 
 	val = read_hvwc_reg(window, VREG(WINCTL));
 	if (window->tx_win)
@@ -1200,10 +1201,27 @@ static void poll_window_credits(struct vas_window *window)
 		creds = GET_FIELD(VAS_LRX_WCRED, val);
 	}
 
+	/*
+	 * Takes around few milliseconds to complete all pending requests
+	 * and return credits.
+	 * TODO: Scan fault FIFO and invalidate CRBs points to this window
+	 *       and issue CRB Kill to stop all pending requests. Need only
+	 *       if there is a bug in NX or fault handling in kernel.
+	 */
 	if (creds < window->wcreds_max) {
 		val = 0;
 		set_current_state(TASK_UNINTERRUPTIBLE);
 		schedule_timeout(msecs_to_jiffies(10));
+		count++;
+		/*
+		 * Process can not close send window until all credits are
+		 * returned.
+		 */
+		if (!(count % 10000))
+			pr_debug("VAS: pid %d stuck. Waiting for credits returned for Window(%d). creds %d, Retries %d\n",
+				vas_window_pid(window), window->winid,
+				creds, count);
+
 		goto retry;
 	}
 }
@@ -1217,6 +1235,7 @@ static void poll_window_busy_state(struct vas_window *window)
 {
 	int busy;
 	u64 val;
+	int count = 0;
 
 retry:
 	val = read_hvwc_reg(window, VREG(WIN_STATUS));
@@ -1225,6 +1244,15 @@ static void poll_window_busy_state(struct vas_window *window)
 		val = 0;
 		set_current_state(TASK_UNINTERRUPTIBLE);
 		schedule_timeout(msecs_to_jiffies(5));
+		count++;
+		/*
+		 * Takes around few milliseconds to process all pending
+		 * requests.
+		 */
+		if (!(count % 10000))
+			pr_debug("VAS: pid %d stuck. Window (ID=%d) is in busy state. Retries %d\n",
+				vas_window_pid(window), window->winid, count);
+
 		goto retry;
 	}
 }
-- 
1.8.3.1




  parent reply	other threads:[~2020-03-19  6:37 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-19  6:08 [PATCH v8 00/14] powerpc/vas: Page fault handling for user space NX requests Haren Myneni
2020-03-19  6:12 ` [PATCH v8 01/14] powerpc/xive: Define xive_native_alloc_irq_on_chip() Haren Myneni
2020-03-23  0:20   ` Nicholas Piggin
2020-03-23  8:32   ` Cédric Le Goater
2020-03-24 13:48   ` Cédric Le Goater
2020-03-19  6:13 ` [PATCH v8 02/14] powerpc/xive: Define xive_native_alloc_get_irq_info() Haren Myneni
2020-03-23  8:52   ` Cédric Le Goater
2020-03-24 13:51   ` Cédric Le Goater
2020-03-19  6:13 ` [PATCH v8 03/14] powerpc/vas: Define nx_fault_stamp in coprocessor_request_block Haren Myneni
2020-03-23  0:30   ` Nicholas Piggin
2020-03-23  0:57     ` Haren Myneni
2020-03-23  1:30       ` Nicholas Piggin
2020-03-23 11:32     ` Michael Ellerman
2020-03-23 18:13       ` Haren Myneni
2020-03-25 10:44         ` Michael Ellerman
2020-03-19  6:14 ` [PATCH v8 04/14] powerpc/vas: Alloc and setup IRQ and trigger port address Haren Myneni
2020-03-23  1:06   ` Nicholas Piggin
2020-03-23  9:06   ` Cédric Le Goater
2020-03-23  9:27     ` Cédric Le Goater
2020-03-23 19:02       ` Haren Myneni
2020-03-24 12:20         ` Cédric Le Goater
2020-03-24  2:26       ` Oliver O'Halloran
2020-03-24 13:27         ` Cédric Le Goater
2020-03-24 14:48   ` Cédric Le Goater
2020-03-24 21:06     ` Haren Myneni
2020-03-19  6:15 ` [PATCH v8 05/14] powerpc/vas: Setup fault window per VAS instance Haren Myneni
2020-03-19  6:15 ` [PATCH v8 06/14] powerpc/vas: Setup thread IRQ handler " Haren Myneni
2020-03-23  2:23   ` Nicholas Piggin
2020-03-25  2:58     ` Haren Myneni
2020-03-19  6:16 ` [PATCH v8 07/14] powerpc/vas: Register NX with fault window ID and IRQ port value Haren Myneni
2020-03-19  6:16 ` [PATCH v8 08/14] powerpc/vas: Take reference to PID and mm for user space windows Haren Myneni
2020-03-23  2:34   ` Nicholas Piggin
2020-03-19  6:17 ` [PATCH v8 09/14] powerpc/vas: Update CSB and notify process for fault CRBs Haren Myneni
2020-03-23  2:37   ` Nicholas Piggin
2020-03-19  6:18 ` [PATCH v8 10/14] powerpc/vas: Print CRB and FIFO values Haren Myneni
2020-03-19  6:18 ` [PATCH v8 11/14] powerpc/vas: Do not use default credits for receive window Haren Myneni
2020-03-23  2:40   ` Nicholas Piggin
2020-03-25  3:04     ` Haren Myneni
2020-03-19  6:19 ` [PATCH v8 12/14] powerpc/vas: Return credits after handling fault Haren Myneni
2020-03-23  2:44   ` Nicholas Piggin
2020-03-25  3:35     ` Haren Myneni
2020-03-19  6:19 ` Haren Myneni [this message]
2020-03-19  6:20 ` [PATCH v8 14/14] powerpc/vas: Free send window in VAS instance after credits returned Haren Myneni
2020-03-23  8:59 ` [PATCH v8 00/14] powerpc/vas: Page fault handling for user space NX requests Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1584598782.9256.15265.camel@hbabu-laptop \
    --to=haren@linux.ibm.com \
    --cc=ajd@linux.ibm.com \
    --cc=hch@infradead.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mikey@neuling.org \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=oohall@gmail.com \
    --cc=sukadev@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox