* [PATCH] ucc_geth_mii: fix __exit called from __init
@ 2007-07-20 8:19 Domen Puncer
0 siblings, 0 replies; only message in thread
From: Domen Puncer @ 2007-07-20 8:19 UTC (permalink / raw)
To: leoli; +Cc: netdev, linuxppc-embedded
void __exit uec_mdio_exit(void) is called from
- static int __init ucc_geth_init(void)
- static void __exit ucc_geth_exit(void)
First one would make error path more than just an error.
Signed-off-by: Domen Puncer <domen.puncer@telargo.com>
---
drivers/net/ucc_geth_mii.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: work-powerpc.git/drivers/net/ucc_geth_mii.c
===================================================================
--- work-powerpc.git.orig/drivers/net/ucc_geth_mii.c
+++ work-powerpc.git/drivers/net/ucc_geth_mii.c
@@ -272,7 +272,8 @@ int __init uec_mdio_init(void)
return of_register_platform_driver(&uec_mdio_driver);
}
-void __exit uec_mdio_exit(void)
+/* called from __init ucc_geth_init, therefore can not be __exit */
+void uec_mdio_exit(void)
{
of_unregister_platform_driver(&uec_mdio_driver);
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-07-20 8:19 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-20 8:19 [PATCH] ucc_geth_mii: fix __exit called from __init Domen Puncer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox