* [PATCH 2/2] backlight: Fix old-style function definition
@ 2017-12-26 14:12 Mathieu Malaterre
2018-01-03 10:18 ` Daniel Thompson
0 siblings, 1 reply; 2+ messages in thread
From: Mathieu Malaterre @ 2017-12-26 14:12 UTC (permalink / raw)
Cc: Mathieu Malaterre, Benjamin Herrenschmidt, linuxppc-dev,
linux-kernel
Fix warning:
drivers/macintosh/via-pmu-backlight.c: In function ‘pmu_backlight_init’:
drivers/macintosh/via-pmu-backlight.c:140:13: warning: old-style function definition [-Wold-style-definition]
void __init pmu_backlight_init()
^~~~~~~~~~~~~~~~~~
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
drivers/macintosh/via-pmu-backlight.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/macintosh/via-pmu-backlight.c b/drivers/macintosh/via-pmu-backlight.c
index 89ed51571b62..50ada02ae75d 100644
--- a/drivers/macintosh/via-pmu-backlight.c
+++ b/drivers/macintosh/via-pmu-backlight.c
@@ -137,7 +137,7 @@ void pmu_backlight_set_sleep(int sleep)
}
#endif /* CONFIG_PM */
-void __init pmu_backlight_init()
+void __init pmu_backlight_init(void)
{
struct backlight_properties props;
struct backlight_device *bd;
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 2/2] backlight: Fix old-style function definition
2017-12-26 14:12 [PATCH 2/2] backlight: Fix old-style function definition Mathieu Malaterre
@ 2018-01-03 10:18 ` Daniel Thompson
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Thompson @ 2018-01-03 10:18 UTC (permalink / raw)
To: Mathieu Malaterre; +Cc: no To-header on input <
On Tue, Dec 26, 2017 at 03:12:41PM +0100, Mathieu Malaterre wrote:
> Fix warning:
>
> drivers/macintosh/via-pmu-backlight.c: In function ‘pmu_backlight_init’:
> drivers/macintosh/via-pmu-backlight.c:140:13: warning: old-style function definition [-Wold-style-definition]
> void __init pmu_backlight_init()
> ^~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
> ---
> drivers/macintosh/via-pmu-backlight.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/macintosh/via-pmu-backlight.c b/drivers/macintosh/via-pmu-backlight.c
> index 89ed51571b62..50ada02ae75d 100644
> --- a/drivers/macintosh/via-pmu-backlight.c
> +++ b/drivers/macintosh/via-pmu-backlight.c
> @@ -137,7 +137,7 @@ void pmu_backlight_set_sleep(int sleep)
> }
> #endif /* CONFIG_PM */
>
> -void __init pmu_backlight_init()
> +void __init pmu_backlight_init(void)
> {
> struct backlight_properties props;
> struct backlight_device *bd;
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-03 10:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-26 14:12 [PATCH 2/2] backlight: Fix old-style function definition Mathieu Malaterre
2018-01-03 10:18 ` Daniel Thompson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox