* Re: [PATCH] misc: remove redundant 'default n' from Kconfig-s
2019-05-20 14:10 ` [PATCH] misc: remove redundant 'default n' from Kconfig-s Bartlomiej Zolnierkiewicz
@ 2019-05-20 17:55 ` Michał Mirosław
2019-05-21 11:49 ` Michael Ellerman
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Michał Mirosław @ 2019-05-20 17:55 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: Eric Piel, Andrew Donnellan, Arnd Bergmann, Greg Kroah-Hartman,
Frank Haverkamp, linux-kernel, Frederic Barrat, linuxppc-dev
On Mon, May 20, 2019 at 04:10:46PM +0200, Bartlomiej Zolnierkiewicz wrote:
> 'default n' is the default value for any bool or tristate Kconfig
> setting so there is no need to write it explicitly.
>
> Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO
> is not set' for visible symbols") the Kconfig behavior is the same
> regardless of 'default n' being present or not:
>
> ...
> One side effect of (and the main motivation for) this change is making
> the following two definitions behave exactly the same:
>
> config FOO
> bool
>
> config FOO
> bool
> default n
>
> With this change, neither of these will generate a
> '# CONFIG_FOO is not set' line (assuming FOO isn't selected/implied).
> That might make it clearer to people that a bare 'default n' is
> redundant.
> ...
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
[...]
> drivers/misc/cb710/Kconfig | 1 -
Acked-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] misc: remove redundant 'default n' from Kconfig-s
2019-05-20 14:10 ` [PATCH] misc: remove redundant 'default n' from Kconfig-s Bartlomiej Zolnierkiewicz
2019-05-20 17:55 ` Michał Mirosław
@ 2019-05-21 11:49 ` Michael Ellerman
2019-05-22 4:29 ` Frederic Barrat
2019-05-22 21:20 ` Arnd Bergmann
3 siblings, 0 replies; 5+ messages in thread
From: Michael Ellerman @ 2019-05-21 11:49 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz, Arnd Bergmann, Greg Kroah-Hartman
Cc: Eric Piel, Andrew Donnellan, Frank Haverkamp, linux-kernel,
Michał Mirosław, Frederic Barrat, linuxppc-dev
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> writes:
> 'default n' is the default value for any bool or tristate Kconfig
> setting so there is no need to write it explicitly.
>
> Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO
> is not set' for visible symbols") the Kconfig behavior is the same
> regardless of 'default n' being present or not:
>
> ...
> One side effect of (and the main motivation for) this change is making
> the following two definitions behave exactly the same:
>
> config FOO
> bool
>
> config FOO
> bool
> default n
>
> With this change, neither of these will generate a
> '# CONFIG_FOO is not set' line (assuming FOO isn't selected/implied).
> That might make it clearer to people that a bare 'default n' is
> redundant.
> ...
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
...
> Index: b/drivers/misc/ocxl/Kconfig
> ===================================================================
> --- a/drivers/misc/ocxl/Kconfig
> +++ b/drivers/misc/ocxl/Kconfig
> @@ -4,7 +4,6 @@
>
> config OCXL_BASE
> bool
> - default n
> select PPC_COPRO_BASE
>
> config OCXL
Acked-by: Michael Ellerman <mpe@ellerman.id.au> (ocxl)
cheers
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] misc: remove redundant 'default n' from Kconfig-s
2019-05-20 14:10 ` [PATCH] misc: remove redundant 'default n' from Kconfig-s Bartlomiej Zolnierkiewicz
2019-05-20 17:55 ` Michał Mirosław
2019-05-21 11:49 ` Michael Ellerman
@ 2019-05-22 4:29 ` Frederic Barrat
2019-05-22 21:20 ` Arnd Bergmann
3 siblings, 0 replies; 5+ messages in thread
From: Frederic Barrat @ 2019-05-22 4:29 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz, Arnd Bergmann, Greg Kroah-Hartman
Cc: Eric Piel, Andrew Donnellan, Frank Haverkamp, linux-kernel,
Michał Mirosław, linuxppc-dev
Le 20/05/2019 à 16:10, Bartlomiej Zolnierkiewicz a écrit :
> 'default n' is the default value for any bool or tristate Kconfig
> setting so there is no need to write it explicitly.
>
> Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO
> is not set' for visible symbols") the Kconfig behavior is the same
> regardless of 'default n' being present or not:
>
> ...
> One side effect of (and the main motivation for) this change is making
> the following two definitions behave exactly the same:
>
> config FOO
> bool
>
> config FOO
> bool
> default n
>
> With this change, neither of these will generate a
> '# CONFIG_FOO is not set' line (assuming FOO isn't selected/implied).
> That might make it clearer to people that a bare 'default n' is
> redundant.
> ...
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> ---
for cxl and ocxl:
Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>
> drivers/misc/Kconfig | 10 ----------
> drivers/misc/altera-stapl/Kconfig | 1 -
> drivers/misc/c2port/Kconfig | 2 --
> drivers/misc/cb710/Kconfig | 1 -
> drivers/misc/cxl/Kconfig | 3 ---
> drivers/misc/echo/Kconfig | 1 -
> drivers/misc/genwqe/Kconfig | 1 -
> drivers/misc/lis3lv02d/Kconfig | 2 --
> drivers/misc/ocxl/Kconfig | 1 -
> 9 files changed, 22 deletions(-)
>
> Index: b/drivers/misc/Kconfig
> ===================================================================
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -8,7 +8,6 @@ config SENSORS_LIS3LV02D
> tristate
> depends on INPUT
> select INPUT_POLLDEV
> - default n
>
> config AD525X_DPOT
> tristate "Analog Devices Digital Potentiometers"
> @@ -61,7 +60,6 @@ config ATMEL_TCLIB
>
> config DUMMY_IRQ
> tristate "Dummy IRQ handler"
> - default n
> ---help---
> This module accepts a single 'irq' parameter, which it should register for.
> The sole purpose of this module is to help with debugging of systems on
> @@ -117,7 +115,6 @@ config PHANTOM
> config INTEL_MID_PTI
> tristate "Parallel Trace Interface for MIPI P1149.7 cJTAG standard"
> depends on PCI && TTY && (X86_INTEL_MID || COMPILE_TEST)
> - default n
> help
> The PTI (Parallel Trace Interface) driver directs
> trace data routed from various parts in the system out
> @@ -193,7 +190,6 @@ config ATMEL_SSC
>
> config ENCLOSURE_SERVICES
> tristate "Enclosure Services"
> - default n
> help
> Provides support for intelligent enclosures (bays which
> contain storage devices). You also need either a host
> @@ -217,7 +213,6 @@ config SGI_XP
> config CS5535_MFGPT
> tristate "CS5535/CS5536 Geode Multi-Function General Purpose Timer (MFGPT) support"
> depends on MFD_CS5535
> - default n
> help
> This driver provides access to MFGPT functionality for other
> drivers that need timers. MFGPTs are available in the CS5535 and
> @@ -250,7 +245,6 @@ config CS5535_CLOCK_EVENT_SRC
> config HP_ILO
> tristate "Channel interface driver for the HP iLO processor"
> depends on PCI
> - default n
> help
> The channel interface driver allows applications to communicate
> with iLO management processors present on HP ProLiant servers.
> @@ -285,7 +279,6 @@ config QCOM_FASTRPC
> config SGI_GRU
> tristate "SGI GRU driver"
> depends on X86_UV && SMP
> - default n
> select MMU_NOTIFIER
> ---help---
> The GRU is a hardware resource located in the system chipset. The GRU
> @@ -300,7 +293,6 @@ config SGI_GRU
> config SGI_GRU_DEBUG
> bool "SGI GRU driver debug"
> depends on SGI_GRU
> - default n
> ---help---
> This option enables additional debugging code for the SGI GRU driver.
> If you are unsure, say N.
> @@ -358,7 +350,6 @@ config SENSORS_BH1770
> config SENSORS_APDS990X
> tristate "APDS990X combined als and proximity sensors"
> depends on I2C
> - default n
> ---help---
> Say Y here if you want to build a driver for Avago APDS990x
> combined ambient light and proximity sensor chip.
> @@ -386,7 +377,6 @@ config DS1682
> config SPEAR13XX_PCIE_GADGET
> bool "PCIe gadget support for SPEAr13XX platform"
> depends on ARCH_SPEAR13XX && BROKEN
> - default n
> help
> This option enables gadget support for PCIe controller. If
> board file defines any controller as PCIe endpoint then a sysfs
> Index: b/drivers/misc/altera-stapl/Kconfig
> ===================================================================
> --- a/drivers/misc/altera-stapl/Kconfig
> +++ b/drivers/misc/altera-stapl/Kconfig
> @@ -4,6 +4,5 @@ comment "Altera FPGA firmware download m
> config ALTERA_STAPL
> tristate "Altera FPGA firmware download module"
> depends on I2C
> - default n
> help
> An Altera FPGA module. Say Y when you want to support this tool.
> Index: b/drivers/misc/c2port/Kconfig
> ===================================================================
> --- a/drivers/misc/c2port/Kconfig
> +++ b/drivers/misc/c2port/Kconfig
> @@ -4,7 +4,6 @@
>
> menuconfig C2PORT
> tristate "Silicon Labs C2 port support"
> - default n
> help
> This option enables support for Silicon Labs C2 port used to
> program Silicon micro controller chips (and other 8051 compatible).
> @@ -23,7 +22,6 @@ if C2PORT
> config C2PORT_DURAMAR_2150
> tristate "C2 port support for Eurotech's Duramar 2150"
> depends on X86
> - default n
> help
> This option enables C2 support for the Eurotech's Duramar 2150
> on board micro controller.
> Index: b/drivers/misc/cb710/Kconfig
> ===================================================================
> --- a/drivers/misc/cb710/Kconfig
> +++ b/drivers/misc/cb710/Kconfig
> @@ -14,7 +14,6 @@ config CB710_CORE
> config CB710_DEBUG
> bool "Enable driver debugging"
> depends on CB710_CORE != n
> - default n
> help
> This is an option for use by developers; most people should
> say N here. This adds a lot of debugging output to dmesg.
> Index: b/drivers/misc/cxl/Kconfig
> ===================================================================
> --- a/drivers/misc/cxl/Kconfig
> +++ b/drivers/misc/cxl/Kconfig
> @@ -4,16 +4,13 @@
>
> config CXL_BASE
> bool
> - default n
> select PPC_COPRO_BASE
>
> config CXL_AFU_DRIVER_OPS
> bool
> - default n
>
> config CXL_LIB
> bool
> - default n
>
> config CXL
> tristate "Support for IBM Coherent Accelerators (CXL)"
> Index: b/drivers/misc/echo/Kconfig
> ===================================================================
> --- a/drivers/misc/echo/Kconfig
> +++ b/drivers/misc/echo/Kconfig
> @@ -1,6 +1,5 @@
> config ECHO
> tristate "Line Echo Canceller support"
> - default n
> ---help---
> This driver provides line echo cancelling support for mISDN and
> Zaptel drivers.
> Index: b/drivers/misc/genwqe/Kconfig
> ===================================================================
> --- a/drivers/misc/genwqe/Kconfig
> +++ b/drivers/misc/genwqe/Kconfig
> @@ -6,7 +6,6 @@ menuconfig GENWQE
> tristate "GenWQE PCIe Accelerator"
> depends on PCI && 64BIT
> select CRC_ITU_T
> - default n
> help
> Enables PCIe card driver for IBM GenWQE accelerators.
> The user-space interface is described in
> Index: b/drivers/misc/lis3lv02d/Kconfig
> ===================================================================
> --- a/drivers/misc/lis3lv02d/Kconfig
> +++ b/drivers/misc/lis3lv02d/Kconfig
> @@ -6,7 +6,6 @@ config SENSORS_LIS3_SPI
> tristate "STMicroeletronics LIS3LV02Dx three-axis digital accelerometer (SPI)"
> depends on !ACPI && SPI_MASTER && INPUT
> select SENSORS_LIS3LV02D
> - default n
> help
> This driver provides support for the LIS3LV02Dx accelerometer connected
> via SPI. The accelerometer data is readable via
> @@ -23,7 +22,6 @@ config SENSORS_LIS3_I2C
> tristate "STMicroeletronics LIS3LV02Dx three-axis digital accelerometer (I2C)"
> depends on I2C && INPUT
> select SENSORS_LIS3LV02D
> - default n
> help
> This driver provides support for the LIS3LV02Dx accelerometer connected
> via I2C. The accelerometer data is readable via
> Index: b/drivers/misc/ocxl/Kconfig
> ===================================================================
> --- a/drivers/misc/ocxl/Kconfig
> +++ b/drivers/misc/ocxl/Kconfig
> @@ -4,7 +4,6 @@
>
> config OCXL_BASE
> bool
> - default n
> select PPC_COPRO_BASE
>
> config OCXL
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] misc: remove redundant 'default n' from Kconfig-s
2019-05-20 14:10 ` [PATCH] misc: remove redundant 'default n' from Kconfig-s Bartlomiej Zolnierkiewicz
` (2 preceding siblings ...)
2019-05-22 4:29 ` Frederic Barrat
@ 2019-05-22 21:20 ` Arnd Bergmann
3 siblings, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2019-05-22 21:20 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: Eric Piel, Andrew Donnellan, Greg Kroah-Hartman, Frank Haverkamp,
Linux Kernel Mailing List, Michał Mirosław,
Frederic Barrat, linuxppc-dev
On Mon, May 20, 2019 at 4:10 PM Bartlomiej Zolnierkiewicz
<b.zolnierkie@samsung.com> wrote:
>
> 'default n' is the default value for any bool or tristate Kconfig
> setting so there is no need to write it explicitly.
>
> Also since commit f467c5640c29 ("kconfig: only write '# CONFIG_FOO
> is not set' for visible symbols") the Kconfig behavior is the same
> regardless of 'default n' being present or not:
>
> ...
> One side effect of (and the main motivation for) this change is making
> the following two definitions behave exactly the same:
>
> config FOO
> bool
>
> config FOO
> bool
> default n
>
> With this change, neither of these will generate a
> '# CONFIG_FOO is not set' line (assuming FOO isn't selected/implied).
> That might make it clearer to people that a bare 'default n' is
> redundant.
> ...
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 5+ messages in thread