[PATCH] powerpc/ps3: Remove unused struct table in setup_areas()

[PATCH] powerpc/ps3: Remove unused struct table in setup_areas()

[Thorsten Blum]

The local table structure is not used - remove it.

Remove % in the comment while at it.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 arch/powerpc/platforms/ps3/spu.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/powerpc/platforms/ps3/spu.c b/arch/powerpc/platforms/ps3/spu.c
index e817def7f424..c904f9fa1caa 100644
--- a/arch/powerpc/platforms/ps3/spu.c
+++ b/arch/powerpc/platforms/ps3/spu.c
@@ -185,13 +185,11 @@ static void spu_unmap(struct spu *spu)
  * The current HV requires the spu shadow regs to be mapped with the
  * PTE page protection bits set as read-only.
  *
- * Returns: %0 on success or -errno on error.
+ * Returns: 0 on success or -errno on error.
  */
 
 static int __init setup_areas(struct spu *spu)
 {
-	struct table {char* name; unsigned long addr; unsigned long size;};
-
 	spu_pdata(spu)->shadow = ioremap_prot(spu_pdata(spu)->shadow_addr,
 					      sizeof(struct spe_shadow),
 					      pgprot_noncached_wc(PAGE_KERNEL_RO));

Re: [PATCH] powerpc/ps3: Remove unused struct table in setup_areas()

[Geert Uytterhoeven]

On Sun, 12 Jul 2026 at 17:13, Thorsten Blum <thorsten.blum@linux.dev> wrote:
> The local table structure is not used - remove it.
>
> Remove % in the comment while at it.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] powerpc/ps3: Remove unused struct table in setup_areas()

[Amit Machhiwal]

On 2026/07/12 05:13 PM, Thorsten Blum wrote:
> The local table structure is not used - remove it.
> 
> Remove % in the comment while at it.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
>  arch/powerpc/platforms/ps3/spu.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/arch/powerpc/platforms/ps3/spu.c b/arch/powerpc/platforms/ps3/spu.c
> index e817def7f424..c904f9fa1caa 100644
> --- a/arch/powerpc/platforms/ps3/spu.c
> +++ b/arch/powerpc/platforms/ps3/spu.c
> @@ -185,13 +185,11 @@ static void spu_unmap(struct spu *spu)
>   * The current HV requires the spu shadow regs to be mapped with the
>   * PTE page protection bits set as read-only.
>   *
> - * Returns: %0 on success or -errno on error.
> + * Returns: 0 on success or -errno on error.

The % prefix should actually be kept here I think. Per the kernel-doc
documentation [1]:

  %CONST
  Name of a constant. (No cross-referencing, just formatting.)
  
  Examples:
  
  %0    %NULL    %-1    %-EFAULT    %-EINVAL    %-ENOMEM

So %0 is valid and intentional kernel-doc markup that renders the
constant 0 with proper formatting.

The struct removal part looks good though.

[1]: https://docs.kernel.org/doc-guide/kernel-doc.html#highlights-and-cross-references

~Amit

>   */
>  
>  static int __init setup_areas(struct spu *spu)
>  {
> -	struct table {char* name; unsigned long addr; unsigned long size;};
> -
>  	spu_pdata(spu)->shadow = ioremap_prot(spu_pdata(spu)->shadow_addr,
>  					      sizeof(struct spe_shadow),
>  					      pgprot_noncached_wc(PAGE_KERNEL_RO));

Re: [PATCH] powerpc/ps3: Remove unused struct table in setup_areas()

[Thorsten Blum]

On Mon, Jul 13, 2026 at 01:59:02PM +0530, Amit Machhiwal wrote:
> On 2026/07/12 05:13 PM, Thorsten Blum wrote:
> > The local table structure is not used - remove it.
> > 
> > Remove % in the comment while at it.
> > 
> > Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> > ---
> >  arch/powerpc/platforms/ps3/spu.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/arch/powerpc/platforms/ps3/spu.c b/arch/powerpc/platforms/ps3/spu.c
> > index e817def7f424..c904f9fa1caa 100644
> > --- a/arch/powerpc/platforms/ps3/spu.c
> > +++ b/arch/powerpc/platforms/ps3/spu.c
> > @@ -185,13 +185,11 @@ static void spu_unmap(struct spu *spu)
> >   * The current HV requires the spu shadow regs to be mapped with the
> >   * PTE page protection bits set as read-only.
> >   *
> > - * Returns: %0 on success or -errno on error.
> > + * Returns: 0 on success or -errno on error.
> 
> The % prefix should actually be kept here I think. Per the kernel-doc
> documentation [1]:
> 
>   %CONST
>   Name of a constant. (No cross-referencing, just formatting.)
>   
>   Examples:
>   
>   %0    %NULL    %-1    %-EFAULT    %-EINVAL    %-ENOMEM
> 
> So %0 is valid and intentional kernel-doc markup that renders the
> constant 0 with proper formatting.

Interesting - not sure I have seen this style before and plain 0 seems
to be far more common. There has been some discussion around it here:
https://lore.kernel.org/all/87ilamz4j5.fsf@meer.lwn.net/

I guess I'll send a v2 without the %0 change.

Thanks,
Thorsten

Re: [PATCH] powerpc/ps3: Remove unused struct table in setup_areas()

[Christophe Leroy (CS GROUP)]

Le 12/07/2026 à 17:13, Thorsten Blum a écrit :
> The local table structure is not used - remove it.
> 
> Remove % in the comment while at it.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>

Looks like it's never been used since commit de91a5342995 ("[POWERPC] 
ps3: add spu support") that introduced it.


Reviewed-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>

I have no opinion about the %0 versus 0, is it worth the change ?


> ---
>   arch/powerpc/platforms/ps3/spu.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/arch/powerpc/platforms/ps3/spu.c b/arch/powerpc/platforms/ps3/spu.c
> index e817def7f424..c904f9fa1caa 100644
> --- a/arch/powerpc/platforms/ps3/spu.c
> +++ b/arch/powerpc/platforms/ps3/spu.c
> @@ -185,13 +185,11 @@ static void spu_unmap(struct spu *spu)
>    * The current HV requires the spu shadow regs to be mapped with the
>    * PTE page protection bits set as read-only.
>    *
> - * Returns: %0 on success or -errno on error.
> + * Returns: 0 on success or -errno on error.
>    */
>   
>   static int __init setup_areas(struct spu *spu)
>   {
> -	struct table {char* name; unsigned long addr; unsigned long size;};
> -
>   	spu_pdata(spu)->shadow = ioremap_prot(spu_pdata(spu)->shadow_addr,
>   					      sizeof(struct spe_shadow),
>   					      pgprot_noncached_wc(PAGE_KERNEL_RO));

Re: [PATCH] powerpc/ps3: Remove unused struct table in setup_areas()

[Madhavan Srinivasan]

On 7/27/26 6:47 PM, Christophe Leroy (CS GROUP) wrote:
>
>
> Le 12/07/2026 à 17:13, Thorsten Blum a écrit :
>> The local table structure is not used - remove it.
>>
>> Remove % in the comment while at it.
>>
>> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
>
> Looks like it's never been used since commit de91a5342995 ("[POWERPC] 
> ps3: add spu support") that introduced it.
>
>
> Reviewed-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>
>
> I have no opinion about the %0 versus 0, is it worth the change ?
FYI.. I have added this patch as-is to my fixes-test
not waiting for v2
Maddy
>
>
>> ---
>>   arch/powerpc/platforms/ps3/spu.c | 4 +---
>>   1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/arch/powerpc/platforms/ps3/spu.c 
>> b/arch/powerpc/platforms/ps3/spu.c
>> index e817def7f424..c904f9fa1caa 100644
>> --- a/arch/powerpc/platforms/ps3/spu.c
>> +++ b/arch/powerpc/platforms/ps3/spu.c
>> @@ -185,13 +185,11 @@ static void spu_unmap(struct spu *spu)
>>    * The current HV requires the spu shadow regs to be mapped with the
>>    * PTE page protection bits set as read-only.
>>    *
>> - * Returns: %0 on success or -errno on error.
>> + * Returns: 0 on success or -errno on error.
>>    */
>>     static int __init setup_areas(struct spu *spu)
>>   {
>> -    struct table {char* name; unsigned long addr; unsigned long size;};
>> -
>>       spu_pdata(spu)->shadow = ioremap_prot(spu_pdata(spu)->shadow_addr,
>>                             sizeof(struct spe_shadow),
>> pgprot_noncached_wc(PAGE_KERNEL_RO));
>

Re: [PATCH] powerpc/ps3: Remove unused struct table in setup_areas()

[Amit Machhiwal]

On 2026/07/28 11:32 AM, Madhavan Srinivasan wrote:
> 
> On 7/27/26 6:47 PM, Christophe Leroy (CS GROUP) wrote:
> > 
> > 
> > Le 12/07/2026 à 17:13, Thorsten Blum a écrit :
> > > The local table structure is not used - remove it.
> > > 
> > > Remove % in the comment while at it.
> > > 
> > > Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> > 
> > Looks like it's never been used since commit de91a5342995 ("[POWERPC]
> > ps3: add spu support") that introduced it.
> > 
> > 
> > Reviewed-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>
> > 
> > I have no opinion about the %0 versus 0, is it worth the change ?
> FYI.. I have added this patch as-is to my fixes-test
> not waiting for v2

The v2 was already sent Maddy.

  https://lore.kernel.org/all/20260713091731.97212-3-thorsten.blum@linux.dev/

Thanks,
Amit

> Maddy
> > 
> > 
> > > ---
> > >   arch/powerpc/platforms/ps3/spu.c | 4 +---
> > >   1 file changed, 1 insertion(+), 3 deletions(-)
> > > 
> > > diff --git a/arch/powerpc/platforms/ps3/spu.c
> > > b/arch/powerpc/platforms/ps3/spu.c
> > > index e817def7f424..c904f9fa1caa 100644
> > > --- a/arch/powerpc/platforms/ps3/spu.c
> > > +++ b/arch/powerpc/platforms/ps3/spu.c
> > > @@ -185,13 +185,11 @@ static void spu_unmap(struct spu *spu)
> > >    * The current HV requires the spu shadow regs to be mapped with the
> > >    * PTE page protection bits set as read-only.
> > >    *
> > > - * Returns: %0 on success or -errno on error.
> > > + * Returns: 0 on success or -errno on error.
> > >    */
> > >     static int __init setup_areas(struct spu *spu)
> > >   {
> > > -    struct table {char* name; unsigned long addr; unsigned long size;};
> > > -
> > >       spu_pdata(spu)->shadow = ioremap_prot(spu_pdata(spu)->shadow_addr,
> > >                             sizeof(struct spe_shadow),
> > > pgprot_noncached_wc(PAGE_KERNEL_RO));
> > 
> 

Re: [PATCH] powerpc/ps3: Remove unused struct table in setup_areas()

[Madhavan Srinivasan]

On 7/28/26 3:14 PM, Amit Machhiwal wrote:
> On 2026/07/28 11:32 AM, Madhavan Srinivasan wrote:
>> On 7/27/26 6:47 PM, Christophe Leroy (CS GROUP) wrote:
>>>
>>> Le 12/07/2026 à 17:13, Thorsten Blum a écrit :
>>>> The local table structure is not used - remove it.
>>>>
>>>> Remove % in the comment while at it.
>>>>
>>>> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
>>> Looks like it's never been used since commit de91a5342995 ("[POWERPC]
>>> ps3: add spu support") that introduced it.
>>>
>>>
>>> Reviewed-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>
>>>
>>> I have no opinion about the %0 versus 0, is it worth the change ?
>> FYI.. I have added this patch as-is to my fixes-test
>> not waiting for v2
> The v2 was already sent Maddy.
>
>    https://lore.kernel.org/all/20260713091731.97212-3-thorsten.blum@linux.dev/
yes I have picked up the v2. My bad, sorry for the noise
Maddy
> Thanks,
> Amit
>
>> Maddy
>>>
>>>> ---
>>>>    arch/powerpc/platforms/ps3/spu.c | 4 +---
>>>>    1 file changed, 1 insertion(+), 3 deletions(-)
>>>>
>>>> diff --git a/arch/powerpc/platforms/ps3/spu.c
>>>> b/arch/powerpc/platforms/ps3/spu.c
>>>> index e817def7f424..c904f9fa1caa 100644
>>>> --- a/arch/powerpc/platforms/ps3/spu.c
>>>> +++ b/arch/powerpc/platforms/ps3/spu.c
>>>> @@ -185,13 +185,11 @@ static void spu_unmap(struct spu *spu)
>>>>     * The current HV requires the spu shadow regs to be mapped with the
>>>>     * PTE page protection bits set as read-only.
>>>>     *
>>>> - * Returns: %0 on success or -errno on error.
>>>> + * Returns: 0 on success or -errno on error.
>>>>     */
>>>>      static int __init setup_areas(struct spu *spu)
>>>>    {
>>>> -    struct table {char* name; unsigned long addr; unsigned long size;};
>>>> -
>>>>        spu_pdata(spu)->shadow = ioremap_prot(spu_pdata(spu)->shadow_addr,
>>>>                              sizeof(struct spe_shadow),
>>>> pgprot_noncached_wc(PAGE_KERNEL_RO));