* [PATCH] powerpc/pseries: Use correct event modifier in rtas_parse_epow_errlog()
@ 2019-04-23 14:35 Yue Haibing
2019-04-24 1:29 ` Russell Currey
2019-04-24 2:17 ` [PATCH v2] " Yue Haibing
0 siblings, 2 replies; 6+ messages in thread
From: Yue Haibing @ 2019-04-23 14:35 UTC (permalink / raw)
To: benh, paulus, mpe, mahesh, npiggin, ganeshgr, anton
Cc: YueHaibing, linuxppc-dev, linux-kernel
From: YueHaibing <yuehaibing@huawei.com>
rtas_parse_epow_errlog() should pass 'modifier' to
handle_system_shutdown, because event modifier only use
bottom 4 bits.
Fixes: 55fc0c561742 ("powerpc/pseries: Parse and handle EPOW interrupts")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
arch/powerpc/platforms/pseries/ras.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/pseries/ras.c b/arch/powerpc/platforms/pseries/ras.c
index c97d153..744604d 100644
--- a/arch/powerpc/platforms/pseries/ras.c
+++ b/arch/powerpc/platforms/pseries/ras.c
@@ -285,7 +285,7 @@ static void rtas_parse_epow_errlog(struct rtas_error_log *log)
break;
case EPOW_SYSTEM_SHUTDOWN:
- handle_system_shutdown(epow_log->event_modifier);
+ handle_system_shutdown(event_modifier);
break;
case EPOW_SYSTEM_HALT:
--
2.7.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] powerpc/pseries: Use correct event modifier in rtas_parse_epow_errlog()
2019-04-23 14:35 [PATCH] powerpc/pseries: Use correct event modifier in rtas_parse_epow_errlog() Yue Haibing
@ 2019-04-24 1:29 ` Russell Currey
2019-04-24 1:48 ` YueHaibing
2019-04-24 2:17 ` [PATCH v2] " Yue Haibing
1 sibling, 1 reply; 6+ messages in thread
From: Russell Currey @ 2019-04-24 1:29 UTC (permalink / raw)
To: Yue Haibing, paulus, mpe, mahesh, npiggin, ganeshgr, anton
Cc: linuxppc-dev, linux-kernel
On Tue, 2019-04-23 at 22:35 +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> rtas_parse_epow_errlog() should pass 'modifier' to
> handle_system_shutdown, because event modifier only use
> bottom 4 bits.
>
> Fixes: 55fc0c561742 ("powerpc/pseries: Parse and handle EPOW
> interrupts")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Hello,
This fails to compile.
arch/powerpc/platforms/pseries/ras.c: In function
'rtas_parse_epow_errlog':
arch/powerpc/platforms/pseries/ras.c:288:26: error: 'event_modifier'
undeclared (first use in this function); did you mean 'modifier'?
handle_system_shutdown(event_modifier);
^~~~~~~~~~~~~~
modifier
So yes, I assume you meant "modifier" instead of "event_modifier" as
mentioned in your commit message. Did you compile this before sending?
(found by snowpatch)
- Russell
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] powerpc/pseries: Use correct event modifier in rtas_parse_epow_errlog()
2019-04-24 1:29 ` Russell Currey
@ 2019-04-24 1:48 ` YueHaibing
0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2019-04-24 1:48 UTC (permalink / raw)
To: Russell Currey, paulus, mpe, mahesh, npiggin, ganeshgr, anton
Cc: linuxppc-dev, linux-kernel
On 2019/4/24 9:29, Russell Currey wrote:
> On Tue, 2019-04-23 at 22:35 +0800, Yue Haibing wrote:
>> From: YueHaibing <yuehaibing@huawei.com>
>>
>> rtas_parse_epow_errlog() should pass 'modifier' to
>> handle_system_shutdown, because event modifier only use
>> bottom 4 bits.
>>
>> Fixes: 55fc0c561742 ("powerpc/pseries: Parse and handle EPOW
>> interrupts")
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> Hello,
>
> This fails to compile.
>
> arch/powerpc/platforms/pseries/ras.c: In function
> 'rtas_parse_epow_errlog':
> arch/powerpc/platforms/pseries/ras.c:288:26: error: 'event_modifier'
> undeclared (first use in this function); did you mean 'modifier'?
> handle_system_shutdown(event_modifier);
> ^~~~~~~~~~~~~~
> modifier
Yes, this should be 'modifier'
>
> So yes, I assume you meant "modifier" instead of "event_modifier" as
> mentioned in your commit message. Did you compile this before sending?
I am very sorry for this, this is not my compiled version,
I forgot to check again before sending.
>
> (found by snowpatch)
>
> - Russell
>
>
> .
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] powerpc/pseries: Use correct event modifier in rtas_parse_epow_errlog()
2019-04-23 14:35 [PATCH] powerpc/pseries: Use correct event modifier in rtas_parse_epow_errlog() Yue Haibing
2019-04-24 1:29 ` Russell Currey
@ 2019-04-24 2:17 ` Yue Haibing
2019-04-25 22:17 ` Tyrel Datwyler
2019-05-30 15:00 ` Yuehaibing
1 sibling, 2 replies; 6+ messages in thread
From: Yue Haibing @ 2019-04-24 2:17 UTC (permalink / raw)
To: benh, paulus, mpe, mahesh, npiggin, ganeshgr, anton, ruscur
Cc: YueHaibing, linuxppc-dev, linux-kernel
From: YueHaibing <yuehaibing@huawei.com>
rtas_parse_epow_errlog() should pass 'modifier' to
handle_system_shutdown, because event modifier only use
bottom 4 bits.
Fixes: 55fc0c561742 ("powerpc/pseries: Parse and handle EPOW interrupts")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
v2: fix compile issue by 'event_modifier'-->'modifier'
---
arch/powerpc/platforms/pseries/ras.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/pseries/ras.c b/arch/powerpc/platforms/pseries/ras.c
index c97d153..744604d 100644
--- a/arch/powerpc/platforms/pseries/ras.c
+++ b/arch/powerpc/platforms/pseries/ras.c
@@ -285,7 +285,7 @@ static void rtas_parse_epow_errlog(struct rtas_error_log *log)
break;
case EPOW_SYSTEM_SHUTDOWN:
- handle_system_shutdown(epow_log->event_modifier);
+ handle_system_shutdown(modifier);
break;
case EPOW_SYSTEM_HALT:
--
2.7.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] powerpc/pseries: Use correct event modifier in rtas_parse_epow_errlog()
2019-04-24 2:17 ` [PATCH v2] " Yue Haibing
@ 2019-04-25 22:17 ` Tyrel Datwyler
2019-05-30 15:00 ` Yuehaibing
1 sibling, 0 replies; 6+ messages in thread
From: Tyrel Datwyler @ 2019-04-25 22:17 UTC (permalink / raw)
To: Yue Haibing, benh, paulus, mpe, mahesh, npiggin, ganeshgr, anton,
ruscur
Cc: linuxppc-dev, linux-kernel
On 04/23/2019 07:17 PM, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> rtas_parse_epow_errlog() should pass 'modifier' to
> handle_system_shutdown, because event modifier only use
> bottom 4 bits.
>
> Fixes: 55fc0c561742 ("powerpc/pseries: Parse and handle EPOW interrupts")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
Reviewed-by: Tyrel Datwyler <tyreld@linux.ibm.com>
> v2: fix compile issue by 'event_modifier'-->'modifier'
> ---
> arch/powerpc/platforms/pseries/ras.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/pseries/ras.c b/arch/powerpc/platforms/pseries/ras.c
> index c97d153..744604d 100644
> --- a/arch/powerpc/platforms/pseries/ras.c
> +++ b/arch/powerpc/platforms/pseries/ras.c
> @@ -285,7 +285,7 @@ static void rtas_parse_epow_errlog(struct rtas_error_log *log)
> break;
>
> case EPOW_SYSTEM_SHUTDOWN:
> - handle_system_shutdown(epow_log->event_modifier);
> + handle_system_shutdown(modifier);
> break;
>
> case EPOW_SYSTEM_HALT:
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] powerpc/pseries: Use correct event modifier in rtas_parse_epow_errlog()
2019-04-24 2:17 ` [PATCH v2] " Yue Haibing
2019-04-25 22:17 ` Tyrel Datwyler
@ 2019-05-30 15:00 ` Yuehaibing
1 sibling, 0 replies; 6+ messages in thread
From: Yuehaibing @ 2019-05-30 15:00 UTC (permalink / raw)
To: benh, paulus, mpe, mahesh, npiggin, ganeshgr, anton, ruscur
Cc: linuxppc-dev, linux-kernel
Hi all,
Friendly ping:
Who can take this?
On 2019/4/24 10:17, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> rtas_parse_epow_errlog() should pass 'modifier' to
> handle_system_shutdown, because event modifier only use
> bottom 4 bits.
>
> Fixes: 55fc0c561742 ("powerpc/pseries: Parse and handle EPOW interrupts")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> v2: fix compile issue by 'event_modifier'-->'modifier'
> ---
> arch/powerpc/platforms/pseries/ras.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/pseries/ras.c b/arch/powerpc/platforms/pseries/ras.c
> index c97d153..744604d 100644
> --- a/arch/powerpc/platforms/pseries/ras.c
> +++ b/arch/powerpc/platforms/pseries/ras.c
> @@ -285,7 +285,7 @@ static void rtas_parse_epow_errlog(struct rtas_error_log *log)
> break;
>
> case EPOW_SYSTEM_SHUTDOWN:
> - handle_system_shutdown(epow_log->event_modifier);
> + handle_system_shutdown(modifier);
> break;
>
> case EPOW_SYSTEM_HALT:
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-05-30 15:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-23 14:35 [PATCH] powerpc/pseries: Use correct event modifier in rtas_parse_epow_errlog() Yue Haibing
2019-04-24 1:29 ` Russell Currey
2019-04-24 1:48 ` YueHaibing
2019-04-24 2:17 ` [PATCH v2] " Yue Haibing
2019-04-25 22:17 ` Tyrel Datwyler
2019-05-30 15:00 ` Yuehaibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox