Re: [PATCH] powerpc: Do not fail build if mkimage is not available

[Andreas Schwab <schwab@suse.de>]

Michael Buesch <mb@bu3sch.de> writes:

> On Wednesday 26 December 2007 16:33:57 Andreas Schwab wrote:
>> Michael Buesch <mb@bu3sch.de> writes:
>> 
>> > On Wednesday 26 December 2007 15:47:05 Andreas Schwab wrote:
>> >> Michael Buesch <mb@bu3sch.de> writes:
>> >> 
>> >> > +    if ! [ -x mkimage ]; then
>> >> 
>> >> What is this supposed to test?
>> >
>> > from man test:
>> 
>> You didn't answer my question.
>
> I'm not sure how I can make the manual text any clearer

I know very well what it *does*, thank you.  But that does mean that is
does what it is *supposed* to do.

>        -x FILE
>               FILE exists and execute (or search) permission is granted
                ^^^^
> It tests if the program exists and is executable.
                  ^^^^^^^
Observe the fine difference in the choice of words.

> That would help a lot not wasting my time.

How about testing your changes first?

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."