[PATCH] powerpc: Do not fail build if mkimage is not available

[PATCH] powerpc: Do not fail build if mkimage is not available

[Michael Buesch]

This fixes the boot image wrapper script to not fail the kernel
build if mkimage is not available.
As some distributions don't ship the mkimage program and some people are not
interested in uboot images anyway, we don't want to fail the whole kernel
build process because of this unneeded dependency.

Simply drop an error message, but don't fail the build.

Signed-off-by: Michael Buesch <mb@bu3sch.de>

---

Josh Boyer is working on merging mkimage into the kernel tree.
Until that happened, please merge the patch below into the mainline kernel
to avoid build breakage for people without installed uboot tools.

Index: wireless-2.6/arch/powerpc/boot/wrapper
===================================================================
--- wireless-2.6.orig/arch/powerpc/boot/wrapper	2007-12-23 20:10:07.000000000 +0100
+++ wireless-2.6/arch/powerpc/boot/wrapper	2007-12-23 20:22:41.000000000 +0100
@@ -195,6 +195,14 @@ if [ -n "$version" ]; then
 fi
 
 case "$platform" in
+cuboot* | uboot)
+    if ! [ -x mkimage ]; then
+        echo "mkimage not available. Can not create $platform image."
+        exit 0
+    fi
+esac
+
+case "$platform" in
 uboot)
     rm -f "$ofile"
     mkimage -A ppc -O linux -T kernel -C gzip -a 00000000 -e 00000000 \

Re: [PATCH] powerpc: Do not fail build if mkimage is not available

[Andreas Schwab]

Michael Buesch <mb@bu3sch.de> writes:

> +    if ! [ -x mkimage ]; then

What is this supposed to test?

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: [PATCH] powerpc: Do not fail build if mkimage is not available

[Michael Buesch]

On Wednesday 26 December 2007 15:47:05 Andreas Schwab wrote:
> Michael Buesch <mb@bu3sch.de> writes:
> 
> > +    if ! [ -x mkimage ]; then
> 
> What is this supposed to test?

from man test:
       -x FILE
              FILE exists and execute (or search) permission is granted

-- 
Greetings Michael.

Re: [PATCH] powerpc: Do not fail build if mkimage is not available

[Andreas Schwab]

Michael Buesch <mb@bu3sch.de> writes:

> On Wednesday 26 December 2007 15:47:05 Andreas Schwab wrote:
>> Michael Buesch <mb@bu3sch.de> writes:
>> 
>> > +    if ! [ -x mkimage ]; then
>> 
>> What is this supposed to test?
>
> from man test:

You didn't answer my question.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: [PATCH] powerpc: Do not fail build if mkimage is not available

[Michael Buesch]

On Wednesday 26 December 2007 16:33:57 Andreas Schwab wrote:
> Michael Buesch <mb@bu3sch.de> writes:
> 
> > On Wednesday 26 December 2007 15:47:05 Andreas Schwab wrote:
> >> Michael Buesch <mb@bu3sch.de> writes:
> >> 
> >> > +    if ! [ -x mkimage ]; then
> >> 
> >> What is this supposed to test?
> >
> > from man test:
> 
> You didn't answer my question.

I'm not sure how I can make the manual text any clearer

       -x FILE
              FILE exists and execute (or search) permission is granted

It tests if the program exists and is executable.
Could you please be more specific about what you don't understand?
That would help a lot not wasting my time.

-- 
Greetings Michael.

Re: [PATCH] powerpc: Do not fail build if mkimage is not available

[Andreas Schwab]

Michael Buesch <mb@bu3sch.de> writes:

> On Wednesday 26 December 2007 16:33:57 Andreas Schwab wrote:
>> Michael Buesch <mb@bu3sch.de> writes:
>> 
>> > On Wednesday 26 December 2007 15:47:05 Andreas Schwab wrote:
>> >> Michael Buesch <mb@bu3sch.de> writes:
>> >> 
>> >> > +    if ! [ -x mkimage ]; then
>> >> 
>> >> What is this supposed to test?
>> >
>> > from man test:
>> 
>> You didn't answer my question.
>
> I'm not sure how I can make the manual text any clearer

I know very well what it *does*, thank you.  But that does mean that is
does what it is *supposed* to do.

>        -x FILE
>               FILE exists and execute (or search) permission is granted
                ^^^^
> It tests if the program exists and is executable.
                  ^^^^^^^
Observe the fine difference in the choice of words.

> That would help a lot not wasting my time.

How about testing your changes first?

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: [PATCH] powerpc: Do not fail build if mkimage is not available

[Michael Buesch]

On Wednesday 26 December 2007 16:56:57 Andreas Schwab wrote:
> > That would help a lot not wasting my time.
> 
> How about testing your changes first?

Stop the bullshit, please.
I tested this and it obviously works very well for me.
I even posted it for review on this list and nobody complained,
including you.

But I see what you are complaining about, now.
It would also error out, if mkimage was installed (which is not the
case for me. That's the whole reason for me making this patch!).

Are you OK with the new version I just sent?

-- 
Greetings Michael.

Re: [PATCH] powerpc: Do not fail build if mkimage is not available

[Andreas Schwab]

Michael Buesch <mb@bu3sch.de> writes:

> I tested this and it obviously works very well for me.

Obviously your tests were incomplete.

> I even posted it for review on this list and nobody complained,
> including you.

???  I did point out an error in your patch just now.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: [PATCH] powerpc: Do not fail build if mkimage is not available

[Michael Buesch]

On Wednesday 26 December 2007 17:08:55 Andreas Schwab wrote:
> > I even posted it for review on this list and nobody complained,
> > including you.
> 
> ???  I did point out an error in your patch just now.

I posted it for review a few days ago and the only response
I got was "This is probably OK for now..." from Josh.

-- 
Greetings Michael.

Re: [PATCH] powerpc: Do not fail build if mkimage is not available

[Andreas Schwab]

Michael Buesch <mb@bu3sch.de> writes:

> On Wednesday 26 December 2007 17:08:55 Andreas Schwab wrote:
>> > I even posted it for review on this list and nobody complained,
>> > including you.
>> 
>> ???  I did point out an error in your patch just now.
>
> I posted it for review a few days ago and the only response
> I got was "This is probably OK for now..." from Josh.

And what does this have to do with me?  I didn't see your mail at all.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."