* Re: [PATCH] mv643xx_eth_pcidev : implement hotplug by matching the Discovery II/III northbridge pci id (Was: + mv643xx_eth_pcidev-implements-hotplug-for-the-marvell-gige-functionality-by-probing-the-northbridge-pci-id.patch added to -mm tree)
From: Sven Luther @ 2006-10-03 16:29 UTC (permalink / raw)
To: Olaf Hering; +Cc: Andrew Morton, linuxppc-dev, Sven Luther, Jeff Garzik
In-Reply-To: <20061003142355.GA26207@aepfle.de>
On Tue, Oct 03, 2006 at 04:23:55PM +0200, Olaf Hering wrote:
> On Tue, Oct 03, Sven Luther wrote:
>
> > Match the Marvell Discovery II/III northbridge pci id to add hotplug
> > support for the builtin gigabit ethernet driver (mv643xx_eth).
>
> there is no need for this patch. a0245f7ad5214cb00131d7cd176446e067c913dc fixed it.
I think that is a limited description, not sure.
> Put this in your early boot scripts:
>
> for i in `find /sys -name modalias`;do /sbin/modprobe -v "`cat $i`"&done
Does this also account for all those distributions out there who have pure
udev based installers ?
Friendly,
Sven Luther
^ permalink raw reply
* Re: [PATCH] mv643xx_eth_pcidev : implement hotplug by matching the Discovery II/III northbridge pci id (Was: + mv643xx_eth_pcidev-implements-hotplug-for-the-marvell-gige-functionality-by-probing-the-northbridge-pci-id.patch added to -mm tree)
From: Olaf Hering @ 2006-10-03 16:46 UTC (permalink / raw)
To: Sven Luther; +Cc: Andrew Morton, linuxppc-dev, Sven Luther, Jeff Garzik
In-Reply-To: <20061003162905.GA1006@powerlinux.fr>
On Tue, Oct 03, Sven Luther wrote:
> Does this also account for all those distributions out there who have pure
> udev based installers ?
Maybe udev does just a 'modprobe $MODALIAS', I dont know.
^ permalink raw reply
* RFC: qe lib code location?
From: Kumar Gala @ 2006-10-03 16:34 UTC (permalink / raw)
To: Kim Phillips, Li Yang; +Cc: linuxppc-dev list
I was wondering what peoples thought were on having the qe lib code
live in drivers/qe instead of sysdev/qe_lib (with the exception of
the interrupt controller code)
Yes, one can argue the cpm code should live in drivers/cpm by this
logic, but lets considered them grandfathered for now.
- kumar
^ permalink raw reply
* Re: [PATCH] mv643xx_eth_pcidev : implement hotplug by matching the Discovery II/III northbridge pci id (Was: + mv643xx_eth_pcidev-implements-hotplug-for-the-marvell-gige-functionality-by-probing-the-northbridge-pci-id.patch added to -mm tree)
From: Sven Luther @ 2006-10-03 17:09 UTC (permalink / raw)
To: Olaf Hering; +Cc: Andrew Morton, linuxppc-dev, Sven Luther, Jeff Garzik
In-Reply-To: <20061003164605.GA27962@aepfle.de>
On Tue, Oct 03, 2006 at 06:46:05PM +0200, Olaf Hering wrote:
> On Tue, Oct 03, Sven Luther wrote:
>
> > Does this also account for all those distributions out there who have pure
> > udev based installers ?
>
> Maybe udev does just a 'modprobe $MODALIAS', I dont know.
Do you have a more complete url to the patch ? Just googling for the checksum
didn't bring anything.
I will investigate the udev side of this.
Friendly,
Sven Luther
^ permalink raw reply
* Re: [PATCH] mv643xx_eth_pcidev : implement hotplug by matching the Discovery II/III northbridge pci id (Was: + mv643xx_eth_pcidev-implements-hotplug-for-the-marvell-gige-functionality-by-probing-the-northbridge-pci-id.patch added to -mm tree)
From: Olaf Hering @ 2006-10-03 17:35 UTC (permalink / raw)
To: Sven Luther; +Cc: Andrew Morton, linuxppc-dev, Sven Luther, Jeff Garzik
In-Reply-To: <20061003170933.GA2386@powerlinux.fr>
On Tue, Oct 03, Sven Luther wrote:
> Do you have a more complete url to the patch ? Just googling for the checksum
> didn't bring anything.
http://www.kernel.org/git
-> linux/kernel/git/torvalds/linux-2.6.git
-> shortlog
enter a0245f7ad5214cb00131d7cd176446e067c913dc into the search field
http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=a0245f7ad5214cb00131d7cd176446e067c913dc
^ permalink raw reply
* Re: RFC: qe lib code location?
From: Dan Malek @ 2006-10-03 17:30 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev list, Kim Phillips, Li Yang
In-Reply-To: <724D42AC-3DBA-4B32-8E4A-914441251470@kernel.crashing.org>
On Oct 3, 2006, at 12:34 PM, Kumar Gala wrote:
> I was wondering what peoples thought were on having the qe lib code
> live in drivers/qe instead of sysdev/qe_lib (with the exception of
> the interrupt controller code)
My personal reason for choosing one place or the other
is based upon usefulness to architectures other than PowerPC,
or general kernel APIs that may change. If something is
useful to architectures other than PowerPC, clearly it
should go there. If the software has dependencies on
general kernel APIs (networking is a good example), I like
to put is there in hopes that someone changing the APIs
will at least make an attempt to keep this code up to
date as well.
I think it neither of these apply (and I don't think the VM
interfaces are a good argument because they generally
affect the architecture ports anyway), then I think it
should stay in a more architecture specific place.
> Yes, one can argue the cpm code should live in drivers/cpm by this
> logic, but lets considered them grandfathered for now.
I would say that based on my opinion above the cpm
stuff should stay in sysdev, too. These are not only
powerpc specific, but even Freescale embedded powerpc
specific. I don't think that code belongs in drivers.
Thanks.
-- Dan
^ permalink raw reply
* [PATCH] Add DOS partition support to mpc834x_itx_defconfig
From: Timur Tabi @ 2006-10-03 17:48 UTC (permalink / raw)
To: linuxppc-dev
(resending because the signed-off line was missing)
The default configuration file for the MPC8349E-mITX reference board,
mpc834x_itx_defconfig, did not include support for DOS partition table types.
This support is necessary because the hard drive that comes with the ITX
is formatted with this partition table type. Without this config option,
the drive cannot be mounted.
Signed-off-by: Timur Tabi <timur@freescale.com>
---
arch/powerpc/configs/mpc834x_itx_defconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/configs/mpc834x_itx_defconfig b/arch/powerpc/configs/mpc834x_itx_defconfig
index cd3535e..0561b73 100644
--- a/arch/powerpc/configs/mpc834x_itx_defconfig
+++ b/arch/powerpc/configs/mpc834x_itx_defconfig
@@ -1248,7 +1248,7 @@ # CONFIG_OSF_PARTITION is not set
# CONFIG_AMIGA_PARTITION is not set
# CONFIG_ATARI_PARTITION is not set
# CONFIG_MAC_PARTITION is not set
-# CONFIG_MSDOS_PARTITION is not set
+CONFIG_MSDOS_PARTITION=y
# CONFIG_LDM_PARTITION is not set
# CONFIG_SGI_PARTITION is not set
# CONFIG_ULTRIX_PARTITION is not set
--
1.4.2.1
^ permalink raw reply related
* Re: [PATCH] mv643xx_eth_pcidev : implement hotplug by matching the Discovery II/III northbridge pci id (Was: + mv643xx_eth_pcidev-implements-hotplug-for-the-marvell-gige-functionality-by-probing-the-northbridge-pci-id.patch added to -mm tree)
From: Brent Cook @ 2006-10-03 17:37 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Andrew Morton, Olaf Hering, Sven Luther, Jeff Garzik
In-Reply-To: <20061003170933.GA2386@powerlinux.fr>
On Tuesday 03 October 2006 12:09, Sven Luther wrote:
> On Tue, Oct 03, 2006 at 06:46:05PM +0200, Olaf Hering wrote:
> > On Tue, Oct 03, Sven Luther wrote:
> > > Does this also account for all those distributions out there who have
> > > pure udev based installers ?
> >
> > Maybe udev does just a 'modprobe $MODALIAS', I dont know.
>
> Do you have a more complete url to the patch ? Just googling for the
> checksum didn't bring anything.
Is this it? I just pasted the md5 sum into the search box:
http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=a0245f7ad5214cb00131d7cd176446e067c913dc
> I will investigate the udev side of this.
>
> Friendly,
>
> Sven Luther
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
^ permalink raw reply
* Re: [PATCH 4/7] Add MPC8360EMDS board support
From: Kim Phillips @ 2006-10-03 18:02 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev, paulus
In-Reply-To: <41AC40EF-31AC-42FE-9C1A-9B80233D2E64@kernel.crashing.org>
On Mon, 2 Oct 2006 22:19:14 -0500
Kumar Gala <galak@kernel.crashing.org> wrote:
> [snip]
>
> > +static u8 *bcsr_regs = NULL;
> > +
> > +u8 *get_bcsr(void)
> > +{
> > + return bcsr_regs;
> > +}
>
> Is get_bcsr() needed since you removed its use from ucc_geth? (if
> not, let's remove it and the header as well).
>
it will be once we figure out a better way of handling it from usb and ethernet phy code. I had just removed it due to Paul's comment (bcsr bits are being manipulated in the wrong place (ucc_geth)).
Kim
^ permalink raw reply
* Re: todc must die!
From: Mark A. Greer @ 2006-10-03 18:18 UTC (permalink / raw)
To: David Gibson; +Cc: linuxppc-dev, Paul Mackerras
In-Reply-To: <20061003065744.GC29689@localhost.localdomain>
On Tue, Oct 03, 2006 at 04:57:44PM +1000, David Gibson wrote:
> Paulus, please apply to your powerpc git tree.
>
> powerpc: Remove todc code from ARCH=powerpc
>
> Apparently we've copied the todc drivers, for various RTCs used in
> embedded machines from ARCH=ppc to ARCH=powerpc, despite the fact that
> it's never used in the latter. This patch removes it.
Well, its used, its just that the patches that add users are backed up
waiting for the outcome of flatdevtree changes.
> If we ever need these drivers (which we probably shouldn't now the RTC
> class stuff is in), we can transfer them one by one from ARCH=ppc,
> removing from the hideous abomination which is the todc
> "infrastructure".
Yes, the new RTC infrastructure should be used instead. Copying over
the todc stuff to powerpc was a stop-gap measure whose time has probably
come.
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Acked-by: Mark A. Greer <mgreer@mvista.com>
^ permalink raw reply
* Re: [PATCH 4/7] Add MPC8360EMDS board support
From: Kumar Gala @ 2006-10-03 18:20 UTC (permalink / raw)
To: Kim Phillips; +Cc: linuxppc-dev list, Paul Mackerras
In-Reply-To: <20061003130245.58267c54.kim.phillips@freescale.com>
On Oct 3, 2006, at 1:02 PM, Kim Phillips wrote:
> On Mon, 2 Oct 2006 22:19:14 -0500
> Kumar Gala <galak@kernel.crashing.org> wrote:
>
>> [snip]
>>
>
>>> +static u8 *bcsr_regs = NULL;
>>> +
>>> +u8 *get_bcsr(void)
>>> +{
>>> + return bcsr_regs;
>>> +}
>>
>> Is get_bcsr() needed since you removed its use from ucc_geth? (if
>> not, let's remove it and the header as well).
>>
>
> it will be once we figure out a better way of handling it from usb
> and ethernet phy code. I had just removed it due to Paul's comment
> (bcsr bits are being manipulated in the wrong place (ucc_geth)).
ok, but nothing is using it in the tree anymore.
Clearly, the phy support for ucc_geth needs to move over to using the
phylib and I think Andy was looking at how to provide board level
hooks to the phylib.
- k
^ permalink raw reply
* Re: [RFC][PATCH 1/2] remove mpc83xx support from arch/ppc
From: Jon Loeliger @ 2006-10-03 18:20 UTC (permalink / raw)
To: linuxppc-dev@ozlabs.org
In-Reply-To: <229C6ACA-4728-408B-9360-54249996E821@kernel.crashing.org>
On Thu, 2006-09-28 at 16:34, Kumar Gala wrote:
> On Sep 28, 2006, at 4:02 PM, Kim Phillips wrote:
>
> > remove 83xx support from arch/ppc. Tested multiple arch/defconfig
> > build combinations ok. AFAICT, everything 83xx works in arch/
> > powerpc, and new derivatives are being added only to arch/powerpc,
> > so it's better not to keep this around.
>
> NACK!! we need the cuImage stuff working and in the tree before I'm
> ok with this. We have to be able to boot from a non-flat-dev aware u-
> boot before I'll be ok with removing 83xx from arch/ppc.
>
> - kumar
Any idea when those patches are going to be in?
Thanks,
jdl
^ permalink raw reply
* Re: RFC: qe lib code location?
From: Vitaly Bordug @ 2006-10-03 18:30 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev list, Kim Phillips, Li Yang
In-Reply-To: <724D42AC-3DBA-4B32-8E4A-914441251470@kernel.crashing.org>
[-- Attachment #1: Type: text/plain, Size: 660 bytes --]
On Tue, 3 Oct 2006 11:34:11 -0500
Kumar Gala wrote:
> I was wondering what peoples thought were on having the qe lib code
> live in drivers/qe instead of sysdev/qe_lib (with the exception of
> the interrupt controller code)
>
> Yes, one can argue the cpm code should live in drivers/cpm by this
> logic, but lets considered them grandfathered for now.
>
My vote to let it be as it is now. The lib should be generic enough and for now there are way few QE-enabled designs to declare it generic even inside ppc. Once it virtually become such a thing - nothing will prevent us to move it to the proper location IMHO.
Thanks,
-Vitaly
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply
* Please pull upstream branch of linux-2.6-PQ.git...
From: Vitaly Bordug @ 2006-10-03 18:30 UTC (permalink / raw)
To: Paul Mackerras; +Cc: linuxppc-dev@ozlabs.org
[-- Attachment #1: Type: text/plain, Size: 2678 bytes --]
Paul,
Please do a pull from
git://git.kernel.org/pub/scm/linux/kernel/git/vitb/linux-2.6-PQ.git, upstream branch.
Signed-off-by: Vitaly Bordug <vbordug@ru.mvista.com>
To receive the updated 8272 addition to the arch/powerpc.
All the comments have been addressed, and it has a minor bugfix addressed too in order to make both pq2 and pq3
co-exist happily in fsl_soc.c. CPM PIC now has "compatible" property that could be "CPM2" or "CPM1" for PQ/8xx.
I think it should go to rc1, because relevant stuff in ppc/ is more or less broken now, with new irq engine.
--
arch/powerpc/Kconfig | 1
arch/powerpc/boot/dts/mpc8272ads.dts | 223 ++++++++++
arch/powerpc/platforms/82xx/Kconfig | 21
arch/powerpc/platforms/82xx/Makefile | 5
arch/powerpc/platforms/82xx/m82xx_pci.h | 19
arch/powerpc/platforms/82xx/mpc82xx.c | 111 +++++
arch/powerpc/platforms/82xx/mpc82xx_ads.c | 661 ++++++++++++++++++++++++++++++
arch/powerpc/platforms/82xx/pq2ads.h | 67 +++
arch/powerpc/sysdev/cpm2_pic.c | 2
arch/powerpc/sysdev/cpm2_pic.h | 2
arch/powerpc/sysdev/fsl_soc.c | 62 ++
11 files changed, 1165 insertions(+), 9 deletions(-)
commit 91bd61099defb28a442db358dd9c1693c6589cee
Author: Vitaly Bordug <vbordug@ru.mvista.com>
Date: Mon Oct 2 22:45:17 2006 +0400
POWERPC: mpc82xx merge: board-specific/platform stuff(resend)
This intruduces 82xx family in arch/powerpc/platforms,
and has all the board-specific code to represent regression-less
transaction from ppc. The functionality is apparently the same, including
PCI controller.
Signed-off-by: Vitaly Bordug <vbordug@ru.mvista.com>
commit ed943c1faba53d9a0bde56007ee27762b29dccbd
Author: Vitaly Bordug <vbordug@ru.mvista.com>
Date: Mon Oct 2 22:41:50 2006 +0400
POWERPC: 8272ads merge to powerpc: common stuff
This has modules of common directories related to the
mpc8272ADS board, mainly common cpm2 changes and fsl_soc.c
portions related to the bitbang MDIO and other mechanisms specific
for this family.
Signed-off-by: Vitaly Bordug <vbordug@ru.mvista.com>
commit e02f73e9fd69f1c6d16c207f7a91ce721fe8beab
Author: Vitaly Bordug <vbordug@ru.mvista.com>
Date: Mon Oct 2 22:22:36 2006 +0400
POWERPC: Added devicetree for mpc8272ads board
This adds current dts file used with MPC8272ADS,
introducing new mdio bitbang defines, as well as
fully-CPM2-SoC board design.
Signed-off-by: Vitaly Bordug <vbordug@ru.mvista.com>
--
Sincerely, Vitaly
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply
* Re: [RFC][PATCH 1/2] remove mpc83xx support from arch/ppc
From: Kumar Gala @ 2006-10-03 18:42 UTC (permalink / raw)
To: Jon Loeliger; +Cc: linuxppc-dev@ozlabs.org
In-Reply-To: <1159899616.14294.127.camel@cashmere.sps.mot.com>
On Oct 3, 2006, at 1:20 PM, Jon Loeliger wrote:
> On Thu, 2006-09-28 at 16:34, Kumar Gala wrote:
>> On Sep 28, 2006, at 4:02 PM, Kim Phillips wrote:
>>
>>> remove 83xx support from arch/ppc. Tested multiple arch/defconfig
>>> build combinations ok. AFAICT, everything 83xx works in arch/
>>> powerpc, and new derivatives are being added only to arch/powerpc,
>>> so it's better not to keep this around.
>>
>> NACK!! we need the cuImage stuff working and in the tree before I'm
>> ok with this. We have to be able to boot from a non-flat-dev
>> aware u-
>> boot before I'll be ok with removing 83xx from arch/ppc.
>>
>> - kumar
>
> Any idea when those patches are going to be in?
Not sure, I wasn't sure if there were changes required to the patches
for all the flat dev tree code going into the tree.
- k
^ permalink raw reply
* Re: Please pull upstream branch of linux-2.6-PQ.git...
From: Kumar Gala @ 2006-10-03 18:43 UTC (permalink / raw)
To: Vitaly Bordug; +Cc: linuxppc-dev@ozlabs.org, Paul Mackerras
In-Reply-To: <20061003223054.06e25136@localhost.localdomain>
On Oct 3, 2006, at 1:30 PM, Vitaly Bordug wrote:
> Paul,
>
> Please do a pull from
>
> git://git.kernel.org/pub/scm/linux/kernel/git/vitb/linux-2.6-
> PQ.git, upstream branch.
>
> Signed-off-by: Vitaly Bordug <vbordug@ru.mvista.com>
>
>
> To receive the updated 8272 addition to the arch/powerpc.
> All the comments have been addressed, and it has a minor bugfix
> addressed too in order to make both pq2 and pq3
> co-exist happily in fsl_soc.c. CPM PIC now has "compatible"
> property that could be "CPM2" or "CPM1" for PQ/8xx.
>
> I think it should go to rc1, because relevant stuff in ppc/ is more
> or less broken now, with new irq engine.
>
> --
>
> arch/powerpc/Kconfig | 1
> arch/powerpc/boot/dts/mpc8272ads.dts | 223 ++++++++++
> arch/powerpc/platforms/82xx/Kconfig | 21
> arch/powerpc/platforms/82xx/Makefile | 5
> arch/powerpc/platforms/82xx/m82xx_pci.h | 19
> arch/powerpc/platforms/82xx/mpc82xx.c | 111 +++++
> arch/powerpc/platforms/82xx/mpc82xx_ads.c | 661 ++++++++++++++++++
> ++++++++++++
> arch/powerpc/platforms/82xx/pq2ads.h | 67 +++
> arch/powerpc/sysdev/cpm2_pic.c | 2
> arch/powerpc/sysdev/cpm2_pic.h | 2
> arch/powerpc/sysdev/fsl_soc.c | 62 ++
> 11 files changed, 1165 insertions(+), 9 deletions(-)
Are there updates to the flat dev spec for the CPM nodes? That is my
only hold up on ack'ing all this good PQ2/PQ3 CPM work.
- k
^ permalink raw reply
* Re: Please pull upstream branch of linux-2.6-PQ.git...
From: Vitaly Bordug @ 2006-10-03 19:05 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev@ozlabs.org, Paul Mackerras
In-Reply-To: <E0C344B6-3149-46E4-8573-6EA220F4D7FE@kernel.crashing.org>
[-- Attachment #1: Type: text/plain, Size: 2487 bytes --]
On Tue, 3 Oct 2006 13:43:35 -0500
Kumar Gala wrote:
>
> On Oct 3, 2006, at 1:30 PM, Vitaly Bordug wrote:
>
> > Paul,
> >
> > Please do a pull from
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/vitb/linux-2.6-
> > PQ.git, upstream branch.
> >
> > Signed-off-by: Vitaly Bordug <vbordug@ru.mvista.com>
> >
> >
> > To receive the updated 8272 addition to the arch/powerpc.
> > All the comments have been addressed, and it has a minor bugfix
> > addressed too in order to make both pq2 and pq3
> > co-exist happily in fsl_soc.c. CPM PIC now has "compatible"
> > property that could be "CPM2" or "CPM1" for PQ/8xx.
> >
> > I think it should go to rc1, because relevant stuff in ppc/ is
> > more or less broken now, with new irq engine.
> >
> > --
> >
> > arch/powerpc/Kconfig | 1
> > arch/powerpc/boot/dts/mpc8272ads.dts | 223 ++++++++++
> > arch/powerpc/platforms/82xx/Kconfig | 21
> > arch/powerpc/platforms/82xx/Makefile | 5
> > arch/powerpc/platforms/82xx/m82xx_pci.h | 19
> > arch/powerpc/platforms/82xx/mpc82xx.c | 111 +++++
> > arch/powerpc/platforms/82xx/mpc82xx_ads.c | 661
> > ++++++++++++++++++ ++++++++++++
> > arch/powerpc/platforms/82xx/pq2ads.h | 67 +++
> > arch/powerpc/sysdev/cpm2_pic.c | 2
> > arch/powerpc/sysdev/cpm2_pic.h | 2
> > arch/powerpc/sysdev/fsl_soc.c | 62 ++
> > 11 files changed, 1165 insertions(+), 9 deletions(-)
>
> Are there updates to the flat dev spec for the CPM nodes? That is
> my only hold up on ack'ing all this good PQ2/PQ3 CPM work.
>
It is coming along with QE docs, on top of it, since we decided to make CPM a "sibliing".
I'll follow-up with the stuff in the separate domain if we've no chance to get QE thing in this time.
Though, tha't not what will be good, because we should keep clear, how similar are CPM and QE.
Again, most of the node things are self-explanatory and assuming ppc/ entity of 8272 does not
function properly anymore, I really want this in rc1. There are many boards like it, so this will encourage people
to move to the powerpc which with a reference much more simple than fix ppc/ irq stuff.
So, as a recap physically spec is ready, just depending on QE spec that is floating around still :)
And, having 85xx cpm2 stuff in the Linus' mainline atm, there's no much reason holding this, is there ;) ?
--
Thanks,
-Vitaly
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply
* Re: Please pull upstream branch of linux-2.6-PQ.git...
From: Kumar Gala @ 2006-10-03 19:14 UTC (permalink / raw)
To: Vitaly Bordug; +Cc: linuxppc-dev@ozlabs.org, Paul Mackerras
In-Reply-To: <20061003230543.6cc82325@localhost.localdomain>
On Oct 3, 2006, at 2:05 PM, Vitaly Bordug wrote:
> On Tue, 3 Oct 2006 13:43:35 -0500
> Kumar Gala wrote:
>
>>
>> On Oct 3, 2006, at 1:30 PM, Vitaly Bordug wrote:
>>
>>> Paul,
>>>
>>> Please do a pull from
>>>
>>> git://git.kernel.org/pub/scm/linux/kernel/git/vitb/linux-2.6-
>>> PQ.git, upstream branch.
>>>
>>> Signed-off-by: Vitaly Bordug <vbordug@ru.mvista.com>
>>>
>>>
>>> To receive the updated 8272 addition to the arch/powerpc.
>>> All the comments have been addressed, and it has a minor bugfix
>>> addressed too in order to make both pq2 and pq3
>>> co-exist happily in fsl_soc.c. CPM PIC now has "compatible"
>>> property that could be "CPM2" or "CPM1" for PQ/8xx.
>>>
>>> I think it should go to rc1, because relevant stuff in ppc/ is
>>> more or less broken now, with new irq engine.
>>>
>>> --
>>>
>>> arch/powerpc/Kconfig | 1
>>> arch/powerpc/boot/dts/mpc8272ads.dts | 223 ++++++++++
>>> arch/powerpc/platforms/82xx/Kconfig | 21
>>> arch/powerpc/platforms/82xx/Makefile | 5
>>> arch/powerpc/platforms/82xx/m82xx_pci.h | 19
>>> arch/powerpc/platforms/82xx/mpc82xx.c | 111 +++++
>>> arch/powerpc/platforms/82xx/mpc82xx_ads.c | 661
>>> ++++++++++++++++++ ++++++++++++
>>> arch/powerpc/platforms/82xx/pq2ads.h | 67 +++
>>> arch/powerpc/sysdev/cpm2_pic.c | 2
>>> arch/powerpc/sysdev/cpm2_pic.h | 2
>>> arch/powerpc/sysdev/fsl_soc.c | 62 ++
>>> 11 files changed, 1165 insertions(+), 9 deletions(-)
>>
>> Are there updates to the flat dev spec for the CPM nodes? That is
>> my only hold up on ack'ing all this good PQ2/PQ3 CPM work.
>>
>
> It is coming along with QE docs, on top of it, since we decided to
> make CPM a "sibliing".
> I'll follow-up with the stuff in the separate domain if we've no
> chance to get QE thing in this time.
> Though, tha't not what will be good, because we should keep clear,
> how similar are CPM and QE.
>
> Again, most of the node things are self-explanatory and assuming
> ppc/ entity of 8272 does not
> function properly anymore, I really want this in rc1. There are
> many boards like it, so this will encourage people
> to move to the powerpc which with a reference much more simple than
> fix ppc/ irq stuff.
>
> So, as a recap physically spec is ready, just depending on QE spec
> that is floating around still :)
> And, having 85xx cpm2 stuff in the Linus' mainline atm, there's no
> much reason holding this, is there ;) ?
I agree. How about posting the lastest cpm2 spec to the list.
- k
^ permalink raw reply
* [PATCH] 750CL cputable entry
From: Jake Moilanen @ 2006-10-03 19:29 UTC (permalink / raw)
To: Paul Mackerras; +Cc: linuxppc-dev
750CL cputable entry from Steve Winiecki.
Signed-off-by: Jake Moilanen <moilanen@austin.ibm.com>
arch/powerpc/kernel/cputable.c | 12 ++++++++++++
1 files changed, 12 insertions(+)
Index: merge/arch/powerpc/kernel/cputable.c
===================================================================
--- merge.orig/arch/powerpc/kernel/cputable.c
+++ merge/arch/powerpc/kernel/cputable.c
@@ -466,6 +466,18 @@ struct cpu_spec cpu_specs[] = {
.cpu_setup = __setup_cpu_750cx,
.platform = "ppc750",
},
+ { /* 750CL */
+ .pvr_mask = 0xfffffff0,
+ .pvr_value = 0x00087100,
+ .cpu_name = "750CL",
+ .cpu_features = CPU_FTRS_750,
+ .cpu_user_features = COMMON_USER | PPC_FEATURE_PPC_LE,
+ .icache_bsize = 32,
+ .dcache_bsize = 32,
+ .num_pmcs = 4,
+ .cpu_setup = __setup_cpu_750cx,
+ .platform = "ppc750",
+ },
{ /* 745/755 */
.pvr_mask = 0xfffff000,
.pvr_value = 0x00083000,
^ permalink raw reply
* Re: Please pull upstream branch of linux-2.6-PQ.git...
From: Jerry Van Baren @ 2006-10-03 19:37 UTC (permalink / raw)
To: Vitaly Bordug; +Cc: linuxppc-dev@ozlabs.org
In-Reply-To: <20061003223054.06e25136@localhost.localdomain>
Vitaly Bordug wrote:
> Paul,
>
> Please do a pull from
>
> git://git.kernel.org/pub/scm/linux/kernel/git/vitb/linux-2.6-PQ.git, upstream branch.
>
> Signed-off-by: Vitaly Bordug <vbordug@ru.mvista.com>
>
>
> To receive the updated 8272 addition to the arch/powerpc.
> All the comments have been addressed, and it has a minor bugfix addressed too in order to make both pq2 and pq3
> co-exist happily in fsl_soc.c. CPM PIC now has "compatible" property that could be "CPM2" or "CPM1" for PQ/8xx.
>
> I think it should go to rc1, because relevant stuff in ppc/ is more or less broken now, with new irq engine.
Hi Vitaly,
I've been following your -PQ progress with a lot of interest. I have a
PQ2FADS board (8272) and your changes should apply to it too. I pulled
a copy of your repository last week and had a couple of minor build
errors. I made a couple of minor fixes and it built OK but I didn't run
it - I need a compatible boot loader, which leads into my question...
What are you using for booting your 8272ADS board? I have been using
u-boot with the "bd" structure but am looking to switch to the flattened
OF tree. I made a half-hearted attempt to switch my u-boot build to the
flattened OF tree but it didn't work and then I got distracted by other
things instead of debugging it. :-(
Thanks,
gvb
^ permalink raw reply
* [PATCH 0/4]: Spidernet transmit patches
From: Linas Vepstas @ 2006-10-03 20:52 UTC (permalink / raw)
To: akpm, jeff
Cc: netdev, James K Lewis, linux-kernel, Arnd Bergmann, linuxppc-dev
The following set of four patches provide some more spidernet fixes.
Most important are a pair of patches to stop the transmit queue when it
is full, and to actually turn off transmit interrupts during NAPI(!)
Signed-off-by: Linas Vepstas <linas@austin.ibm.com>
Cc: James K Lewis <jklewis@us.ibm.com>
Cc: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply
* [PATCH 1/4]: Spidernet stop queue when queue is full
From: Linas Vepstas @ 2006-10-03 20:57 UTC (permalink / raw)
To: akpm, jeff
Cc: netdev, James K Lewis, linux-kernel, Arnd Bergmann, linuxppc-dev
In-Reply-To: <20061003205240.GE4381@austin.ibm.com>
Subject: [PATCH 1/4]: Spidernet stop queue when queue is full.
This patch adds a call to netif_stop_queue() when there is
no more room for more packets on the transmit queue.
Signed-off-by: Linas Vepstas <linas@austin.ibm.com>
Cc: James K Lewis <jklewis@us.ibm.com>
Cc: Arnd Bergmann <arnd@arndb.de>
----
drivers/net/spider_net.c | 19 ++++++++-----------
1 file changed, 8 insertions(+), 11 deletions(-)
Index: linux-2.6.18-mm2/drivers/net/spider_net.c
===================================================================
--- linux-2.6.18-mm2.orig/drivers/net/spider_net.c 2006-10-02 12:12:56.000000000 -0500
+++ linux-2.6.18-mm2/drivers/net/spider_net.c 2006-10-02 18:59:43.000000000 -0500
@@ -686,6 +686,7 @@ spider_net_prepare_tx_descr(struct spide
/* Chain the bus address, so that the DMA engine finds this descr. */
descr->prev->next_descr_addr = descr->bus_addr;
+ card->netdev->trans_start = jiffies;
return 0;
}
@@ -857,29 +858,23 @@ spider_net_xmit(struct sk_buff *skb, str
spider_net_release_tx_chain(card, 0);
- if (chain->head->next == chain->tail->prev) {
- card->netdev_stats.tx_dropped++;
- result = NETDEV_TX_LOCKED;
- goto out;
- }
-
- if (spider_net_get_descr_status(descr) != SPIDER_NET_DESCR_NOT_IN_USE) {
- card->netdev_stats.tx_dropped++;
+ if ((chain->head->next == chain->tail->prev) ||
+ (spider_net_get_descr_status(descr) != SPIDER_NET_DESCR_NOT_IN_USE)) {
result = NETDEV_TX_LOCKED;
goto out;
}
if (spider_net_prepare_tx_descr(card, skb) != 0) {
- card->netdev_stats.tx_dropped++;
result = NETDEV_TX_BUSY;
goto out;
}
- result = NETDEV_TX_OK;
spider_net_kick_tx_dma(card);
+ return NETDEV_TX_OK;
out:
- netif_wake_queue(netdev);
+ card->netdev_stats.tx_dropped++;
+ netif_stop_queue(netdev);
return result;
}
@@ -898,6 +893,8 @@ spider_net_cleanup_tx_ring(struct spider
if ((spider_net_release_tx_chain(card, 0) != 0) &&
(card->netdev->flags & IFF_UP))
spider_net_kick_tx_dma(card);
+
+ netif_wake_queue(card->netdev);
}
/**
^ permalink raw reply
* Re: Undefined '.bus_to_virt', '.virt_to_bus' causes compile error on Powerpc 64-bit
From: Guennadi Liakhovetski @ 2006-10-03 20:58 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linuxppc-dev, Judith Lebzelter, linux-kernel
In-Reply-To: <20061002234428.GE3278@stusta.de>
On Tue, 3 Oct 2006, Adrian Bunk wrote:
> On Mon, Oct 02, 2006 at 02:49:54PM -0700, Judith Lebzelter wrote:
>
> > For the automated cross-compile builds at OSDL, powerpc 64-bit
> > 'allmodconfig' is failing. The warnings/errors below appear in
> > the 'modpost' stage of kernel compiles for 2.6.18 and -mm2 kernels.
>
> known for ages - the drivers need fixing.
...
> > WARNING: ".bus_to_virt" [drivers/scsi/tmscsim.ko] undefined!
The problem with this one is that the code path, where bus_to_virt is
used, is only executed under some very exotic circumstances, i.e.,
is practically untestable. I'll try to cook something up for that...
Thanks
Guennadi
---
Guennadi Liakhovetski
^ permalink raw reply
* [PATCH 2/4]: Spidernet fix register field definitions
From: Linas Vepstas @ 2006-10-03 20:59 UTC (permalink / raw)
To: akpm, jeff
Cc: netdev, James K Lewis, linux-kernel, Arnd Bergmann, linuxppc-dev
In-Reply-To: <20061003205240.GE4381@austin.ibm.com>
This patch fixes the names of a few fields in the DMA control
register. There is no functional change.
Signed-off-by: Linas Vepstas <linas@austin.ibm.com>
Cc: James K Lewis <jklewis@us.ibm.com>
Cc: Arnd Bergmann <arnd@arndb.de>
----
drivers/net/spider_net.c | 2 +-
drivers/net/spider_net.h | 14 +++++++++-----
2 files changed, 10 insertions(+), 6 deletions(-)
Index: linux-2.6.18-mm2/drivers/net/spider_net.c
===================================================================
--- linux-2.6.18-mm2.orig/drivers/net/spider_net.c 2006-10-02 18:59:43.000000000 -0500
+++ linux-2.6.18-mm2/drivers/net/spider_net.c 2006-10-02 19:06:55.000000000 -0500
@@ -1639,7 +1639,7 @@ spider_net_enable_card(struct spider_net
SPIDER_NET_INT2_MASK_VALUE);
spider_net_write_reg(card, SPIDER_NET_GDTDMACCNTR,
- SPIDER_NET_GDTDCEIDIS);
+ SPIDER_NET_GDTBSTA);
}
/**
Index: linux-2.6.18-mm2/drivers/net/spider_net.h
===================================================================
--- linux-2.6.18-mm2.orig/drivers/net/spider_net.h 2006-10-02 18:58:11.000000000 -0500
+++ linux-2.6.18-mm2/drivers/net/spider_net.h 2006-10-02 19:06:55.000000000 -0500
@@ -191,7 +191,9 @@ extern char spider_net_driver_name[];
#define SPIDER_NET_MACMODE_VALUE 0x00000001
#define SPIDER_NET_BURSTLMT_VALUE 0x00000200 /* about 16 us */
-/* 1(0) enable r/tx dma
+/* DMAC control register GDMACCNTR
+ *
+ * 1(0) enable r/tx dma
* 0000000 fixed to 0
*
* 000000 fixed to 0
@@ -200,6 +202,7 @@ extern char spider_net_driver_name[];
*
* 000000 fixed to 0
* 00 burst alignment: 128 bytes
+ * 11 burst alignment: 1024 bytes
*
* 00000 fixed to 0
* 0 descr writeback size 32 bytes
@@ -210,10 +213,11 @@ extern char spider_net_driver_name[];
#define SPIDER_NET_DMA_RX_VALUE 0x80000000
#define SPIDER_NET_DMA_RX_FEND_VALUE 0x00030003
/* to set TX_DMA_EN */
-#define SPIDER_NET_TX_DMA_EN 0x80000000
-#define SPIDER_NET_GDTDCEIDIS 0x00000300
-#define SPIDER_NET_DMA_TX_VALUE SPIDER_NET_TX_DMA_EN | \
- SPIDER_NET_GDTDCEIDIS
+#define SPIDER_NET_TX_DMA_EN 0x80000000
+#define SPIDER_NET_GDTBSTA 0x00000300
+#define SPIDER_NET_GDTDCEIDIS 0x00000002
+#define SPIDER_NET_DMA_TX_VALUE SPIDER_NET_TX_DMA_EN | \
+ SPIDER_NET_GDTBSTA
#define SPIDER_NET_DMA_TX_FEND_VALUE 0x00030003
/* SPIDER_NET_UA_DESCR_VALUE is OR'ed with the unicast address */
^ permalink raw reply
* [PATCH 3/4]: Spidernet transmit interupt mitigation
From: Linas Vepstas @ 2006-10-03 21:03 UTC (permalink / raw)
To: akpm, jeff
Cc: netdev, James K Lewis, linux-kernel, Arnd Bergmann, linuxppc-dev
In-Reply-To: <20061003205240.GE4381@austin.ibm.com>
For small packets, the transmit interrupt settings were
accidentally generating too many interrupts. This patch
turns off all transmit-related interrupts when the tx
queue is mostly empty.
Signed-off-by: Linas Vepstas <linas@austin.ibm.com>
Cc: James K Lewis <jklewis@us.ibm.com>
Cc: Arnd Bergmann <arnd@arndb.de>
----
drivers/net/spider_net.c | 8 +++++---
drivers/net/spider_net.h | 7 +++----
2 files changed, 8 insertions(+), 7 deletions(-)
Index: linux-2.6.18-mm2/drivers/net/spider_net.c
===================================================================
--- linux-2.6.18-mm2.orig/drivers/net/spider_net.c 2006-10-02 19:06:55.000000000 -0500
+++ linux-2.6.18-mm2/drivers/net/spider_net.c 2006-10-02 19:09:38.000000000 -0500
@@ -707,7 +707,9 @@ spider_net_set_low_watermark(struct spid
descr = descr->next;
cnt++;
}
- if (cnt == 0)
+
+ /* If TX queue is short, don't even bother with interrupts */
+ if (cnt < tx_descriptors/4)
return;
/* Set low-watermark 3/4th's of the way into the queue. */
@@ -716,7 +718,7 @@ spider_net_set_low_watermark(struct spid
for (i=0;i<cnt; i++)
descr = descr->next;
- /* Set the new watermark, clear the old wtermark */
+ /* Set the new watermark, clear the old watermark */
spin_lock_irqsave(&card->tx_chain.lock, flags);
descr->dmac_cmd_status |= SPIDER_NET_DESCR_TXDESFLG;
if (card->low_watermark && card->low_watermark != descr)
@@ -1639,7 +1641,7 @@ spider_net_enable_card(struct spider_net
SPIDER_NET_INT2_MASK_VALUE);
spider_net_write_reg(card, SPIDER_NET_GDTDMACCNTR,
- SPIDER_NET_GDTBSTA);
+ SPIDER_NET_GDTBSTA | SPIDER_NET_GDTDCEIDIS);
}
/**
Index: linux-2.6.18-mm2/drivers/net/spider_net.h
===================================================================
--- linux-2.6.18-mm2.orig/drivers/net/spider_net.h 2006-10-02 19:06:55.000000000 -0500
+++ linux-2.6.18-mm2/drivers/net/spider_net.h 2006-10-02 19:09:38.000000000 -0500
@@ -217,7 +217,8 @@ extern char spider_net_driver_name[];
#define SPIDER_NET_GDTBSTA 0x00000300
#define SPIDER_NET_GDTDCEIDIS 0x00000002
#define SPIDER_NET_DMA_TX_VALUE SPIDER_NET_TX_DMA_EN | \
- SPIDER_NET_GDTBSTA
+ SPIDER_NET_GDTBSTA | \
+ SPIDER_NET_GDTDCEIDIS
#define SPIDER_NET_DMA_TX_FEND_VALUE 0x00030003
/* SPIDER_NET_UA_DESCR_VALUE is OR'ed with the unicast address */
@@ -326,9 +327,7 @@ enum spider_net_int2_status {
SPIDER_NET_GRISPDNGINT
};
-#define SPIDER_NET_TXINT ( (1 << SPIDER_NET_GTTEDINT) | \
- (1 << SPIDER_NET_GDTDCEINT) | \
- (1 << SPIDER_NET_GDTFDCINT) )
+#define SPIDER_NET_TXINT ( (1 << SPIDER_NET_GDTFDCINT) )
/* we rely on flagged descriptor interrupts*/
#define SPIDER_NET_RXINT ( (1 << SPIDER_NET_GDAFDCINT) | \
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox