* Re: [PATCH 4/6 v2] powerpc/qe: update QE Serial Number
From: Kumar Gala @ 2009-05-01 22:03 UTC (permalink / raw)
To: Haiying Wang; +Cc: linuxppc-dev
In-Reply-To: <1241206851-27749-2-git-send-email-Haiying.Wang@freescale.com>
On May 1, 2009, at 2:40 PM, Haiying Wang wrote:
> The latest QE chip may have more Serial Number(SNUM)s of thread to
> use. We will
> get the number of SNUMs from device tree by reading the new property
> "fsl,qe-num-snums", and set 28 as the default number of SNUMs so
> that it is
> compatible with the old QE chips' device trees which don't have this
> new
> property. The macro QE_NUM_OF_SNUM is defined as the maximum number
> in QE snum
> table which is 256.
> Also we update the snum_init[] array with 18 more new SNUMs which are
> confirmed to be useful on new chip.
>
> Signed-off-by: Haiying Wang <Haiying.Wang@freescale.com>
> ---
> v2 change: rename the new property as "fsl,qe-num-snums" and move it
> to Required
> section in qe.txt
> .../powerpc/dts-bindings/fsl/cpm_qe/qe.txt | 2 +
> arch/powerpc/include/asm/qe.h | 3 +-
> arch/powerpc/sysdev/qe_lib/qe.c | 47 +++++++++++
> +++++++--
> 3 files changed, 47 insertions(+), 5 deletions(-)
applied
- k
^ permalink raw reply
* Re: [PATCH] powerpc/85xx: add new qe properties for QE based chips
From: Kumar Gala @ 2009-05-01 22:04 UTC (permalink / raw)
To: Haiying Wang; +Cc: linuxppc-dev
In-Reply-To: <1241206851-27749-5-git-send-email-Haiying.Wang@freescale.com>
On May 1, 2009, at 2:40 PM, Haiying Wang wrote:
> Add fsl,qe-num-riscs and fsl,qe-num-snums to all the devices trees
> which have qe
> node.
>
> Signed-off-by: Haiying Wang <Haiying.Wang@freescale.com>
> ---
> arch/powerpc/boot/dts/mpc832x_mds.dts | 2 ++
> arch/powerpc/boot/dts/mpc832x_rdb.dts | 2 ++
> arch/powerpc/boot/dts/mpc836x_mds.dts | 2 ++
> arch/powerpc/boot/dts/mpc836x_rdk.dts | 2 ++
> arch/powerpc/boot/dts/mpc8568mds.dts | 2 ++
> 5 files changed, 10 insertions(+), 0 deletions(-)
applied to next
- k
^ permalink raw reply
* Re: [PATCH 5/6 v2] net/ucc_geth: Assign six threads to Rx for UEC
From: Kumar Gala @ 2009-05-01 22:12 UTC (permalink / raw)
To: Haiying Wang; +Cc: linuxppc-dev
In-Reply-To: <1241206851-27749-3-git-send-email-Haiying.Wang@freescale.com>
On May 1, 2009, at 2:40 PM, Haiying Wang wrote:
> in the case the QE has 46 SNUMs for the threads to support four UCC
> Ethernet at
> 1000Base-T simultaneously.
>
> Signed-off-by: Haiying Wang <Haiying.Wang@freescale.com>
> ---
> v2 change: Add comments for the Rx threads change.
> drivers/net/ucc_geth.c | 10 +++++++++-
> 1 files changed, 9 insertions(+), 1 deletions(-)
applied to next
- k
^ permalink raw reply
* Re: [PATCH 6/6 v2] powerpc/85xx: Add MPC8569MDS board support
From: Kumar Gala @ 2009-05-01 22:12 UTC (permalink / raw)
To: Haiying Wang; +Cc: linuxppc-dev
In-Reply-To: <1241206851-27749-4-git-send-email-Haiying.Wang@freescale.com>
On May 1, 2009, at 2:40 PM, Haiying Wang wrote:
> Signed-off-by: Haiying Wang <Haiying.Wang@freescale.com>
> ---
> v2 change: rename "num-riscs" to "fsl,qe-num-riscs", and "num-snums"
> to
> "fsl,qe-num-snums".
>
> arch/powerpc/boot/dts/mpc8569mds.dts | 514 ++++++++++++++++++++
> +++++++++
> arch/powerpc/platforms/85xx/mpc85xx_mds.c | 23 ++
> 2 files changed, 537 insertions(+), 0 deletions(-)
> create mode 100644 arch/powerpc/boot/dts/mpc8569mds.dts
applied to next
- k
^ permalink raw reply
* Re: [PATCH v2 1/6] Add new macros for page-aligned data and bss sections.
From: Andreas Schwab @ 2009-05-01 23:02 UTC (permalink / raw)
To: H. Peter Anvin
Cc: linux-mips, linux-m68k, linux-ia64, linux-sh, Denys Vlasenko,
Tim Abbott, Heiko Carstens, linuxppc-dev, Waseem, Paul Mackerras,
Greg Ungerer, sparclinux, Sam Ravnborg, Bryan Wu, linux-s390,
Jesper Nilsson, Yoshinori Sato, David S. Miller, Helge Deller,
Ingo Molnar, Geert Uytterhoeven, Russell King,
user-mode-linux-devel, microblaze-uclinux, Jeff Dike, Jeff Arnold,
Michal Simek, Mikael Starvik, Cyrill Gorcunov, Thomas Gleixner,
Daher, Richard Henderson, Chris Zankel, dev-etrax, Tony Luck,
Haavard Skinnemoen, linux-parisc, Linux kernel mailing list,
Ralf Baechle, Anders Kaseorg, Kyle McMartin, Paul Mundt,
linux-alpha, Martin Schwidefsky, uclinux-dist-devel,
Linus Torvalds, Hirokazu Takata
In-Reply-To: <49FB35C4.6060107@zytor.com>
"H. Peter Anvin" <hpa@zytor.com> writes:
> Sam Ravnborg wrote:
>>>
>>> What's wrong with @?
>> arm does not support it :-(
>> I recall it denote a comment in arm assembler.
>>
>> I could do some magic to detect the ARM case but I'm reluctant to do so.
>> I could also ignore the arm issue for now as it is not used by arm,
>> but that strikes me as the wrong approach.
>>
>
> If we really have to use different tokens, I would say:
>
> #ifdef __ARM__
> # define _PROGBITS %progbits /* or whatever */
> # define _NOBITS %nobits
> #else
> # define _PROGBITS @progbits
> # define _NOBITS @nobits
> #endif
GAS has always supported both '@' and '%', so '%' can be used
everywhere.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply
* Re: [PATCH 1/2] Added support for Designware SATA controller driver
From: Wolfgang Denk @ 2009-05-01 23:20 UTC (permalink / raw)
To: Feng Kan; +Cc: Mark Miesfeld, linuxppc-dev, linux-ide
In-Reply-To: <1241211767-32697-1-git-send-email-fkan@amcc.com>
Dear Feng Kan,
In message <1241211767-32697-1-git-send-email-fkan@amcc.com> you wrote:
> This adds support for the Designware SATA controller.
>
> Signed-off-by: Feng Kan <fkan@amcc.com>
> Signed-off-by: Mark Miesfeld <miesfeld@gmail.com>
> ---
> drivers/ata/Kconfig | 10 +
> drivers/ata/Makefile | 1 +
> drivers/ata/sata_dwc.c | 2053 ++++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 2064 insertions(+), 0 deletions(-)
> create mode 100644 drivers/ata/sata_dwc.c
...
> +
> +MODULE_LICENSE("GPL");
> +MODULE_AUTHOR("Mark Miesfeld <mmiesfeld@amcc.com>");
> +MODULE_DESCRIPTION("DesignWare Cores SATA controller low lever driver");
------------------------------------------------------------^^^^^
Guess that's a typo?
Hmm... that's 2000+ lines of code in a single file. Maybe this should
be split?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
On a clear disk you can seek forever.
^ permalink raw reply
* Re: [PATCH 1/2] Added support for Designware SATA controller driver
From: Jeff Garzik @ 2009-05-02 0:05 UTC (permalink / raw)
To: Wolfgang Denk; +Cc: Mark Miesfeld, linuxppc-dev, Feng Kan, linux-ide
In-Reply-To: <20090501232040.3E59283420E8@gemini.denx.de>
Wolfgang Denk wrote:
> Dear Feng Kan,
>
> In message <1241211767-32697-1-git-send-email-fkan@amcc.com> you wrote:
>> This adds support for the Designware SATA controller.
>>
>> Signed-off-by: Feng Kan <fkan@amcc.com>
>> Signed-off-by: Mark Miesfeld <miesfeld@gmail.com>
>> ---
>> drivers/ata/Kconfig | 10 +
>> drivers/ata/Makefile | 1 +
>> drivers/ata/sata_dwc.c | 2053 ++++++++++++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 2064 insertions(+), 0 deletions(-)
>> create mode 100644 drivers/ata/sata_dwc.c
>
> ...
>> +
>> +MODULE_LICENSE("GPL");
>> +MODULE_AUTHOR("Mark Miesfeld <mmiesfeld@amcc.com>");
>> +MODULE_DESCRIPTION("DesignWare Cores SATA controller low lever driver");
> ------------------------------------------------------------^^^^^
>
> Guess that's a typo?
heh
> Hmm... that's 2000+ lines of code in a single file. Maybe this should
> be split?
A single file is just fine.
Jeff
^ permalink raw reply
* [PATCH v5 0/3] Tracers vs. CALLER_ADDR on PowerPC
From: Anton Vorontsov @ 2009-05-02 0:13 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, linuxppc-dev, Steven Rostedt, Paul Mackerras,
Sam Ravnborg
Hi all,
In v5 there are few fixes suggested by Sam Ravnborg:
- Use 8 spaces for indentation in Makefile;
- Rename ARCH_HAS_NORMAL_FRAME_POINTERS to HAVE_NORMAL_FRAME_POINTER;
Thanks,
---
Preface for those who don't know or forgot what the problem is:
Gcc frame pointers do nothing useful on PowerPC (they're harmful,
actually), and thus lib/Kconfig.debug makes CONFIG_FRAME_POINTER
unselectable on PPC targets, but CALLER_ADDR macros are available
only with CONFIG_FRAME_POINTER, therefore tracing is completely
useless on PowerPC:
[...]
<idle>-0 0X.h3 2us+: 0:140:R + [000] 1733:120:S mvtsd
<idle>-0 0X.h3 9us+: 0 (0)
<idle>-0 0X..3 72us : 0 (0)
<idle>-0 0X..3 73us : 0:140:R ==> [000] 1733:120:R mvtsd
While it should look like this:
[...]
<idle>-0 0X.h3 2us+: 0:140:R + [000] 1740:120:S mvtsd
<idle>-0 0X.h3 9us+: hrtimer_wakeup (__run_hrtimer)
<idle>-0 0X..3 87us : cpu_idle (__got2_end)
<idle>-0 0X..3 89us : 0:140:R ==> [000] 1740:120:R mvtsd
I've tried to fix the issue via expanding the #ifdef in the ftrace.h:
http://lkml.org/lkml/2009/1/31/141
Then Steven Rostedt suggested to implement something more generic,
i.e. HAVE_NORMAL_FRAME_POINTERS Kconfig symbol.
I found a way to solve the problem w/o additional symbols, but
with some Makefile magic (http://lkml.org/lkml/2009/2/4/273).
But because of top-level Makefile issues on other arches
(http://lkml.org/lkml/2009/2/14/89) I had to abandon the approach.
So, this patch set combines Steven Rostedt's idea and a small
Makefile change, so that now only top-level Makefile has to know
about the new symbol, and the rest of the kernel can stay with
using CONFIG_FRAME_POINTER.
I'm aware of
commit c79a61f55773d2519fd0525bf58385f7d20752d3
Author: Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de>
Date: Fri Feb 27 21:30:03 2009 +0100
tracing: make CALLER_ADDRx overwriteable
But I think the patch set is still applicable, considering that
it removes gcc bug workaround in a nice way, and makes
CONFIG_FRAME_POINTER available on PowerPC, thus other code
can rely on that.
If not, I can just fill-in the asm/ftrace.h for PowerPC.
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
^ permalink raw reply
* [PATCH 1/3] powerpc, Makefile: Make it possible to safely select CONFIG_FRAME_POINTER
From: Anton Vorontsov @ 2009-05-02 0:14 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, linuxppc-dev, Steven Rostedt, Paul Mackerras,
Sam Ravnborg
In-Reply-To: <20090502001329.GA11549@oksana.dev.rtsoft.ru>
This patch introduces HAVE_NORMAL_FRAME_POINTER Kconfig symbol. When
defined, the top level Makefile won't add -fno-omit-frame-pointer
cflag (the flag is useless for PowerPC kernels, and also makes gcc
generate wrong code).
Also move ARCH_WANT_FRAME_POINTERS's help text.
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
Makefile | 7 +++++--
arch/powerpc/Kconfig | 1 +
lib/Kconfig.debug | 16 ++++++++++------
3 files changed, 16 insertions(+), 8 deletions(-)
diff --git a/Makefile b/Makefile
index b18afad..bfa58ea 100644
--- a/Makefile
+++ b/Makefile
@@ -543,9 +543,12 @@ KBUILD_CFLAGS += $(call cc-option, -fno-stack-protector)
endif
ifdef CONFIG_FRAME_POINTER
-KBUILD_CFLAGS += -fno-omit-frame-pointer -fno-optimize-sibling-calls
+ KBUILD_CFLAGS += -fno-optimize-sibling-calls
+ ifndef CONFIG_HAVE_NORMAL_FRAME_POINTER
+ KBUILD_CFLAGS += -fno-omit-frame-pointer
+ endif
else
-KBUILD_CFLAGS += -fomit-frame-pointer
+ KBUILD_CFLAGS += -fomit-frame-pointer
endif
ifdef CONFIG_DEBUG_INFO
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index 4c78045..b29a6c3 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -119,6 +119,7 @@ config PPC
select HAVE_KPROBES
select HAVE_ARCH_KGDB
select HAVE_KRETPROBES
+ select HAVE_NORMAL_FRAME_POINTER
select HAVE_ARCH_TRACEHOOK
select HAVE_LMB
select HAVE_DMA_ATTRS if PPC64
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 444002b..1f1633b 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -660,20 +660,24 @@ config DEBUG_NOTIFIERS
This is a relatively cheap check but if you care about maximum
performance, say N.
-#
-# Select this config option from the architecture Kconfig, if it
-# it is preferred to always offer frame pointers as a config
-# option on the architecture (regardless of KERNEL_DEBUG):
-#
config ARCH_WANT_FRAME_POINTERS
bool
help
+ Select this config option from the architecture Kconfig, if it
+ it is preferred to always offer frame pointers as a config
+ option on the architecture (regardless of KERNEL_DEBUG).
+
+config HAVE_NORMAL_FRAME_POINTER
+ bool
+ help
+ Architectures should select this symbol if their ABI implies
+ having a frame pointer.
config FRAME_POINTER
bool "Compile the kernel with frame pointers"
depends on DEBUG_KERNEL && \
(CRIS || M68K || M68KNOMMU || FRV || UML || \
- AVR32 || SUPERH || BLACKFIN || MN10300) || \
+ AVR32 || SUPERH || BLACKFIN || MN10300 || PPC) || \
ARCH_WANT_FRAME_POINTERS
default y if (DEBUG_INFO && UML) || ARCH_WANT_FRAME_POINTERS
help
--
1.6.2.2
^ permalink raw reply related
* [PATCH 2/3] powerpc: Remove -fno-omit-frame-pointer workarounds
From: Anton Vorontsov @ 2009-05-02 0:14 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, linuxppc-dev, Steven Rostedt, Paul Mackerras,
Sam Ravnborg
In-Reply-To: <20090502001329.GA11549@oksana.dev.rtsoft.ru>
The workarounds aren't needed any longer since the top level Makefile
doesn't pass -fno-omit-frame-pointer cflag for PowerPC builds.
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
arch/powerpc/Makefile | 5 -----
arch/powerpc/kernel/Makefile | 12 ++++++------
arch/powerpc/platforms/powermac/Makefile | 2 +-
lib/Kconfig.debug | 6 +++---
4 files changed, 10 insertions(+), 15 deletions(-)
diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile
index 551fc58..1dd7748 100644
--- a/arch/powerpc/Makefile
+++ b/arch/powerpc/Makefile
@@ -120,11 +120,6 @@ ifeq ($(CONFIG_6xx),y)
KBUILD_CFLAGS += -mcpu=powerpc
endif
-# Work around a gcc code-gen bug with -fno-omit-frame-pointer.
-ifeq ($(CONFIG_FUNCTION_TRACER),y)
-KBUILD_CFLAGS += -mno-sched-epilog
-endif
-
cpu-as-$(CONFIG_4xx) += -Wa,-m405
cpu-as-$(CONFIG_6xx) += -Wa,-maltivec
cpu-as-$(CONFIG_POWER4) += -Wa,-maltivec
diff --git a/arch/powerpc/kernel/Makefile b/arch/powerpc/kernel/Makefile
index 71901fb..fdbca81 100644
--- a/arch/powerpc/kernel/Makefile
+++ b/arch/powerpc/kernel/Makefile
@@ -14,14 +14,14 @@ endif
ifdef CONFIG_FUNCTION_TRACER
# Do not trace early boot code
-CFLAGS_REMOVE_cputable.o = -pg -mno-sched-epilog
-CFLAGS_REMOVE_prom_init.o = -pg -mno-sched-epilog
-CFLAGS_REMOVE_btext.o = -pg -mno-sched-epilog
-CFLAGS_REMOVE_prom.o = -pg -mno-sched-epilog
+CFLAGS_REMOVE_cputable.o = -pg
+CFLAGS_REMOVE_prom_init.o = -pg
+CFLAGS_REMOVE_btext.o = -pg
+CFLAGS_REMOVE_prom.o = -pg
# do not trace tracer code
-CFLAGS_REMOVE_ftrace.o = -pg -mno-sched-epilog
+CFLAGS_REMOVE_ftrace.o = -pg
# timers used by tracing
-CFLAGS_REMOVE_time.o = -pg -mno-sched-epilog
+CFLAGS_REMOVE_time.o = -pg
endif
obj-y := cputable.o ptrace.o syscalls.o \
diff --git a/arch/powerpc/platforms/powermac/Makefile b/arch/powerpc/platforms/powermac/Makefile
index 50f1693..0eb8781 100644
--- a/arch/powerpc/platforms/powermac/Makefile
+++ b/arch/powerpc/platforms/powermac/Makefile
@@ -2,7 +2,7 @@ CFLAGS_bootx_init.o += -fPIC
ifdef CONFIG_FUNCTION_TRACER
# Do not trace early boot code
-CFLAGS_REMOVE_bootx_init.o = -pg -mno-sched-epilog
+CFLAGS_REMOVE_bootx_init.o = -pg
endif
obj-y += pic.o setup.o time.o feature.o pci.o \
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 1f1633b..cffbfc4 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -492,7 +492,7 @@ config LOCKDEP
bool
depends on DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT
select STACKTRACE
- select FRAME_POINTER if !X86 && !MIPS && !PPC && !ARM_UNWIND && !S390
+ select FRAME_POINTER if !X86 && !MIPS && !ARM_UNWIND && !S390
select KALLSYMS
select KALLSYMS_ALL
@@ -865,13 +865,13 @@ config FAULT_INJECTION_STACKTRACE_FILTER
depends on FAULT_INJECTION_DEBUG_FS && STACKTRACE_SUPPORT
depends on !X86_64
select STACKTRACE
- select FRAME_POINTER if !PPC && !S390
+ select FRAME_POINTER if !S390
help
Provide stacktrace filter for fault-injection capabilities
config LATENCYTOP
bool "Latency measuring infrastructure"
- select FRAME_POINTER if !MIPS && !PPC && !S390
+ select FRAME_POINTER if !MIPS && !S390
select KALLSYMS
select KALLSYMS_ALL
select STACKTRACE
--
1.6.2.2
^ permalink raw reply related
* [PATCH 3/3] tracing: Tracers that use CALLER_ADDR macros should select FRAME_POINTER
From: Anton Vorontsov @ 2009-05-02 0:14 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, linuxppc-dev, Steven Rostedt, Paul Mackerras,
Sam Ravnborg
In-Reply-To: <20090502001329.GA11549@oksana.dev.rtsoft.ru>
Irqsoff, switch and preempt tracers use CALLER_ADDR macros, so they
should select FRAME_POINTER. Otherwise traces are meaningless.
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
kernel/trace/Kconfig | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index 450d3c2..ad44791 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -122,6 +122,7 @@ config IRQSOFF_TRACER
select TRACE_IRQFLAGS
select TRACING
select TRACER_MAX_TRACE
+ select FRAME_POINTER
help
This option measures the time spent in irqs-off critical
sections, with microsecond accuracy.
@@ -143,6 +144,7 @@ config PREEMPT_TRACER
depends on PREEMPT
select TRACING
select TRACER_MAX_TRACE
+ select FRAME_POINTER
help
This option measures the time spent in preemption off critical
sections, with microsecond accuracy.
@@ -171,6 +173,7 @@ config SCHED_TRACER
select TRACING
select CONTEXT_SWITCH_TRACER
select TRACER_MAX_TRACE
+ select FRAME_POINTER
help
This tracer tracks the latency of the highest priority task
to be scheduled in, starting from the point it has woken up.
--
1.6.2.2
^ permalink raw reply related
* Re: [PATCH 1/3] powerpc, Makefile: Make it possible to safely select CONFIG_FRAME_POINTER
From: Anton Vorontsov @ 2009-05-02 0:14 UTC (permalink / raw)
To: Sam Ravnborg
Cc: linux-kernel, linuxppc-dev, Steven Rostedt, Paul Mackerras,
Ingo Molnar
In-Reply-To: <20090405210756.GG24374@uranus.ravnborg.org>
On Sun, Apr 05, 2009 at 11:07:56PM +0200, Sam Ravnborg wrote:
> On Fri, Mar 20, 2009 at 07:44:29PM +0300, Anton Vorontsov wrote:
> > This patch introduces ARCH_HAS_NORMAL_FRAME_POINTERS Kconfig symbol.
> > When defined, the top level Makefile won't add -fno-omit-frame-pointer
> > cflag (the flag is useless in PowerPC kernels, and also makes gcc
> > generate wrong code).
> >
> > Also move ARCH_WANT_FRAME_POINTERS's help text.
> >
> > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
>
> Hi Anton - sorry for the late feedback.
>
> 1) The preferred naming for variables that are supposed to be selcted
> are "HAVE_xxxx".
> So in this case it would be:
> HAVE_NORMAL_FRAME_POINTER
OK, will rename.
> 2) I do not really understand the interpretation of normal in this case,
> can it be more specific?
Normal means that architecture's ABI implies having a framepointer,
we don't need any gcc flags.
I'm not sure if we can name it any better, that is what was
suggested by Steven and I don't have any better variant. ;-)
> Looking at your patch then if specified we use "-fomit-frame-pointer"
> in the case where it is set.
No. We specify neither -fomit-frame-pointer, nor we specify
-fno-omit-frame-pointer (because that flag causes gcc to generate
wrong code).
> So I read it like:
>
> If arch has normal framepointer then we omit them - strange?
>
> 3) Indent in top-level MAkefile for new stuff is generally 8 spaces.
> Do NOT use tabs as this would confuse make and rener assignmnet non-functional.
>
> 4) The individual "HAVE_* members should be sorted alphabetically in the arch
> Kconfig file (which they seldomly are :-( )
>
> Sam
Well, yes. So looking into the Kconfig, I'm quite unsure where
to put it to make it alphabetically correct. Ok, let's put
it after K. ;-)
Thanks!
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
^ permalink raw reply
* [PATCH 0/6] Some fixes and enhancements for MPC8569E-MDS boards
From: Anton Vorontsov @ 2009-05-02 2:16 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev, Haiying Wang
Hi all,
Here are few fixes and improvements for MPC8569E-MDS boards.
Thanks,
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
^ permalink raw reply
* [PATCH 1/6] powerpc/85xx: Add PCI IDs for MPC8569 family processors
From: Anton Vorontsov @ 2009-05-02 2:16 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev, Haiying Wang
In-Reply-To: <20090502021611.GA17570@oksana.dev.rtsoft.ru>
This patch adds PCI IDs for MPC8569 and MPC8569E processors,
plus adds appropriate quirks for these IDs, and thus makes
PCI-E actually work on MPC8569E-MDS boards.
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
arch/powerpc/sysdev/fsl_pci.c | 2 ++
include/linux/pci_ids.h | 2 ++
2 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/sysdev/fsl_pci.c b/arch/powerpc/sysdev/fsl_pci.c
index 376603d..94d8b3f 100644
--- a/arch/powerpc/sysdev/fsl_pci.c
+++ b/arch/powerpc/sysdev/fsl_pci.c
@@ -285,6 +285,8 @@ DECLARE_PCI_FIXUP_HEADER(0x1957, PCI_DEVICE_ID_MPC8543, quirk_fsl_pcie_header);
DECLARE_PCI_FIXUP_HEADER(0x1957, PCI_DEVICE_ID_MPC8547E, quirk_fsl_pcie_header);
DECLARE_PCI_FIXUP_HEADER(0x1957, PCI_DEVICE_ID_MPC8545E, quirk_fsl_pcie_header);
DECLARE_PCI_FIXUP_HEADER(0x1957, PCI_DEVICE_ID_MPC8545, quirk_fsl_pcie_header);
+DECLARE_PCI_FIXUP_HEADER(0x1957, PCI_DEVICE_ID_MPC8569E, quirk_fsl_pcie_header);
+DECLARE_PCI_FIXUP_HEADER(0x1957, PCI_DEVICE_ID_MPC8569, quirk_fsl_pcie_header);
DECLARE_PCI_FIXUP_HEADER(0x1957, PCI_DEVICE_ID_MPC8568E, quirk_fsl_pcie_header);
DECLARE_PCI_FIXUP_HEADER(0x1957, PCI_DEVICE_ID_MPC8568, quirk_fsl_pcie_header);
DECLARE_PCI_FIXUP_HEADER(0x1957, PCI_DEVICE_ID_MPC8567E, quirk_fsl_pcie_header);
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index 06ba90c..7cc5b80 100644
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -2274,6 +2274,8 @@
#define PCI_DEVICE_ID_MPC8547E 0x0018
#define PCI_DEVICE_ID_MPC8545E 0x0019
#define PCI_DEVICE_ID_MPC8545 0x001a
+#define PCI_DEVICE_ID_MPC8569E 0x0061
+#define PCI_DEVICE_ID_MPC8569 0x0060
#define PCI_DEVICE_ID_MPC8568E 0x0020
#define PCI_DEVICE_ID_MPC8568 0x0021
#define PCI_DEVICE_ID_MPC8567E 0x0022
--
1.6.2.2
^ permalink raw reply related
* [PATCH 2/6] powerpc/85xx: Fix mpc8569emds' crypto node to include SNOW unit
From: Anton Vorontsov @ 2009-05-02 2:16 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev, Haiying Wang
In-Reply-To: <20090502021611.GA17570@oksana.dev.rtsoft.ru>
fsl,exec-units-mask should be 0xbfe to include SNOW unit in
MPC8569E's security engine.
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
arch/powerpc/boot/dts/mpc8569mds.dts | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/boot/dts/mpc8569mds.dts b/arch/powerpc/boot/dts/mpc8569mds.dts
index e16a5d4..bcf8042 100644
--- a/arch/powerpc/boot/dts/mpc8569mds.dts
+++ b/arch/powerpc/boot/dts/mpc8569mds.dts
@@ -222,7 +222,7 @@
interrupt-parent = <&mpic>;
fsl,num-channels = <4>;
fsl,channel-fifo-len = <24>;
- fsl,exec-units-mask = <0x9fe>;
+ fsl,exec-units-mask = <0xbfe>;
fsl,descriptor-types-mask = <0x3ab0ebf>;
};
--
1.6.2.2
^ permalink raw reply related
* [PATCH 3/6] powerpc/85xx: Fix reg and interrupts for mpc8569emds' localbus, add NAND
From: Anton Vorontsov @ 2009-05-02 2:16 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev, Haiying Wang
In-Reply-To: <20090502021611.GA17570@oksana.dev.rtsoft.ru>
This patch fixes bogus reg = <> property in the localbus node,
and fixes interrupt property (should be "interrupts").
Also add node for NAND support.
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
arch/powerpc/boot/dts/mpc8569mds.dts | 11 +++++++++--
1 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/boot/dts/mpc8569mds.dts b/arch/powerpc/boot/dts/mpc8569mds.dts
index bcf8042..ede515e 100644
--- a/arch/powerpc/boot/dts/mpc8569mds.dts
+++ b/arch/powerpc/boot/dts/mpc8569mds.dts
@@ -53,13 +53,14 @@
#address-cells = <2>;
#size-cells = <1>;
compatible = "fsl,mpc8569-elbc", "fsl,elbc", "simple-bus";
- reg = <0 0xe0005000 0 0x1000>;
- interrupt = <19 2>;
+ reg = <0xe0005000 0x1000>;
+ interrupts = <19 2>;
interrupt-parent = <&mpic>;
ranges = <0x0 0x0 0xfe000000 0x02000000
0x1 0x0 0xf8000000 0x00008000
0x2 0x0 0xf0000000 0x04000000
+ 0x3 0x0 0xfc000000 0x00008000
0x4 0x0 0xf8008000 0x00008000
0x5 0x0 0xf8010000 0x00008000>;
@@ -77,6 +78,12 @@
reg = <1 0 0x8000>;
};
+ nand@3,0 {
+ compatible = "fsl,mpc8569-fcm-nand",
+ "fsl,elbc-fcm-nand";
+ reg = <3 0 0x8000>;
+ };
+
pib@4,0 {
compatible = "fsl,mpc8569mds-pib";
reg = <4 0 0x8000>;
--
1.6.2.2
^ permalink raw reply related
* [PATCH 4/6] powerpc/85xx: Add eSDHC support for MPC8569E-MDS boards
From: Anton Vorontsov @ 2009-05-02 2:16 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev, Haiying Wang
In-Reply-To: <20090502021611.GA17570@oksana.dev.rtsoft.ru>
Note that eSDHC and DUART0 are mutually exclusive on MPC8569E-MDS
boards. Default option is DUART0, so eSDHC is disabled by default.
U-Boot will fixup device tree if eSDHC should be used instead of
DUART0.
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
arch/powerpc/boot/dts/mpc8569mds.dts | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/boot/dts/mpc8569mds.dts b/arch/powerpc/boot/dts/mpc8569mds.dts
index ede515e..14120d7 100644
--- a/arch/powerpc/boot/dts/mpc8569mds.dts
+++ b/arch/powerpc/boot/dts/mpc8569mds.dts
@@ -221,6 +221,16 @@
};
};
+ sdhci@2e000 {
+ compatible = "fsl,mpc8569-esdhc", "fsl,mpc8536-esdhc";
+ reg = <0x2e000 0x1000>;
+ interrupts = <72 0x8>;
+ interrupt-parent = <&mpic>;
+ /* Filled in by U-Boot */
+ clock-frequency = <0>;
+ status = "disabled";
+ };
+
crypto@30000 {
compatible = "fsl,sec3.1", "fsl,sec3.0", "fsl,sec2.4",
"fsl,sec2.2", "fsl,sec2.1", "fsl,sec2.0";
--
1.6.2.2
^ permalink raw reply related
* [PATCH 5/6] powerpc/85xx: Enable Serial RapidIO for MPC85xx MDS boards
From: Anton Vorontsov @ 2009-05-02 2:16 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev, Haiying Wang
In-Reply-To: <20090502021611.GA17570@oksana.dev.rtsoft.ru>
Select HAS_RAPIDIO symbol and add rio nodes for MPC8568E-MDS
and MPC8569E-MDS boards.
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
arch/powerpc/boot/dts/mpc8568mds.dts | 17 +++++++++++++++++
arch/powerpc/boot/dts/mpc8569mds.dts | 17 +++++++++++++++++
arch/powerpc/platforms/85xx/Kconfig | 1 +
3 files changed, 35 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/boot/dts/mpc8568mds.dts b/arch/powerpc/boot/dts/mpc8568mds.dts
index fcab168..473fce6 100644
--- a/arch/powerpc/boot/dts/mpc8568mds.dts
+++ b/arch/powerpc/boot/dts/mpc8568mds.dts
@@ -26,6 +26,7 @@
serial1 = &serial1;
pci0 = &pci0;
pci1 = &pci1;
+ rapidio0 = &rio0;
};
cpus {
@@ -539,4 +540,20 @@
0x0 0x800000>;
};
};
+
+ rio0: rapidio@e00c00000 {
+ #address-cells = <2>;
+ #size-cells = <2>;
+ compatible = "fsl,mpc8568-rapidio", "fsl,rapidio-delta";
+ reg = <0xe00c0000 0x20000>;
+ ranges = <0x0 0x0 0xc0000000 0x0 0x20000000>;
+ interrupts = <48 2 /* error */
+ 49 2 /* bell_outb */
+ 50 2 /* bell_inb */
+ 53 2 /* msg1_tx */
+ 54 2 /* msg1_rx */
+ 55 2 /* msg2_tx */
+ 56 2 /* msg2_rx */>;
+ interrupt-parent = <&mpic>;
+ };
};
diff --git a/arch/powerpc/boot/dts/mpc8569mds.dts b/arch/powerpc/boot/dts/mpc8569mds.dts
index 14120d7..975f2c5 100644
--- a/arch/powerpc/boot/dts/mpc8569mds.dts
+++ b/arch/powerpc/boot/dts/mpc8569mds.dts
@@ -25,6 +25,7 @@
ethernet2 = &enet2;
ethernet3 = &enet3;
pci1 = &pci1;
+ rapidio0 = &rio0;
};
cpus {
@@ -528,4 +529,20 @@
0x0 0x800000>;
};
};
+
+ rio0: rapidio@e00c00000 {
+ #address-cells = <2>;
+ #size-cells = <2>;
+ compatible = "fsl,mpc8569-rapidio", "fsl,rapidio-delta";
+ reg = <0xe00c0000 0x20000>;
+ ranges = <0x0 0x0 0xc0000000 0x0 0x20000000>;
+ interrupts = <48 2 /* error */
+ 49 2 /* bell_outb */
+ 50 2 /* bell_inb */
+ 53 2 /* msg1_tx */
+ 54 2 /* msg1_rx */
+ 55 2 /* msg2_tx */
+ 56 2 /* msg2_rx */>;
+ interrupt-parent = <&mpic>;
+ };
};
diff --git a/arch/powerpc/platforms/85xx/Kconfig b/arch/powerpc/platforms/85xx/Kconfig
index 7f066ad..43d385c 100644
--- a/arch/powerpc/platforms/85xx/Kconfig
+++ b/arch/powerpc/platforms/85xx/Kconfig
@@ -34,6 +34,7 @@ config MPC85xx_MDS
bool "Freescale MPC85xx MDS"
select DEFAULT_UIMAGE
select PHYLIB
+ select HAS_RAPIDIO
help
This option enables support for the MPC85xx MDS board
--
1.6.2.2
^ permalink raw reply related
* [PATCH 6/6] powerpc/85xx: Add STMicro M25P40 serial flash support for MPC8569E-MDS
From: Anton Vorontsov @ 2009-05-02 2:16 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev, Haiying Wang
In-Reply-To: <20090502021611.GA17570@oksana.dev.rtsoft.ru>
For serial flash support we need to:
- Add QE Par IO Bank E device tree node, a GPIO from this bank is
used for SPI chip-select line;
- Add serial-flash node;
- Add proper module alias into of/base.c.
Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
arch/powerpc/boot/dts/mpc8569mds.dts | 26 +++++++++++++++++++++++---
drivers/of/base.c | 1 +
2 files changed, 24 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/boot/dts/mpc8569mds.dts b/arch/powerpc/boot/dts/mpc8569mds.dts
index 975f2c5..e06ee92 100644
--- a/arch/powerpc/boot/dts/mpc8569mds.dts
+++ b/arch/powerpc/boot/dts/mpc8569mds.dts
@@ -260,10 +260,21 @@
};
par_io@e0100 {
+ #address-cells = <1>;
+ #size-cells = <1>;
reg = <0xe0100 0x100>;
+ ranges = <0x0 0xe0100 0x100>;
device_type = "par_io";
num-ports = <7>;
+ qe_pio_e: gpio-controller@80 {
+ #gpio-cells = <2>;
+ compatible = "fsl,mpc8569-qe-pario-bank",
+ "fsl,mpc8323-qe-pario-bank";
+ reg = <0x80 0x18>;
+ gpio-controller;
+ };
+
pio1: ucc_pin@01 {
pio-map = <
/* port pin dir open_drain assignment has_irq */
@@ -369,12 +380,21 @@
};
spi@4c0 {
- cell-index = <0>;
- compatible = "fsl,spi";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "fsl,mpc8569-qe-spi", "fsl,spi";
reg = <0x4c0 0x40>;
+ cell-index = <0>;
interrupts = <2>;
interrupt-parent = <&qeic>;
- mode = "cpu";
+ gpios = <&qe_pio_e 30 0>;
+ mode = "cpu-qe";
+
+ serial-flash@0 {
+ compatible = "stm,m25p40";
+ reg = <0>;
+ spi-max-frequency = <25000000>;
+ };
};
spi@500 {
diff --git a/drivers/of/base.c b/drivers/of/base.c
index 41c5dfd..391f91c 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -447,6 +447,7 @@ struct of_modalias_table {
static struct of_modalias_table of_modalias_table[] = {
{ "fsl,mcu-mpc8349emitx", "mcu-mpc8349emitx" },
{ "mmc-spi-slot", "mmc_spi" },
+ { "stm,m25p40", "m25p80" },
};
/**
--
1.6.2.2
^ permalink raw reply related
* Re: [PATCH] therm_adt746x: Convert to a new-style i2c driver
From: Paul Mackerras @ 2009-05-02 3:42 UTC (permalink / raw)
To: Jean Delvare; +Cc: linuxppc-dev
In-Reply-To: <20090416225927.4254efc5@hyperion.delvare>
Jean Delvare writes:
> The legacy i2c binding model is going away soon, so convert the ppc
> therm_adt746x driver to the new model or it will break.
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
Seems to work OK on my powerbook (PowerBook5,4).
Tested-by: Paul Mackerras <paulus@samba.org>
Paul.
^ permalink raw reply
* Re: [PATCH] windfarm: Convert to a new-style i2c drivers
From: Paul Mackerras @ 2009-05-02 5:07 UTC (permalink / raw)
To: Jean Delvare; +Cc: linuxppc-dev
In-Reply-To: <20090416185615.2f7914ca@hyperion.delvare>
Jean Delvare writes:
> The legacy i2c binding model is going away soon, so convert the
> macintosh windfarm drivers to the new model or they will break.
All works OK on my quad G5 (PowerMac11,2).
Tested-by: Paul Mackerras <paulus@samba.org>
Paul.
^ permalink raw reply
* Re: [PATCH] windfarm: Convert to a new-style i2c drivers
From: Jean Delvare @ 2009-05-02 7:49 UTC (permalink / raw)
To: Paul Mackerras; +Cc: linuxppc-dev
In-Reply-To: <18939.54528.381551.291247@cargo.ozlabs.ibm.com>
On Sat, 2 May 2009 15:07:12 +1000, Paul Mackerras wrote:
> Jean Delvare writes:
>
> > The legacy i2c binding model is going away soon, so convert the
> > macintosh windfarm drivers to the new model or they will break.
>
> All works OK on my quad G5 (PowerMac11,2).
>
> Tested-by: Paul Mackerras <paulus@samba.org>
Great, thanks for the test results Paul! Only therm_windtunnel still
needs to be tested.
--
Jean Delvare
^ permalink raw reply
* Re: [PATCH] windfarm: Convert to a new-style i2c drivers
From: Josh Boyer @ 2009-05-02 11:29 UTC (permalink / raw)
To: Jean Delvare; +Cc: linuxppc-dev, Paul Mackerras
In-Reply-To: <20090502094909.3b70b216@hyperion.delvare>
On Sat, May 02, 2009 at 09:49:09AM +0200, Jean Delvare wrote:
>On Sat, 2 May 2009 15:07:12 +1000, Paul Mackerras wrote:
>> Jean Delvare writes:
>>
>> > The legacy i2c binding model is going away soon, so convert the
>> > macintosh windfarm drivers to the new model or they will break.
>>
>> All works OK on my quad G5 (PowerMac11,2).
>>
>> Tested-by: Paul Mackerras <paulus@samba.org>
>
>Great, thanks for the test results Paul! Only therm_windtunnel still
>needs to be tested.
I got my G4 installed yesterday. Will get a new kernel built for it over
the weekend and let you know.
josh
^ permalink raw reply
* Re: Please pull merge branch
From: Grant Likely @ 2009-05-02 13:38 UTC (permalink / raw)
To: Paul Mackerras, Benjamin Herrenschmidt, linuxppc-dev
In-Reply-To: <fa686aa40904282058l64fbcc7cp5ea3521951bd6b9c@mail.gmail.com>
Hi Paul/Ben,
Here is an updated pull request which adds a fix to the bootwrapper
Makefile clean-files list. Please pull 'merge' branch of
git://git.secretlab.ca/git/linux-2.6
Thanks,
g.
The following changes since commit 091438dd5668396328a3419abcbc6591159eb8d1=
:
Linus Torvalds (1):
Linux 2.6.30-rc4
are available in the git repository at:
git://git.secretlab.ca/git/linux-2.6 merge
Grant Likely (3):
powerpc: Update MPC5xxx and Xilinx Virtex maintainer entries
powerpc/virtex: Add uImage to the default images list
powerpc/boot: add simpleImage.* to clean-files list
John Linn (1):
powerpc/virtex: Fix duplicate level irq events.
MAINTAINERS | 4 +-
arch/powerpc/boot/Makefile | 2 +-
arch/powerpc/platforms/40x/Kconfig | 1 +
arch/powerpc/platforms/44x/Kconfig | 1 +
arch/powerpc/sysdev/xilinx_intc.c | 117 ++++++++++++++++++++++++++++++++=
---
5 files changed, 112 insertions(+), 13 deletions(-)
On Tue, Apr 28, 2009 at 9:58 PM, Grant Likely <grant.likely@secretlab.ca> w=
rote:
> Hi Paul/Ben,
>
> Here is a bug fix, a minor tweak and a tidy to merge for 2.6.30.
> Please pull 'merge' branch of git://git.secretlab.ca/git/linux-2.6
>
> Thanks,
> g.
>
> The following changes since commit 56a50adda49b2020156616c4eb15353e0f9ad7=
de:
> =A0Linus Torvalds (1):
> =A0 =A0 =A0 =A0Merge branch 'drm-intel-next' of
> git://git.kernel.org/.../anholt/drm-intel
>
> are available in the git repository at:
>
> =A0git://git.secretlab.ca/git/linux-2.6 merge
>
> Grant Likely (2):
> =A0 =A0 =A0powerpc: Update MPC5xxx and Xilinx Virtex maintainer entries
> =A0 =A0 =A0powerpc/virtex: Add uImage to the default images list
>
> John Linn (1):
> =A0 =A0 =A0powerpc/virtex: Fix duplicate level irq events.
>
> =A0MAINTAINERS =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0| =A0 =A04 =
+-
> =A0arch/powerpc/platforms/40x/Kconfig | =A0 =A01 +
> =A0arch/powerpc/platforms/44x/Kconfig | =A0 =A01 +
> =A0arch/powerpc/sysdev/xilinx_intc.c =A0| =A0117 ++++++++++++++++++++++++=
++++++++---
> =A04 files changed, 111 insertions(+), 12 deletions(-)
>
>
> --
> Grant Likely, B.Sc., P.Eng.
> Secret Lab Technologies Ltd.
>
--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
^ permalink raw reply
* Re: [PATCH 1/3] powerpc, Makefile: Make it possible to safely select CONFIG_FRAME_POINTER
From: Segher Boessenkool @ 2009-05-02 19:48 UTC (permalink / raw)
To: Anton Vorontsov
Cc: linux-kernel, linuxppc-dev, Steven Rostedt, Paul Mackerras,
Ingo Molnar, Sam Ravnborg
In-Reply-To: <20090502001421.GA9342@oksana.dev.rtsoft.ru>
> This patch introduces HAVE_NORMAL_FRAME_POINTER Kconfig symbol. When
> defined, the top level Makefile won't add -fno-omit-frame-pointer
> cflag (the flag is useless for PowerPC kernels, and also makes gcc
> generate wrong code).
> +++ b/arch/powerpc/Kconfig
> + select HAVE_NORMAL_FRAME_POINTER
> +config HAVE_NORMAL_FRAME_POINTER
> + bool
> + help
> + Architectures should select this symbol if their ABI implies
> + having a frame pointer.
I am totally confused what you call a frame pointer here.
None of the relevant PowerPC ABIs have a frame pointer
separate from the stack pointer; the compiler can create
one, of course. A better config symbol name and help text
would help understand this patch :-)
Segher
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox