From: "Allen Hubbe" <Allen.Hubbe@emc.com>
To: "'Baole Ni'" <baolex.ni@intel.com>, <jdmason@kudzu.us>,
<dave.jiang@intel.com>, <linuxwifi@intel.com>,
<kvalo@codeaurora.org>, <m.chehab@samsung.com>,
<pawel@osciak.com>, <m.szyprowski@samsung.com>,
<kyungmin.park@samsung.com>, <k.kozlowski@samsung.com>
Cc: <linux-ntb@googlegroups.com>, <linux-kernel@vger.kernel.org>,
<chuansheng.liu@intel.com>
Subject: RE: [PATCH 0807/1285] Replace numeric parameter like 0444 with macro
Date: Tue, 2 Aug 2016 09:45:55 -0400 [thread overview]
Message-ID: <000001d1ecc4$324df510$96e9df30$@emc.com> (raw)
In-Reply-To: <20160802114821.3765-1-baolex.ni@intel.com>
From: Baole Ni
> diff --git a/drivers/ntb/hw/intel/ntb_hw_intel.c b/drivers/ntb/hw/intel/ntb_hw_intel.c
> index 40d04ef..7aa1faa 100644
> --- a/drivers/ntb/hw/intel/ntb_hw_intel.c
> +++ b/drivers/ntb/hw/intel/ntb_hw_intel.c
> @@ -92,56 +92,56 @@ static const struct file_operations intel_ntb_debugfs_info;
> static struct dentry *debugfs_dir;
>
> static int b2b_mw_idx = -1;
> -module_param(b2b_mw_idx, int, 0644);
> +module_param(b2b_mw_idx, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
The result of this change should be simplified to S_IWUSR | S_IRUGO.
> module_param_named(xeon_b2b_usd_bar2_addr64,
> - xeon_b2b_usd_addr.bar2_addr64, ullong, 0644);
> + xeon_b2b_usd_addr.bar2_addr64, ullong, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
This line is 97 columns long.
The result of this change should be simplified to S_IWUSR | S_IRUGO, and that might put it under 80 columns. There are bound to still be other places where this kind of replacement will require additional changes to code formatting.
prev parent reply other threads:[~2016-08-02 13:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 11:48 [PATCH 0807/1285] Replace numeric parameter like 0444 with macro Baole Ni
2016-08-02 13:45 ` Allen Hubbe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001d1ecc4$324df510$96e9df30$@emc.com' \
--to=allen.hubbe@emc.com \
--cc=baolex.ni@intel.com \
--cc=chuansheng.liu@intel.com \
--cc=dave.jiang@intel.com \
--cc=jdmason@kudzu.us \
--cc=k.kozlowski@samsung.com \
--cc=kvalo@codeaurora.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
--cc=linuxwifi@intel.com \
--cc=m.chehab@samsung.com \
--cc=m.szyprowski@samsung.com \
--cc=pawel@osciak.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox