[PATCH 0807/1285] Replace numeric parameter like 0444 with macro

[PATCH 0807/1285] Replace numeric parameter like 0444 with macro

[Baole Ni]

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 drivers/ntb/hw/intel/ntb_hw_intel.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/ntb/hw/intel/ntb_hw_intel.c b/drivers/ntb/hw/intel/ntb_hw_intel.c
index 40d04ef..7aa1faa 100644
--- a/drivers/ntb/hw/intel/ntb_hw_intel.c
+++ b/drivers/ntb/hw/intel/ntb_hw_intel.c
@@ -92,56 +92,56 @@ static const struct file_operations intel_ntb_debugfs_info;
 static struct dentry *debugfs_dir;
 
 static int b2b_mw_idx = -1;
-module_param(b2b_mw_idx, int, 0644);
+module_param(b2b_mw_idx, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(b2b_mw_idx, "Use this mw idx to access the peer ntb.  A "
 		 "value of zero or positive starts from first mw idx, and a "
 		 "negative value starts from last mw idx.  Both sides MUST "
 		 "set the same value here!");
 
 static unsigned int b2b_mw_share;
-module_param(b2b_mw_share, uint, 0644);
+module_param(b2b_mw_share, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(b2b_mw_share, "If the b2b mw is large enough, configure the "
 		 "ntb so that the peer ntb only occupies the first half of "
 		 "the mw, so the second half can still be used as a mw.  Both "
 		 "sides MUST set the same value here!");
 
 module_param_named(xeon_b2b_usd_bar2_addr64,
-		   xeon_b2b_usd_addr.bar2_addr64, ullong, 0644);
+		   xeon_b2b_usd_addr.bar2_addr64, ullong, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(xeon_b2b_usd_bar2_addr64,
 		 "XEON B2B USD BAR 2 64-bit address");
 
 module_param_named(xeon_b2b_usd_bar4_addr64,
-		   xeon_b2b_usd_addr.bar4_addr64, ullong, 0644);
+		   xeon_b2b_usd_addr.bar4_addr64, ullong, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(xeon_b2b_usd_bar2_addr64,
 		 "XEON B2B USD BAR 4 64-bit address");
 
 module_param_named(xeon_b2b_usd_bar4_addr32,
-		   xeon_b2b_usd_addr.bar4_addr32, ullong, 0644);
+		   xeon_b2b_usd_addr.bar4_addr32, ullong, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(xeon_b2b_usd_bar2_addr64,
 		 "XEON B2B USD split-BAR 4 32-bit address");
 
 module_param_named(xeon_b2b_usd_bar5_addr32,
-		   xeon_b2b_usd_addr.bar5_addr32, ullong, 0644);
+		   xeon_b2b_usd_addr.bar5_addr32, ullong, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(xeon_b2b_usd_bar2_addr64,
 		 "XEON B2B USD split-BAR 5 32-bit address");
 
 module_param_named(xeon_b2b_dsd_bar2_addr64,
-		   xeon_b2b_dsd_addr.bar2_addr64, ullong, 0644);
+		   xeon_b2b_dsd_addr.bar2_addr64, ullong, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(xeon_b2b_dsd_bar2_addr64,
 		 "XEON B2B DSD BAR 2 64-bit address");
 
 module_param_named(xeon_b2b_dsd_bar4_addr64,
-		   xeon_b2b_dsd_addr.bar4_addr64, ullong, 0644);
+		   xeon_b2b_dsd_addr.bar4_addr64, ullong, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(xeon_b2b_dsd_bar2_addr64,
 		 "XEON B2B DSD BAR 4 64-bit address");
 
 module_param_named(xeon_b2b_dsd_bar4_addr32,
-		   xeon_b2b_dsd_addr.bar4_addr32, ullong, 0644);
+		   xeon_b2b_dsd_addr.bar4_addr32, ullong, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(xeon_b2b_dsd_bar2_addr64,
 		 "XEON B2B DSD split-BAR 4 32-bit address");
 
 module_param_named(xeon_b2b_dsd_bar5_addr32,
-		   xeon_b2b_dsd_addr.bar5_addr32, ullong, 0644);
+		   xeon_b2b_dsd_addr.bar5_addr32, ullong, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(xeon_b2b_dsd_bar2_addr64,
 		 "XEON B2B DSD split-BAR 5 32-bit address");
 
-- 
2.9.2

RE: [PATCH 0807/1285] Replace numeric parameter like 0444 with macro

[Allen Hubbe]

From: Baole Ni
> diff --git a/drivers/ntb/hw/intel/ntb_hw_intel.c b/drivers/ntb/hw/intel/ntb_hw_intel.c
> index 40d04ef..7aa1faa 100644
> --- a/drivers/ntb/hw/intel/ntb_hw_intel.c
> +++ b/drivers/ntb/hw/intel/ntb_hw_intel.c
> @@ -92,56 +92,56 @@ static const struct file_operations intel_ntb_debugfs_info;
>  static struct dentry *debugfs_dir;
> 
>  static int b2b_mw_idx = -1;
> -module_param(b2b_mw_idx, int, 0644);
> +module_param(b2b_mw_idx, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);

The result of this change should be simplified to S_IWUSR | S_IRUGO.

>  module_param_named(xeon_b2b_usd_bar2_addr64,
> -		   xeon_b2b_usd_addr.bar2_addr64, ullong, 0644);
> +		   xeon_b2b_usd_addr.bar2_addr64, ullong, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);

This line is 97 columns long.

The result of this change should be simplified to S_IWUSR | S_IRUGO, and that might put it under 80 columns.  There are bound to still be other places where this kind of replacement will require additional changes to code formatting.