public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Seunghui Lee" <sh043.lee@samsung.com>
To: "'Peter Wang (王信友)'" <peter.wang@mediatek.com>,
	beanhuo@micron.com, avri.altman@wdc.com, storage.sec@samsung.com,
	linux-scsi@vger.kernel.org, bvanassche@acm.org,
	linux-kernel@vger.kernel.org, alim.akhtar@samsung.com,
	adrian.hunter@intel.com, martin.petersen@oracle.com
Subject: RE: [PATCH] UFS: Make TM command timeout configurable from host side
Date: Mon, 17 Nov 2025 18:48:59 +0900	[thread overview]
Message-ID: <000001dc57a7$661a8040$324f80c0$@samsung.com> (raw)
In-Reply-To: <500022ecc5216afa01e7f606187f012294a76da3.camel@mediatek.com>

> On Mon, 2025-11-17 at 16:11 +0900, Seunghui Lee wrote:
> > Hi Mr.Wang,
> >
> > I understand your concerns about considering the worst-case scenario.
> > What about directly modifying TM_CMD_TIMEOUT (100ms -> 300ms) and
> > reducing the TM retry count from 100 to 30?
> >
> > Please let me know your opinion.
> >
> 
> 
> Hi Seunghui,
> 
> Changing TM_CMD_TIMEOUT from 100ms to 300ms is okay for me.
> The adjustment of the TM retry count from 100 to 30 is not significant, so
> it does not matter whether this change is made or not. Overall, this patch
> looks good to me.
> 

Thank you for your opinion.
I'll update the revision.

> However, the other TM clear timeout of 1 second has a much greater impact:
> ufshcd_wait_for_register(hba, REG_UTP_TRANSFER_REQ_DOOR_BELL,
>     mask, ~mask, 1000, 1000);
> Would you consider shortening this value as well?
> 
> Thanks
> Peter
> 

Thank you for your additional comment.
By the way, in my humble opinion, it's not about tm cmd timeout,
but about host register.

If it must be changed, how much time do you think for it?
I think that it's handled by different modification.

Thanks,
Seunghui Lee.


  reply	other threads:[~2025-11-17  9:49 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20251106012702epcas1p28fdeed020ea44f18dcc751c283fbbcc2@epcas1p2.samsung.com>
2025-11-06  1:26 ` [PATCH] UFS: Make TM command timeout configurable from host side Seunghui Lee
2025-11-11  2:46   ` Peter Wang (王信友)
2025-11-11  8:44     ` Seunghui Lee
2025-11-11  9:03       ` Peter Wang (王信友)
2025-11-11 16:37         ` Bart Van Assche
2025-11-12  2:58           ` Peter Wang (王信友)
2025-11-12  8:49             ` Seunghui Lee
2025-11-12  9:42               ` Peter Wang (王信友)
2025-11-12 16:51             ` Bart Van Assche
2025-11-13 10:08               ` Peter Wang (王信友)
2025-11-17  7:11                 ` Seunghui Lee
2025-11-17  8:40                   ` Peter Wang (王信友)
2025-11-17  9:48                     ` Seunghui Lee [this message]
2025-11-18  5:48                       ` Peter Wang (王信友)
2025-11-17 16:43                   ` Bart Van Assche
2025-11-18  5:55                     ` Peter Wang (王信友)
2025-11-18 17:31                       ` Bart Van Assche
2025-11-19  9:20                         ` Peter Wang (王信友)
2025-11-17 16:40                 ` Bart Van Assche
2025-11-18  5:52                   ` Peter Wang (王信友)
2025-11-11 16:38   ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000001dc57a7$661a8040$324f80c0$@samsung.com' \
    --to=sh043.lee@samsung.com \
    --cc=adrian.hunter@intel.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=peter.wang@mediatek.com \
    --cc=storage.sec@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox