public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: "Seunghui Lee" <sh043.lee@samsung.com>,
	"'Peter Wang (王信友)'" <peter.wang@mediatek.com>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	martin.petersen@oracle.com
Subject: Re: [PATCH] UFS: Make TM command timeout configurable from host side
Date: Mon, 17 Nov 2025 08:43:04 -0800	[thread overview]
Message-ID: <e3dcb711-990d-4e4e-a128-8a0cd0ce8886@acm.org> (raw)
In-Reply-To: <000001dc5791$5f2ea880$1d8bf980$@samsung.com>

On 11/16/25 11:11 PM, Seunghui Lee wrote:
>   /* maximum number of retries for a general UIC command  */
>   #define UFS_UIC_COMMAND_RETRIES 3
> @@ -7663,7 +7663,7 @@ int ufshcd_try_to_abort_task(struct ufs_hba *hba, int tag)
>          int poll_cnt;
>          u8 resp = 0xF;
>   
> -       for (poll_cnt = 100; poll_cnt; poll_cnt--) {
> +       for (poll_cnt = 30; poll_cnt; poll_cnt--) {
>                  err = ufshcd_issue_tm_cmd(hba, lrbp->lun, lrbp->task_tag,
>                                  UFS_QUERY_TASK, &resp);
>                  if (!err && resp == UPIU_TASK_MANAGEMENT_FUNC_SUCCEEDED) {

There are no other SCSI drivers I know of that have a retry loop around
the code that submits task management functions. I propose to reduce the
retry count in this function from 100 to 1.

Thanks,

Bart.

  parent reply	other threads:[~2025-11-17 16:43 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20251106012702epcas1p28fdeed020ea44f18dcc751c283fbbcc2@epcas1p2.samsung.com>
2025-11-06  1:26 ` [PATCH] UFS: Make TM command timeout configurable from host side Seunghui Lee
2025-11-11  2:46   ` Peter Wang (王信友)
2025-11-11  8:44     ` Seunghui Lee
2025-11-11  9:03       ` Peter Wang (王信友)
2025-11-11 16:37         ` Bart Van Assche
2025-11-12  2:58           ` Peter Wang (王信友)
2025-11-12  8:49             ` Seunghui Lee
2025-11-12  9:42               ` Peter Wang (王信友)
2025-11-12 16:51             ` Bart Van Assche
2025-11-13 10:08               ` Peter Wang (王信友)
2025-11-17  7:11                 ` Seunghui Lee
2025-11-17  8:40                   ` Peter Wang (王信友)
2025-11-17  9:48                     ` Seunghui Lee
2025-11-18  5:48                       ` Peter Wang (王信友)
2025-11-17 16:43                   ` Bart Van Assche [this message]
2025-11-18  5:55                     ` Peter Wang (王信友)
2025-11-18 17:31                       ` Bart Van Assche
2025-11-19  9:20                         ` Peter Wang (王信友)
2025-11-17 16:40                 ` Bart Van Assche
2025-11-18  5:52                   ` Peter Wang (王信友)
2025-11-11 16:38   ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3dcb711-990d-4e4e-a128-8a0cd0ce8886@acm.org \
    --to=bvanassche@acm.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=peter.wang@mediatek.com \
    --cc=sh043.lee@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox