* RE: [PATCH RESEND] f2fs:Fix incorrect return statement in the function f2fs_ioc_release_volatile_write
[not found] <1441542526-11916-1-git-send-email-xerofoify@gmail.com>
@ 2015-09-08 11:47 ` Chao Yu
0 siblings, 0 replies; only message in thread
From: Chao Yu @ 2015-09-08 11:47 UTC (permalink / raw)
To: 'Nicholas Krause', jaegeuk
Cc: cm224.lee, linux-f2fs-devel, linux-kernel
> -----Original Message-----
> From: Nicholas Krause [mailto:xerofoify@gmail.com]
> Sent: Sunday, September 06, 2015 8:29 PM
> To: jaegeuk@kernel.org
> Cc: cm224.lee@samsung.com; chao2.yu@samsung.com; linux-f2fs-devel@lists.sourceforge.net;
> linux-kernel@vger.kernel.org
> Subject: [PATCH RESEND] f2fs:Fix incorrect return statement in the function
> f2fs_ioc_release_volatile_write
>
> This fixes the incorrect return statement at the end of the function
> f2fs_ioc_release_volatile_write's body for returning zero as this is
> incorrect due to the function call before this return statement to
> the function punch_hole being able to fail and we should return this
> function's return fail directly in order to signal to callers of the
> function f2fs_ioc_release_volatile if a failure arises with this call
> to punch_hole fails.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
Reviewed-by: Chao Yu <chao2.yu@samsung.com>
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-09-08 11:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1441542526-11916-1-git-send-email-xerofoify@gmail.com>
2015-09-08 11:47 ` [PATCH RESEND] f2fs:Fix incorrect return statement in the function f2fs_ioc_release_volatile_write Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox