public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jingoo Han <jg1.han@samsung.com>
To: linux-kernel@vger.kernel.org
Cc: "'Bryan Wu'" <cooloney@gmail.com>,
	"'Lee Jones'" <lee.jones@linaro.org>,
	"'Jingoo Han'" <jg1.han@samsung.com>
Subject: [PATCH 13/18] backlight: s6e63m0: remove 'else' after a return
Date: Tue, 26 Aug 2014 22:01:12 +0900	[thread overview]
Message-ID: <00b701cfc12d$cff2f910$6fd8eb30$%han@samsung.com> (raw)
In-Reply-To: <009301cfc12d$2847ffd0$78d7ff70$%han@samsung.com>

Fixed the following checkpatch warning.

  WARNING: else is not generally useful after a break or return

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/video/backlight/s6e63m0.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/video/backlight/s6e63m0.c b/drivers/video/backlight/s6e63m0.c
index f3a65c8940ed..28bfa127fee4 100644
--- a/drivers/video/backlight/s6e63m0.c
+++ b/drivers/video/backlight/s6e63m0.c
@@ -507,19 +507,19 @@ static int s6e63m0_power_on(struct s6e63m0 *lcd)
 	if (!pd->power_on) {
 		dev_err(lcd->dev, "power_on is NULL.\n");
 		return -EINVAL;
-	} else {
-		pd->power_on(lcd->ld, 1);
-		msleep(pd->power_on_delay);
 	}
 
+	pd->power_on(lcd->ld, 1);
+	msleep(pd->power_on_delay);
+
 	if (!pd->reset) {
 		dev_err(lcd->dev, "reset is NULL.\n");
 		return -EINVAL;
-	} else {
-		pd->reset(lcd->ld);
-		msleep(pd->reset_delay);
 	}
 
+	pd->reset(lcd->ld);
+	msleep(pd->reset_delay);
+
 	ret = s6e63m0_ldi_init(lcd);
 	if (ret) {
 		dev_err(lcd->dev, "failed to initialize ldi.\n");
-- 
2.0.0



  parent reply	other threads:[~2014-08-26 13:01 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-26 12:56 [PATCH 00/18] backlight: fix checkpatch warnings Jingoo Han
2014-08-26 12:57 ` [PATCH 01/18] backlight: adp5520: add blank line after declarations Jingoo Han
2014-08-26 16:37   ` Lee Jones
2014-08-26 12:57 ` [PATCH 02/18] backlight: adp8860: " Jingoo Han
2014-08-26 16:37   ` Lee Jones
2014-08-26 12:57 ` [PATCH 03/18] backlight: adp8870: " Jingoo Han
2014-08-26 16:37   ` Lee Jones
2014-08-26 12:58 ` [PATCH 04/18] backlight: ams369fg06: remove 'else' after a return Jingoo Han
2014-08-26 16:36   ` Lee Jones
2014-08-26 12:58 ` [PATCH 05/18] backlight: corgi_lcd: add blank line after declarations Jingoo Han
2014-08-26 16:36   ` Lee Jones
2014-08-26 12:58 ` [PATCH 06/18] backlight: cr_bllcd: " Jingoo Han
2014-08-26 16:35   ` Lee Jones
2014-08-26 12:59 ` [PATCH 07/18] backlight: ili922x: remove 'else' after a return Jingoo Han
2014-08-26 16:35   ` Lee Jones
2014-08-26 12:59 ` [PATCH 08/18] backlight: ld9040: " Jingoo Han
2014-08-26 16:34   ` Lee Jones
2014-08-26 12:59 ` [PATCH 09/18] backlight: lm3639: remove unnecessary return statements Jingoo Han
2014-08-26 16:34   ` Lee Jones
2014-08-26 13:00 ` [PATCH 10/18] backlight: lms501kf03: remove 'else' after a return Jingoo Han
2014-08-26 16:33   ` Lee Jones
2014-08-26 13:00 ` [PATCH 11/18] backlight: lp855x: add blank line after declarations Jingoo Han
2014-08-26 16:33   ` Lee Jones
2014-08-26 13:00 ` [PATCH 12/18] backlight: pcf50633: " Jingoo Han
2014-08-26 16:31   ` Lee Jones
2014-08-26 16:32   ` Lee Jones
2014-08-26 16:32     ` Lee Jones
2014-08-26 13:01 ` Jingoo Han [this message]
2014-08-26 16:31   ` [PATCH 13/18] backlight: s6e63m0: remove 'else' after a return Lee Jones
2014-08-26 13:01 ` [PATCH 14/18] backlight: tdo24m: add blank line after declarations Jingoo Han
2014-08-26 16:30   ` Lee Jones
2014-08-26 13:01 ` [PATCH 15/18] backlight: wm831x_bl: " Jingoo Han
2014-08-26 16:30   ` Lee Jones
2014-08-26 13:02 ` [PATCH 16/18] backlight: jornada720: remove 'else' after a return Jingoo Han
2014-08-26 16:29   ` Lee Jones
2014-08-26 13:02 ` [PATCH 17/18] " Jingoo Han
2014-08-26 16:28   ` Lee Jones
2014-08-27  0:37     ` Jingoo Han
2014-08-26 13:02 ` [PATCH 18/18] backlight: omap1: add blank line after declarations Jingoo Han
2014-08-26 16:28   ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='00b701cfc12d$cff2f910$6fd8eb30$%han@samsung.com' \
    --to=jg1.han@samsung.com \
    --cc=cooloney@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox