From: Lee Jones <lee.jones@linaro.org>
To: Jingoo Han <jg1.han@samsung.com>
Cc: linux-kernel@vger.kernel.org, "'Bryan Wu'" <cooloney@gmail.com>
Subject: Re: [PATCH 11/18] backlight: lp855x: add blank line after declarations
Date: Tue, 26 Aug 2014 17:33:18 +0100 [thread overview]
Message-ID: <20140826163318.GM26707@lee--X1> (raw)
In-Reply-To: <00b501cfc12d$b5a1c280$20e54780$%han@samsung.com>
On Tue, 26 Aug 2014, Jingoo Han wrote:
> Fixed the following checkpatch warning.
>
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/backlight/lp855x_bl.c | 2 ++
> 1 file changed, 2 insertions(+)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c
> index dcdd5443efcf..25fb8e3d75b1 100644
> --- a/drivers/video/backlight/lp855x_bl.c
> +++ b/drivers/video/backlight/lp855x_bl.c
> @@ -268,6 +268,7 @@ static int lp855x_bl_update_status(struct backlight_device *bl)
>
> } else if (lp->mode == REGISTER_BASED) {
> u8 val = bl->props.brightness;
> +
> lp855x_write_byte(lp, lp->cfg->reg_brightness, val);
> }
>
> @@ -308,6 +309,7 @@ static ssize_t lp855x_get_chip_id(struct device *dev,
> struct device_attribute *attr, char *buf)
> {
> struct lp855x *lp = dev_get_drvdata(dev);
> +
> return scnprintf(buf, PAGE_SIZE, "%s\n", lp->chipname);
> }
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-08-26 16:33 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 12:56 [PATCH 00/18] backlight: fix checkpatch warnings Jingoo Han
2014-08-26 12:57 ` [PATCH 01/18] backlight: adp5520: add blank line after declarations Jingoo Han
2014-08-26 16:37 ` Lee Jones
2014-08-26 12:57 ` [PATCH 02/18] backlight: adp8860: " Jingoo Han
2014-08-26 16:37 ` Lee Jones
2014-08-26 12:57 ` [PATCH 03/18] backlight: adp8870: " Jingoo Han
2014-08-26 16:37 ` Lee Jones
2014-08-26 12:58 ` [PATCH 04/18] backlight: ams369fg06: remove 'else' after a return Jingoo Han
2014-08-26 16:36 ` Lee Jones
2014-08-26 12:58 ` [PATCH 05/18] backlight: corgi_lcd: add blank line after declarations Jingoo Han
2014-08-26 16:36 ` Lee Jones
2014-08-26 12:58 ` [PATCH 06/18] backlight: cr_bllcd: " Jingoo Han
2014-08-26 16:35 ` Lee Jones
2014-08-26 12:59 ` [PATCH 07/18] backlight: ili922x: remove 'else' after a return Jingoo Han
2014-08-26 16:35 ` Lee Jones
2014-08-26 12:59 ` [PATCH 08/18] backlight: ld9040: " Jingoo Han
2014-08-26 16:34 ` Lee Jones
2014-08-26 12:59 ` [PATCH 09/18] backlight: lm3639: remove unnecessary return statements Jingoo Han
2014-08-26 16:34 ` Lee Jones
2014-08-26 13:00 ` [PATCH 10/18] backlight: lms501kf03: remove 'else' after a return Jingoo Han
2014-08-26 16:33 ` Lee Jones
2014-08-26 13:00 ` [PATCH 11/18] backlight: lp855x: add blank line after declarations Jingoo Han
2014-08-26 16:33 ` Lee Jones [this message]
2014-08-26 13:00 ` [PATCH 12/18] backlight: pcf50633: " Jingoo Han
2014-08-26 16:31 ` Lee Jones
2014-08-26 16:32 ` Lee Jones
2014-08-26 16:32 ` Lee Jones
2014-08-26 13:01 ` [PATCH 13/18] backlight: s6e63m0: remove 'else' after a return Jingoo Han
2014-08-26 16:31 ` Lee Jones
2014-08-26 13:01 ` [PATCH 14/18] backlight: tdo24m: add blank line after declarations Jingoo Han
2014-08-26 16:30 ` Lee Jones
2014-08-26 13:01 ` [PATCH 15/18] backlight: wm831x_bl: " Jingoo Han
2014-08-26 16:30 ` Lee Jones
2014-08-26 13:02 ` [PATCH 16/18] backlight: jornada720: remove 'else' after a return Jingoo Han
2014-08-26 16:29 ` Lee Jones
2014-08-26 13:02 ` [PATCH 17/18] " Jingoo Han
2014-08-26 16:28 ` Lee Jones
2014-08-27 0:37 ` Jingoo Han
2014-08-26 13:02 ` [PATCH 18/18] backlight: omap1: add blank line after declarations Jingoo Han
2014-08-26 16:28 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140826163318.GM26707@lee--X1 \
--to=lee.jones@linaro.org \
--cc=cooloney@gmail.com \
--cc=jg1.han@samsung.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox