From: Dave Hansen <dave.hansen@intel.com>
To: Patryk Wlazlyn <patryk.wlazlyn@linux.intel.com>, x86@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
rafael.j.wysocki@intel.com, len.brown@intel.com,
artem.bityutskiy@linux.intel.com, dave.hansen@linux.intel.com
Subject: Re: [PATCH v9 3/4] intel_idle: Provide the default enter_dead() handler
Date: Mon, 3 Feb 2025 16:19:37 -0800 [thread overview]
Message-ID: <08c212d4-cad2-430f-8c94-a87f48ff50b6@intel.com> (raw)
In-Reply-To: <20250110115953.6058-4-patryk.wlazlyn@linux.intel.com>
On 1/10/25 03:59, Patryk Wlazlyn wrote:
> +static __cpuidle void intel_idle_enter_dead(struct cpuidle_device *dev,
> + int index)
> +{
> + struct cpuidle_driver *drv = cpuidle_get_cpu_driver(dev);
> + struct cpuidle_state *state = &drv->states[index];
> + unsigned long eax = flg2MWAIT(state->flags);
> +
> + mwait_play_dead(eax);
> +}
The __cpuidle marks this as noinstr, but cpuidle_get_cpu_driver() is not
noinstr, so the objtool complains:
vmlinux.o: warning: objtool: intel_idle_enter_dead+0x7: call to
cpuidle_get_cpu_driver() leaves .noinstr.text section
Patryk, can you fix this up, resync against 6.14-rc1 (there are some
minor merge conflicts) and resubmit, please?
I assume that it's OK to just make cpuidle_get_cpu_driver() __cpuidle
too. It doesn't do much.
next prev parent reply other threads:[~2025-02-04 0:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 11:59 [PATCH v9 0/4] SRF: Fix offline CPU preventing pc6 entry Patryk Wlazlyn
2025-01-10 11:59 ` [PATCH v9 1/4] x86/smp: Allow calling mwait_play_dead with an arbitrary hint Patryk Wlazlyn
2025-01-10 11:59 ` [PATCH v9 2/4] ACPI: processor_idle: Add FFH state handling Patryk Wlazlyn
2025-01-10 11:59 ` [PATCH v9 3/4] intel_idle: Provide the default enter_dead() handler Patryk Wlazlyn
2025-02-04 0:19 ` Dave Hansen [this message]
2025-01-10 11:59 ` [PATCH v9 4/4] x86/smp: Eliminate mwait_play_dead_cpuid_hint() Patryk Wlazlyn
2025-01-10 15:17 ` [PATCH v9 0/4] SRF: Fix offline CPU preventing pc6 entry Dave Hansen
2025-01-10 15:26 ` Artem Bityutskiy
2025-01-10 16:07 ` Dave Hansen
2025-01-10 16:50 ` Artem Bityutskiy
2025-01-16 16:02 ` Patryk Wlazlyn
2025-01-16 16:10 ` Rafael J. Wysocki
2025-01-13 19:31 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08c212d4-cad2-430f-8c94-a87f48ff50b6@intel.com \
--to=dave.hansen@intel.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=patryk.wlazlyn@linux.intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox