From: Patryk Wlazlyn <patryk.wlazlyn@linux.intel.com>
To: x86@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
rafael.j.wysocki@intel.com, len.brown@intel.com,
artem.bityutskiy@linux.intel.com, dave.hansen@linux.intel.com,
patryk.wlazlyn@linux.intel.com
Subject: [PATCH v9 0/4] SRF: Fix offline CPU preventing pc6 entry
Date: Fri, 10 Jan 2025 12:59:49 +0100 [thread overview]
Message-ID: <20250110115953.6058-1-patryk.wlazlyn@linux.intel.com> (raw)
Code for determining the mwait hint for the deepest C-state by
inspecting CPUID leaf 0x5 in mwait_play_dead() assumes that, if the
number of sub-states for a given major C-state is nonzero, those
sub-states are always represented by consecutive numbers starting from
0. This assumption is not based on the documented platform behavior and
in fact it is not met on recent Intel platforms.
Changes since v8:
* Revert the deletion of cpuidle_state_table check for enter and
s2idle handlers in intel_idle in 3/4:
- if (!cpuidle_state_table[cstate].enter &&
- !cpuidle_state_table[cstate].enter_s2idle)
+ if (!cpuidle_state_table[cstate].enter)
* Apply the changelog wording suggested by Rafael in v8 review.
Patryk Wlazlyn (4):
x86/smp: Allow calling mwait_play_dead with an arbitrary hint
ACPI: processor_idle: Add FFH state handling
intel_idle: Provide the default enter_dead() handler
x86/smp: Eliminate mwait_play_dead_cpuid_hint()
arch/x86/include/asm/smp.h | 3 +++
arch/x86/kernel/acpi/cstate.c | 10 ++++++++
arch/x86/kernel/smpboot.c | 46 ++++-------------------------------
drivers/acpi/processor_idle.c | 2 ++
drivers/idle/intel_idle.c | 15 ++++++++++++
include/acpi/processor.h | 5 ++++
6 files changed, 40 insertions(+), 41 deletions(-)
--
2.47.1
next reply other threads:[~2025-01-10 12:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 11:59 Patryk Wlazlyn [this message]
2025-01-10 11:59 ` [PATCH v9 1/4] x86/smp: Allow calling mwait_play_dead with an arbitrary hint Patryk Wlazlyn
2025-01-10 11:59 ` [PATCH v9 2/4] ACPI: processor_idle: Add FFH state handling Patryk Wlazlyn
2025-01-10 11:59 ` [PATCH v9 3/4] intel_idle: Provide the default enter_dead() handler Patryk Wlazlyn
2025-02-04 0:19 ` Dave Hansen
2025-01-10 11:59 ` [PATCH v9 4/4] x86/smp: Eliminate mwait_play_dead_cpuid_hint() Patryk Wlazlyn
2025-01-10 15:17 ` [PATCH v9 0/4] SRF: Fix offline CPU preventing pc6 entry Dave Hansen
2025-01-10 15:26 ` Artem Bityutskiy
2025-01-10 16:07 ` Dave Hansen
2025-01-10 16:50 ` Artem Bityutskiy
2025-01-16 16:02 ` Patryk Wlazlyn
2025-01-16 16:10 ` Rafael J. Wysocki
2025-01-13 19:31 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250110115953.6058-1-patryk.wlazlyn@linux.intel.com \
--to=patryk.wlazlyn@linux.intel.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox