* [PATCH] printks in drivers/scsi/hosts.c missing return
@ 2002-12-11 5:55 Robert Love
0 siblings, 0 replies; 2+ messages in thread
From: Robert Love @ 2002-12-11 5:55 UTC (permalink / raw)
To: linux-kernel
Linus is away so I am just throwing this out on lkml...
Trivial but annoying: two printk() calls in drivers/scsi/hosts.c are
missing '\n'
Also, for some reason I have not yet investigated, shost_tp->name is
NULL here. This should not be, eh? If it can be, we should do
something to tidy up the printing of it.
Patch is against 2.5.51.
Robert Love
drivers/scsi/hosts.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff -urN linux-2.5.51-mm1/drivers/scsi/hosts.c linux/drivers/scsi/hosts.c
--- linux-2.5.51-mm1/drivers/scsi/hosts.c 2002-12-10 17:45:02.000000000 -0500
+++ linux/drivers/scsi/hosts.c 2002-12-11 00:40:28.000000000 -0500
@@ -488,14 +488,14 @@
if (!shost_tp->max_sectors) {
printk(KERN_WARNING
"scsi HBA driver %s didn't set max_sectors, "
- "please fix the template", shost_tp->name);
+ "please fix the template\n", shost_tp->name);
shost_tp->max_sectors = 1024;
}
if (!shost_tp->release) {
printk(KERN_WARNING
"scsi HBA driver %s didn't set a release method, "
- "please fix the template", shost_tp->name);
+ "please fix the template\n", shost_tp->name);
shost_tp->release = &scsi_host_legacy_release;
}
^ permalink raw reply [flat|nested] 2+ messages in thread* [PATCH] printks in drivers/scsi/hosts.c missing return
@ 2002-12-14 2:23 Robert Love
0 siblings, 0 replies; 2+ messages in thread
From: Robert Love @ 2002-12-14 2:23 UTC (permalink / raw)
To: torvalds; +Cc: linux-kernel
Trivial but annoying: two printk() calls in drivers/scsi/hosts.c are
missing '\n'
Also, for some reason I have not yet investigated, shost_tp->name is
NULL here. This should not be, eh? If it can be, we should do
something to tidy up the printing of it.
Patch is against 2.5.51. Linus, please apply.
Robert Love
drivers/scsi/hosts.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff -urN linux-2.5.51-mm1/drivers/scsi/hosts.c linux/drivers/scsi/hosts.c
--- linux-2.5.51-mm1/drivers/scsi/hosts.c 2002-12-10 17:45:02.000000000 -0500
+++ linux/drivers/scsi/hosts.c 2002-12-11 00:40:28.000000000 -0500
@@ -488,14 +488,14 @@
if (!shost_tp->max_sectors) {
printk(KERN_WARNING
"scsi HBA driver %s didn't set max_sectors, "
- "please fix the template", shost_tp->name);
+ "please fix the template\n", shost_tp->name);
shost_tp->max_sectors = 1024;
}
if (!shost_tp->release) {
printk(KERN_WARNING
"scsi HBA driver %s didn't set a release method, "
- "please fix the template", shost_tp->name);
+ "please fix the template\n", shost_tp->name);
shost_tp->release = &scsi_host_legacy_release;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-12-14 2:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-12-11 5:55 [PATCH] printks in drivers/scsi/hosts.c missing return Robert Love
-- strict thread matches above, loose matches on Subject: below --
2002-12-14 2:23 Robert Love
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox