From: "David S. Miller" <davem@redhat.com>
To: trond.myklebust@fys.uio.no
Cc: Christoph Hellwig <hch@lst.de>,
torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remove useless MOD_{INC,DEC}_USE_COUNT from sunrpc
Date: 04 May 2003 12:06:06 -0700 [thread overview]
Message-ID: <1052075166.27465.12.camel@rth.ninka.net> (raw)
In-Reply-To: <16053.25445.434038.90945@charged.uio.no>
On Sun, 2003-05-04 at 12:00, Trond Myklebust wrote:
> >>>>> " " == Christoph Hellwig <hch@lst.de> writes:
>
> > Previously you incremented the usecount and now we're waiting
> > for the thread to finish in module_exit().
>
> Fair enough...
Well, what if this hangs? Unless the user specifies
"--wait" to 2.5.x's rmmod, the user absolutely does not
expect this behavior.
Rather, so that the "--wait" is respected, something one level
up ought to be doing try_module_get().
If you want to change the behavior, that's definitely to be considered,
but on a global scale not locally for sunrpc.
--
David S. Miller <davem@redhat.com>
next prev parent reply other threads:[~2003-05-04 20:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-04 17:14 [PATCH] remove useless MOD_{INC,DEC}_USE_COUNT from sunrpc Christoph Hellwig
2003-05-04 17:37 ` Trond Myklebust
2003-05-04 18:36 ` Christoph Hellwig
2003-05-04 18:46 ` Trond Myklebust
2003-05-04 18:53 ` Christoph Hellwig
2003-05-04 19:00 ` Trond Myklebust
2003-05-04 19:06 ` David S. Miller [this message]
2003-05-04 19:56 ` Trond Myklebust
2003-05-04 20:14 ` Trond Myklebust
2003-05-04 21:00 ` Christoph Hellwig
2003-05-04 20:15 ` David S. Miller
2003-05-05 8:29 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1052075166.27465.12.camel@rth.ninka.net \
--to=davem@redhat.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox