public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: David S Miller <davem@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
	torvalds@transmeta.com, Neil Brown <neilb@cse.unsw.edu.au>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remove useless MOD_{INC,DEC}_USE_COUNT from sunrpc
Date: 04 May 2003 22:14:36 +0200	[thread overview]
Message-ID: <shsbryisc43.fsf@charged.uio.no> (raw)
In-Reply-To: <16053.28792.244921.560392@charged.uio.no>

>>>>> " " == Trond Myklebust <trond.myklebust@fys.uio.no> writes:

     > There don't seem to be any checks and balances to prevent the
     > user from removing the sunrpc module immediately after
     > svc_create_thread() gets called.  I presume that the call to
     > lockd_up() in nfsd() will help (since that calls rpciod_up()
     > and hence MOD_INC_COUNT) but AFAICS there appears to be plenty
     > of possible races before we get to that point.

Sorry. I misread that code. The only nfsd problem goes the other way
round. nfsd() is not exported, and nfsd_svc() does not wait on the
threads to start, hence you have a race between nfsd_svc(), and the
MOD_INC_USE_COUNT inside the nfsd() threads.

Cheers,
  Trond

  reply	other threads:[~2003-05-04 20:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-04 17:14 [PATCH] remove useless MOD_{INC,DEC}_USE_COUNT from sunrpc Christoph Hellwig
2003-05-04 17:37 ` Trond Myklebust
2003-05-04 18:36   ` Christoph Hellwig
2003-05-04 18:46     ` Trond Myklebust
2003-05-04 18:53       ` Christoph Hellwig
2003-05-04 19:00         ` Trond Myklebust
2003-05-04 19:06           ` David S. Miller
2003-05-04 19:56             ` Trond Myklebust
2003-05-04 20:14               ` Trond Myklebust [this message]
2003-05-04 21:00             ` Christoph Hellwig
2003-05-04 20:15               ` David S. Miller
2003-05-05  8:29                 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=shsbryisc43.fsf@charged.uio.no \
    --to=trond.myklebust@fys.uio.no \
    --cc=davem@redhat.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@cse.unsw.edu.au \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox