From: Christoph Hellwig <hch@lst.de>
To: torvalds@transmeta.com, trond.myklebust@fys.uio.no
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] remove useless MOD_{INC,DEC}_USE_COUNT from sunrpc
Date: Sun, 4 May 2003 19:14:47 +0200 [thread overview]
Message-ID: <20030504191447.C10659@lst.de> (raw)
- both rpciod_up and rpciod_down do a gratious inc/dec of the
use count - but we can't ever be inside those function unless
it's called from an other module -> totally useless
- rpciod() (the ernel thread) also bumps the refcount when starting
and decrements it when exiting. but as a different module must
initiate this using rpciod_up/rpciod_down this is again not needed.
(except when a module does rpciod_up without a matching rpciod_down -
but that a big bug anyway and we don't need to partially handle that
using module refcounts).
--- 1.24/net/sunrpc/sched.c Thu Mar 27 12:42:11 2003
+++ edited/net/sunrpc/sched.c Thu May 1 16:52:23 2003
@@ -952,7 +952,6 @@
wait_queue_head_t *assassin = (wait_queue_head_t*) ptr;
int rounds = 0;
- MOD_INC_USE_COUNT;
lock_kernel();
/*
* Let our maker know we're running ...
@@ -995,7 +994,6 @@
dprintk("RPC: rpciod exiting\n");
unlock_kernel();
- MOD_DEC_USE_COUNT;
return 0;
}
@@ -1027,7 +1025,6 @@
{
int error = 0;
- MOD_INC_USE_COUNT;
down(&rpciod_sema);
dprintk("rpciod_up: pid %d, users %d\n", rpciod_pid, rpciod_users);
rpciod_users++;
@@ -1051,7 +1048,6 @@
error = 0;
out:
up(&rpciod_sema);
- MOD_DEC_USE_COUNT;
return error;
}
@@ -1060,7 +1056,6 @@
{
unsigned long flags;
- MOD_INC_USE_COUNT;
down(&rpciod_sema);
dprintk("rpciod_down pid %d sema %d\n", rpciod_pid, rpciod_users);
if (rpciod_users) {
@@ -1097,7 +1092,6 @@
spin_unlock_irqrestore(¤t->sighand->siglock, flags);
out:
up(&rpciod_sema);
- MOD_DEC_USE_COUNT;
}
#ifdef RPC_DEBUG
next reply other threads:[~2003-05-04 17:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-04 17:14 Christoph Hellwig [this message]
2003-05-04 17:37 ` [PATCH] remove useless MOD_{INC,DEC}_USE_COUNT from sunrpc Trond Myklebust
2003-05-04 18:36 ` Christoph Hellwig
2003-05-04 18:46 ` Trond Myklebust
2003-05-04 18:53 ` Christoph Hellwig
2003-05-04 19:00 ` Trond Myklebust
2003-05-04 19:06 ` David S. Miller
2003-05-04 19:56 ` Trond Myklebust
2003-05-04 20:14 ` Trond Myklebust
2003-05-04 21:00 ` Christoph Hellwig
2003-05-04 20:15 ` David S. Miller
2003-05-05 8:29 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030504191447.C10659@lst.de \
--to=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox