From: Johannes Berg <johannes@sipsolutions.net>
To: Stelian Pop <stelian@popies.net>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Vojtech Pavlik <vojtech@suse.cz>,
Frank Arnold <frank@scirocco-5v-turbo.de>
Subject: Re: [PATCH] Apple USB Touchpad driver (new)
Date: Fri, 08 Jul 2005 13:18:01 +0200 [thread overview]
Message-ID: <1120821481.5065.2.camel@localhost> (raw)
In-Reply-To: <20050708101731.GM18608@sd291.sivit.org>
[-- Attachment #1: Type: text/plain, Size: 680 bytes --]
Hi all,
Nice to see this going into the kernel :)
> This is a driver for the USB touchpad which can be found on
> post-February 2005 Apple PowerBooks (PowerBook5,6).
This is not perfectly correct, the PowerBook5,6 is afaik only the 15"
model, the 12" and 17" have other numbers. Maybe you should just leave
that out, likewise in the code/Kconfig file.
> +/*
> + * number of sensors. Note that only 16 of the 26 x sensors are used on
> + * 12" and 15" Powerbooks.
> + */
I think that is misleading, those sensors don't even exist on 12" and
15" powerbooks. Maybe it should say 'Note that only 16 instead of 26
sensors exist on 12" and 15" models'
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2005-07-08 11:20 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-08 10:17 [PATCH] Apple USB Touchpad driver (new) Stelian Pop
2005-07-08 11:18 ` Johannes Berg [this message]
2005-07-08 12:10 ` Stelian Pop
2005-07-09 19:13 ` Vojtech Pavlik
2005-07-09 22:48 ` Peter Osterlund
2005-07-10 12:04 ` Vojtech Pavlik
2005-07-11 0:15 ` Peter Osterlund
2005-07-11 10:39 ` Stelian Pop
2005-07-11 11:00 ` Vojtech Pavlik
2005-07-11 11:08 ` Stelian Pop
2005-07-11 11:21 ` Vojtech Pavlik
2005-07-11 12:47 ` Stelian Pop
2005-07-11 13:35 ` Stelian Pop
2005-07-12 9:05 ` Stelian Pop
2005-07-12 14:13 ` Dmitry Torokhov
2005-07-12 14:33 ` Stelian Pop
2005-07-12 14:47 ` Dmitry Torokhov
2005-07-12 18:13 ` Vojtech Pavlik
2005-07-12 19:21 ` Stelian Pop
[not found] ` <20050711035244.115067ac.akpm@osdl.org>
2005-07-11 11:04 ` Stelian Pop
2005-07-11 13:25 ` Peter Osterlund
2005-07-11 20:44 ` Lee Revell
2005-07-11 20:54 ` Stelian Pop
2005-07-11 13:48 ` Peter Osterlund
2005-07-11 10:47 ` Vojtech Pavlik
2005-07-09 22:32 ` Peter Osterlund
2005-07-10 11:58 ` Vojtech Pavlik
2005-07-11 10:06 ` Stelian Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1120821481.5065.2.camel@localhost \
--to=johannes@sipsolutions.net \
--cc=frank@scirocco-5v-turbo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=stelian@popies.net \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox