From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Stelian Pop <stelian@popies.net>
Cc: Vojtech Pavlik <vojtech@suse.cz>,
Peter Osterlund <petero2@telia.com>,
Andrew Morton <akpm@osdl.org>,
Johannes Berg <johannes@sipsolutions.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Frank Arnold <frank@scirocco-5v-turbo.de>
Subject: Re: [PATCH] Apple USB Touchpad driver (new)
Date: Tue, 12 Jul 2005 09:13:16 -0500 [thread overview]
Message-ID: <d120d5000507120713646089ee@mail.gmail.com> (raw)
In-Reply-To: <1121159126.4656.14.camel@localhost.localdomain>
Hi,
On 7/12/05, Stelian Pop <stelian@popies.net> wrote:
>
> + dev->input.id.bustype = BUS_USB;
> + dev->input.id.vendor = id->idVendor;
> + dev->input.id.product = id->idProduct;
> + dev->input.id.version = ATP_DRIVER_VERSION;
> +
Why don't we do what most of the other input devices and get version
from the device too? Actually we have this in input tree:
static inline void
usb_to_input_id(const struct usb_device *dev, struct input_id *id)
{
id->bustype = BUS_USB;
id->vendor = le16_to_cpu(dev->descriptor.idVendor);
id->product = le16_to_cpu(dev->descriptor.idProduct);
id->version = le16_to_cpu(dev->descriptor.bcdDevice);
}
--
Dmitry
next prev parent reply other threads:[~2005-07-12 14:15 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-08 10:17 [PATCH] Apple USB Touchpad driver (new) Stelian Pop
2005-07-08 11:18 ` Johannes Berg
2005-07-08 12:10 ` Stelian Pop
2005-07-09 19:13 ` Vojtech Pavlik
2005-07-09 22:48 ` Peter Osterlund
2005-07-10 12:04 ` Vojtech Pavlik
2005-07-11 0:15 ` Peter Osterlund
2005-07-11 10:39 ` Stelian Pop
2005-07-11 11:00 ` Vojtech Pavlik
2005-07-11 11:08 ` Stelian Pop
2005-07-11 11:21 ` Vojtech Pavlik
2005-07-11 12:47 ` Stelian Pop
2005-07-11 13:35 ` Stelian Pop
2005-07-12 9:05 ` Stelian Pop
2005-07-12 14:13 ` Dmitry Torokhov [this message]
2005-07-12 14:33 ` Stelian Pop
2005-07-12 14:47 ` Dmitry Torokhov
2005-07-12 18:13 ` Vojtech Pavlik
2005-07-12 19:21 ` Stelian Pop
[not found] ` <20050711035244.115067ac.akpm@osdl.org>
2005-07-11 11:04 ` Stelian Pop
2005-07-11 13:25 ` Peter Osterlund
2005-07-11 20:44 ` Lee Revell
2005-07-11 20:54 ` Stelian Pop
2005-07-11 13:48 ` Peter Osterlund
2005-07-11 10:47 ` Vojtech Pavlik
2005-07-09 22:32 ` Peter Osterlund
2005-07-10 11:58 ` Vojtech Pavlik
2005-07-11 10:06 ` Stelian Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d120d5000507120713646089ee@mail.gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=akpm@osdl.org \
--cc=dtor_core@ameritech.net \
--cc=frank@scirocco-5v-turbo.de \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=petero2@telia.com \
--cc=stelian@popies.net \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox