* [Patch] Overrun in sound/pci/au88x0/au88x0_pcm.c
@ 2006-04-10 10:13 Eric Sesterhenn
2006-04-11 4:03 ` Lee Revell
0 siblings, 1 reply; 2+ messages in thread
From: Eric Sesterhenn @ 2006-04-10 10:13 UTC (permalink / raw)
To: LKML
hi,
since idx is used as an index for vortex_pcm_prettyname[VORTEX_PCM_LAST],
it should not be equal to VORTEX_PCM_LAST. This fixes coverity bug id #572
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6.17-rc1/sound/pci/au88x0/au88x0_pcm.c.orig 2006-04-10 12:10:22.000000000 +0200
+++ linux-2.6.17-rc1/sound/pci/au88x0/au88x0_pcm.c 2006-04-10 12:10:41.000000000 +0200
@@ -506,7 +506,7 @@ static int __devinit snd_vortex_new_pcm(
int i;
int err, nr_capt;
- if ((chip == 0) || (idx < 0) || (idx > VORTEX_PCM_LAST))
+ if ((chip == 0) || (idx < 0) || (idx >= VORTEX_PCM_LAST))
return -ENODEV;
/* idx indicates which kind of PCM device. ADB, SPDIF, I2S and A3D share the
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Patch] Overrun in sound/pci/au88x0/au88x0_pcm.c
2006-04-10 10:13 [Patch] Overrun in sound/pci/au88x0/au88x0_pcm.c Eric Sesterhenn
@ 2006-04-11 4:03 ` Lee Revell
0 siblings, 0 replies; 2+ messages in thread
From: Lee Revell @ 2006-04-11 4:03 UTC (permalink / raw)
To: Eric Sesterhenn; +Cc: LKML, alsa-devel
Please send all ALSA bug fixes to alsa-devel (cc'ed)
On Mon, 2006-04-10 at 12:13 +0200, Eric Sesterhenn wrote:
> hi,
>
> since idx is used as an index for vortex_pcm_prettyname[VORTEX_PCM_LAST],
> it should not be equal to VORTEX_PCM_LAST. This fixes coverity bug id #572
>
> Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
>
> --- linux-2.6.17-rc1/sound/pci/au88x0/au88x0_pcm.c.orig 2006-04-10 12:10:22.000000000 +0200
> +++ linux-2.6.17-rc1/sound/pci/au88x0/au88x0_pcm.c 2006-04-10 12:10:41.000000000 +0200
> @@ -506,7 +506,7 @@ static int __devinit snd_vortex_new_pcm(
> int i;
> int err, nr_capt;
>
> - if ((chip == 0) || (idx < 0) || (idx > VORTEX_PCM_LAST))
> + if ((chip == 0) || (idx < 0) || (idx >= VORTEX_PCM_LAST))
> return -ENODEV;
>
> /* idx indicates which kind of PCM device. ADB, SPDIF, I2S and A3D share the
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-04-11 4:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-10 10:13 [Patch] Overrun in sound/pci/au88x0/au88x0_pcm.c Eric Sesterhenn
2006-04-11 4:03 ` Lee Revell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox