The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: "Randy.Dunlap" <rdunlap@xenotime.net>
Cc: lkml <linux-kernel@vger.kernel.org>, akpm <akpm@osdl.org>, mingo@elte.hr
Subject: Re: [PATCH] ktime/hrtimer: fix kernel-doc comments
Date: Mon, 19 Jun 2006 23:00:22 +0200	[thread overview]
Message-ID: <1150750822.29299.86.camel@localhost.localdomain> (raw)
In-Reply-To: <20060619130948.6ea3998c.rdunlap@xenotime.net>

Randy,

On Mon, 2006-06-19 at 13:09 -0700, Randy.Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
> 
> Fix kernel-doc formatting in ktime.h and hrtimer.[ch] files.
> 
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> ---
>  include/linux/hrtimer.h |    3 ---
>  include/linux/ktime.h   |    8 --------
>  kernel/hrtimer.c        |   11 +----------
>  3 files changed, 1 insertion(+), 21 deletions(-)
> 
> --- linux-2617-pv.orig/include/linux/ktime.h
> +++ linux-2617-pv/include/linux/ktime.h
> @@ -66,7 +66,6 @@ typedef union {
>  
>  /**
>   * ktime_set - Set a ktime_t variable from a seconds/nanoseconds value
> - *
>   * @secs:	seconds to set
>   * @nsecs:	nanoseconds to set
>   *
<.....>

Is there any real reason for doing this, expect for removing the blank
comment lines ? 

My personal preference is to keep that line, as it makes it easier to
read. But as always: de gustibus non est disputandum :)

	tglx





  reply	other threads:[~2006-06-19 20:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-19 20:09 [PATCH] ktime/hrtimer: fix kernel-doc comments Randy.Dunlap
2006-06-19 21:00 ` Thomas Gleixner [this message]
2006-06-19 21:11   ` Randy.Dunlap
2006-06-19 21:15     ` Thomas Gleixner
2006-06-19 21:20       ` Randy.Dunlap
2006-06-19 21:30         ` Thomas Gleixner
2006-06-19 21:41           ` Randy.Dunlap
2006-06-19 21:45             ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1150750822.29299.86.camel@localhost.localdomain \
    --to=tglx@linutronix.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hr \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox