* [patch 2.6.18-git] ide-cs (CompactFlash) driver, rm irq warning
@ 2006-10-02 16:02 David Brownell
2006-10-02 17:45 ` Alan Cox
0 siblings, 1 reply; 5+ messages in thread
From: David Brownell @ 2006-10-02 16:02 UTC (permalink / raw)
To: B.Zolnierkiewicz; +Cc: Linux Kernel list
Git rid of the runtime warning about pcmcia not supporting
exclusive IRQs, so "the driver needs updating".
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
--- osk.orig/drivers/ide/legacy/ide-cs.c 2006-09-28 19:27:51.000000000 -0700
+++ osk/drivers/ide/legacy/ide-cs.c 2006-10-02 08:25:21.000000000 -0700
@@ -120,7 +120,7 @@ static int ide_probe(struct pcmcia_devic
link->io.Attributes1 = IO_DATA_PATH_WIDTH_AUTO;
link->io.Attributes2 = IO_DATA_PATH_WIDTH_8;
link->io.IOAddrLines = 3;
- link->irq.Attributes = IRQ_TYPE_EXCLUSIVE;
+ link->irq.Attributes = IRQ_TYPE_DYNAMIC_SHARING;
link->irq.IRQInfo1 = IRQ_LEVEL_ID;
link->conf.Attributes = CONF_ENABLE_IRQ;
link->conf.IntType = INT_MEMORY_AND_IO;
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [patch 2.6.18-git] ide-cs (CompactFlash) driver, rm irq warning
2006-10-02 16:02 [patch 2.6.18-git] ide-cs (CompactFlash) driver, rm irq warning David Brownell
@ 2006-10-02 17:45 ` Alan Cox
2006-10-02 18:58 ` David Brownell
0 siblings, 1 reply; 5+ messages in thread
From: Alan Cox @ 2006-10-02 17:45 UTC (permalink / raw)
To: David Brownell; +Cc: B.Zolnierkiewicz, Linux Kernel list
Ar Llu, 2006-10-02 am 09:02 -0700, ysgrifennodd David Brownell:
> Git rid of the runtime warning about pcmcia not supporting
> exclusive IRQs, so "the driver needs updating".
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
You've audited the code to check this is safely handled ?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch 2.6.18-git] ide-cs (CompactFlash) driver, rm irq warning
2006-10-02 17:45 ` Alan Cox
@ 2006-10-02 18:58 ` David Brownell
2006-10-02 20:43 ` Alan Cox
0 siblings, 1 reply; 5+ messages in thread
From: David Brownell @ 2006-10-02 18:58 UTC (permalink / raw)
To: Alan Cox; +Cc: B.Zolnierkiewicz, Linux Kernel list
On Monday 02 October 2006 10:45 am, Alan Cox wrote:
> Ar Llu, 2006-10-02 am 09:02 -0700, ysgrifennodd David Brownell:
> > Git rid of the runtime warning about pcmcia not supporting
> > exclusive IRQs, so "the driver needs updating".
> >
> > Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
>
> You've audited the code to check this is safely handled ?
As best I can, yes. IDE being somewhat black-boxish to most of us.
The patch literally does no more than shut up the warning found in
drivers/pcmcia/pcmcia_resource.c ... it doesn't change any other
behavior in the PCMCIA layer. And the IDE layer never appeared to
have a problem.
The IRQ handler seems to be drivers/ide/ide-io.c::ide_intr() and
comments there reflect the expectation that it handle shared IRQs.
- Dave
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch 2.6.18-git] ide-cs (CompactFlash) driver, rm irq warning
2006-10-02 18:58 ` David Brownell
@ 2006-10-02 20:43 ` Alan Cox
2006-10-02 20:22 ` David Brownell
0 siblings, 1 reply; 5+ messages in thread
From: Alan Cox @ 2006-10-02 20:43 UTC (permalink / raw)
To: David Brownell; +Cc: B.Zolnierkiewicz, Linux Kernel list
Ar Llu, 2006-10-02 am 11:58 -0700, ysgrifennodd David Brownell:
> The IRQ handler seems to be drivers/ide/ide-io.c::ide_intr() and
> comments there reflect the expectation that it handle shared IRQs.
I was more worried what the pcmcia side may be up to but yes this should
get dealt with and -mm will find any horrors fast.
Acked-by: Alan Cox <alan@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch 2.6.18-git] ide-cs (CompactFlash) driver, rm irq warning
2006-10-02 20:43 ` Alan Cox
@ 2006-10-02 20:22 ` David Brownell
0 siblings, 0 replies; 5+ messages in thread
From: David Brownell @ 2006-10-02 20:22 UTC (permalink / raw)
To: Alan Cox; +Cc: B.Zolnierkiewicz, Linux Kernel list
On Monday 02 October 2006 1:43 pm, Alan Cox wrote:
> Ar Llu, 2006-10-02 am 11:58 -0700, ysgrifennodd David Brownell:
> > The IRQ handler seems to be drivers/ide/ide-io.c::ide_intr() and
> > comments there reflect the expectation that it handle shared IRQs.
>
> I was more worried what the pcmcia side may be up to
The relevant flag appears to be ignored inside drivers/pcmcia except
to trigger the annoying message ... leaving the remaining potential
for side effects inside the old IDE stack, which would already be
showing bug symptoms if there were any.
> but yes this should
> get dealt with and -mm will find any horrors fast.
>
> Acked-by: Alan Cox <alan@redhat.com>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2006-10-02 20:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-02 16:02 [patch 2.6.18-git] ide-cs (CompactFlash) driver, rm irq warning David Brownell
2006-10-02 17:45 ` Alan Cox
2006-10-02 18:58 ` David Brownell
2006-10-02 20:43 ` Alan Cox
2006-10-02 20:22 ` David Brownell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox