Re: [KJ-resend]replacing kmalloc with kzalloc in drivers/mtd/chips/cfi_probe.c

Re: [KJ-resend]replacing kmalloc with kzalloc in drivers/mtd/chips/cfi_probe.c

[Robert P. J. Day]

On Mon, 13 Aug 2007, Surya Prabhakar N wrote:

>
> Hi,
>    Replacing kmalloc with kzalloc and cleaning up memset in
> drivers/mtd/chips/cfi_probe.c. Kindly ignore the previous similar patch.
>
> Signed-off-by: Surya Prabhakar <surya.prabhakar@wipro.com>
> ---
>
> diff --git a/drivers/mtd/chips/cfi_probe.c b/drivers/mtd/chips/cfi_probe.c
> index 60e11a0..efb51f7 100644
> --- a/drivers/mtd/chips/cfi_probe.c
> +++ b/drivers/mtd/chips/cfi_probe.c
> @@ -203,14 +203,12 @@ static int __xipram cfi_chip_setup(struct map_info *map,
>  	if (!num_erase_regions)
>  		return 0;
>
> -	cfi->cfiq = kmalloc(sizeof(struct cfi_ident) + num_erase_regions * 4, GFP_KERNEL);
> +	cfi->cfiq = kzalloc(sizeof(struct cfi_ident) + num_erase_regions * 4, GFP_KERNEL);
>  	if (!cfi->cfiq) {
>  		printk(KERN_WARNING "%s: kmalloc failed for CFI ident structure\n", map->name);
>  		return 0;
>  	}
>
> -	memset(cfi->cfiq,0,sizeof(struct cfi_ident));
> -
>  	cfi->cfi_mode = CFI_MODE_CFI;

but that change is not precisely equivalent, it now clears more than
the original code.  as long as that's not a problem.

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================

[KJ-resend]replacing kmalloc with kzalloc in drivers/mtd/chips/cfi_probe.c

[Surya Prabhakar N]

Hi,
   Replacing kmalloc with kzalloc and cleaning up memset in 
drivers/mtd/chips/cfi_probe.c. Kindly ignore the previous similar patch.

Signed-off-by: Surya Prabhakar <surya.prabhakar@wipro.com>
---

diff --git a/drivers/mtd/chips/cfi_probe.c b/drivers/mtd/chips/cfi_probe.c
index 60e11a0..efb51f7 100644
--- a/drivers/mtd/chips/cfi_probe.c
+++ b/drivers/mtd/chips/cfi_probe.c
@@ -203,14 +203,12 @@ static int __xipram cfi_chip_setup(struct map_info *map,
 	if (!num_erase_regions)
 		return 0;
 
-	cfi->cfiq = kmalloc(sizeof(struct cfi_ident) + num_erase_regions * 4, GFP_KERNEL);
+	cfi->cfiq = kzalloc(sizeof(struct cfi_ident) + num_erase_regions * 4, GFP_KERNEL);
 	if (!cfi->cfiq) {
 		printk(KERN_WARNING "%s: kmalloc failed for CFI ident structure\n", map->name);
 		return 0;
 	}
 
-	memset(cfi->cfiq,0,sizeof(struct cfi_ident));
-
 	cfi->cfi_mode = CFI_MODE_CFI;
 
 	/* Read the CFI info structure */

thanks
surya.