* [KJ-resend]replacing kmalloc with kzalloc in drivers/mtd/chips/cfi_probe.c
@ 2007-08-13 9:49 Surya Prabhakar N
2007-08-13 9:47 ` Robert P. J. Day
0 siblings, 1 reply; 2+ messages in thread
From: Surya Prabhakar N @ 2007-08-13 9:49 UTC (permalink / raw)
To: dwmw2, linux-mtd; +Cc: linux-kernel
Hi,
Replacing kmalloc with kzalloc and cleaning up memset in
drivers/mtd/chips/cfi_probe.c. Kindly ignore the previous similar patch.
Signed-off-by: Surya Prabhakar <surya.prabhakar@wipro.com>
---
diff --git a/drivers/mtd/chips/cfi_probe.c b/drivers/mtd/chips/cfi_probe.c
index 60e11a0..efb51f7 100644
--- a/drivers/mtd/chips/cfi_probe.c
+++ b/drivers/mtd/chips/cfi_probe.c
@@ -203,14 +203,12 @@ static int __xipram cfi_chip_setup(struct map_info *map,
if (!num_erase_regions)
return 0;
- cfi->cfiq = kmalloc(sizeof(struct cfi_ident) + num_erase_regions * 4, GFP_KERNEL);
+ cfi->cfiq = kzalloc(sizeof(struct cfi_ident) + num_erase_regions * 4, GFP_KERNEL);
if (!cfi->cfiq) {
printk(KERN_WARNING "%s: kmalloc failed for CFI ident structure\n", map->name);
return 0;
}
- memset(cfi->cfiq,0,sizeof(struct cfi_ident));
-
cfi->cfi_mode = CFI_MODE_CFI;
/* Read the CFI info structure */
thanks
surya.
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [KJ-resend]replacing kmalloc with kzalloc in drivers/mtd/chips/cfi_probe.c
2007-08-13 9:49 [KJ-resend]replacing kmalloc with kzalloc in drivers/mtd/chips/cfi_probe.c Surya Prabhakar N
@ 2007-08-13 9:47 ` Robert P. J. Day
0 siblings, 0 replies; 2+ messages in thread
From: Robert P. J. Day @ 2007-08-13 9:47 UTC (permalink / raw)
To: Surya Prabhakar N; +Cc: dwmw2, linux-mtd, linux-kernel
On Mon, 13 Aug 2007, Surya Prabhakar N wrote:
>
> Hi,
> Replacing kmalloc with kzalloc and cleaning up memset in
> drivers/mtd/chips/cfi_probe.c. Kindly ignore the previous similar patch.
>
> Signed-off-by: Surya Prabhakar <surya.prabhakar@wipro.com>
> ---
>
> diff --git a/drivers/mtd/chips/cfi_probe.c b/drivers/mtd/chips/cfi_probe.c
> index 60e11a0..efb51f7 100644
> --- a/drivers/mtd/chips/cfi_probe.c
> +++ b/drivers/mtd/chips/cfi_probe.c
> @@ -203,14 +203,12 @@ static int __xipram cfi_chip_setup(struct map_info *map,
> if (!num_erase_regions)
> return 0;
>
> - cfi->cfiq = kmalloc(sizeof(struct cfi_ident) + num_erase_regions * 4, GFP_KERNEL);
> + cfi->cfiq = kzalloc(sizeof(struct cfi_ident) + num_erase_regions * 4, GFP_KERNEL);
> if (!cfi->cfiq) {
> printk(KERN_WARNING "%s: kmalloc failed for CFI ident structure\n", map->name);
> return 0;
> }
>
> - memset(cfi->cfiq,0,sizeof(struct cfi_ident));
> -
> cfi->cfi_mode = CFI_MODE_CFI;
but that change is not precisely equivalent, it now clears more than
the original code. as long as that's not a problem.
rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-08-13 14:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-13 9:49 [KJ-resend]replacing kmalloc with kzalloc in drivers/mtd/chips/cfi_probe.c Surya Prabhakar N
2007-08-13 9:47 ` Robert P. J. Day
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox