* [PATCH] FAT: Fix printk format strings.
@ 2007-10-11 9:17 Vegard Nossum
0 siblings, 0 replies; 3+ messages in thread
From: Vegard Nossum @ 2007-10-11 9:17 UTC (permalink / raw)
To: OGAWA Hirofumi; +Cc: linux-kernel
This makes sure printk format strings contain no more than a single
line.
Signed-off-by: Vegard Nossum <vegard.nossum@gmail.com>
---
fs/fat/inode.c | 3 ++-
fs/fat/misc.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/fat/inode.c b/fs/fat/inode.c
index 4baa5f2..06a1bd9 100644
--- a/fs/fat/inode.c
+++ b/fs/fat/inode.c
@@ -1301,7 +1301,8 @@ int fat_fill_super(struct super_block *sb, void *data, int silent,
fsinfo = (struct fat_boot_fsinfo *)fsinfo_bh->b_data;
if (!IS_FSINFO(fsinfo)) {
printk(KERN_WARNING
- "FAT: Did not find valid FSINFO signature.\n"
+ "FAT: Did not find valid FSINFO signature.\n");
+ printk(KERN_WARNING
" Found signature1 0x%08x signature2 0x%08x"
" (sector = %lu)\n",
le32_to_cpu(fsinfo->signature1),
diff --git a/fs/fat/misc.c b/fs/fat/misc.c
index 308f2b6..a4de2b8 100644
--- a/fs/fat/misc.c
+++ b/fs/fat/misc.c
@@ -55,7 +55,8 @@ void fat_clusters_flush(struct super_block *sb)
fsinfo = (struct fat_boot_fsinfo *)bh->b_data;
/* Sanity check */
if (!IS_FSINFO(fsinfo)) {
- printk(KERN_ERR "FAT: Did not find valid FSINFO signature.\n"
+ printk(KERN_ERR "FAT: Did not find valid FSINFO signature.\n");
+ printk(KERN_ERR
" Found signature1 0x%08x signature2 0x%08x"
" (sector = %lu)\n",
le32_to_cpu(fsinfo->signature1),
--
1.5.2.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] FAT: Fix printk format strings.
[not found] <9d2nm-1SV-11@gated-at.bofh.it>
@ 2007-10-11 10:58 ` Bodo Eggert
2007-10-11 17:28 ` OGAWA Hirofumi
0 siblings, 1 reply; 3+ messages in thread
From: Bodo Eggert @ 2007-10-11 10:58 UTC (permalink / raw)
To: Vegard Nossum, OGAWA Hirofumi, linux-kernel
Vegard Nossum <vegard.nossum@gmail.com> wrote:
> This makes sure printk format strings contain no more than a single
> line.
> printk(KERN_WARNING
> - "FAT: Did not find valid FSINFO signature.\n"
> + "FAT: Did not find valid FSINFO signature.\n");
> + printk(KERN_WARNING
> " Found signature1 0x%08x signature2 0x%08x"
> " (sector = %lu)\n",
What about something like
"Fat32: Invalid FSINFO signatures 0x%08x, 0x%08x; expected 0x%08x, 0x%08\n" ?
or
"Fat32: Invalid FSINFO signatures 0x%08x, 0x%08x\n" ?
--
bus error. passengers dumped.
Friß, Spammer: GYwky2@xvGdf6v.7eggert.dyndns.org
fD8g@tfnrkqq.7eggert.dyndns.org VpcWe@h5ib4vef.7eggert.dyndns.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] FAT: Fix printk format strings.
2007-10-11 10:58 ` Bodo Eggert
@ 2007-10-11 17:28 ` OGAWA Hirofumi
0 siblings, 0 replies; 3+ messages in thread
From: OGAWA Hirofumi @ 2007-10-11 17:28 UTC (permalink / raw)
To: 7eggert; +Cc: Vegard Nossum, linux-kernel
Bodo Eggert <7eggert@gmx.de> writes:
> Vegard Nossum <vegard.nossum@gmail.com> wrote:
>
>> This makes sure printk format strings contain no more than a single
>> line.
>
>> printk(KERN_WARNING
>> - "FAT: Did not find valid FSINFO signature.\n"
>> + "FAT: Did not find valid FSINFO signature.\n");
>> + printk(KERN_WARNING
>> " Found signature1 0x%08x signature2 0x%08x"
>> " (sector = %lu)\n",
>
> What about something like
> "Fat32: Invalid FSINFO signatures 0x%08x, 0x%08x; expected 0x%08x, 0x%08\n" ?
> or
> "Fat32: Invalid FSINFO signatures 0x%08x, 0x%08x\n" ?
Looks good to me. I'll modify a patch, and apply it.
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-10-11 17:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-11 9:17 [PATCH] FAT: Fix printk format strings Vegard Nossum
[not found] <9d2nm-1SV-11@gated-at.bofh.it>
2007-10-11 10:58 ` Bodo Eggert
2007-10-11 17:28 ` OGAWA Hirofumi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox